Vendor the canonical .golangci.yml (gomodguard_v2) #202

2026-09-23T01:48:14+02:00

clawbot commented

2026-09-23 01:48:14 +02:00

Replaces .golangci.yml with the canonical file from prompts main, as sneak/prompts#60 asks of every Go repo. The canonical file swaps the deprecated gomodguard for gomodguard_v2 with its module block list, and turns on the depguard test-support rule.

New sha256: 7122fcf0dd0ea57441374f98ebd98bb3da23decb67f9209fee5175170838fbd1. Issues and PRs that pin the old hash 021cc83f… as an untouched-file check need the new one after this lands.

The new config produced no findings in vaultik, so there are no source-fix commits, and the lint run prints no deprecation warnings.

Disclosures:

One difference from canonical, in its own commit: sneak.berlin/go/vaultik/internal/storage/faultstore is added to the depguard test-support deny list, as the canonical comment asks for a repo's own test-support packages. Its directory name does not end in test, so the rule would not otherwise cover it. No non-test code imports it.
No //nolint added.

Model: opus-5-5

Replaces `.golangci.yml` with the canonical file from `prompts` `main`, as https://git.eeqj.de/sneak/prompts/issues/60 asks of every Go repo. The canonical file swaps the deprecated `gomodguard` for `gomodguard_v2` with its module block list, and turns on the `depguard` `test-support` rule. New sha256: `7122fcf0dd0ea57441374f98ebd98bb3da23decb67f9209fee5175170838fbd1`. Issues and PRs that pin the old hash `021cc83f…` as an untouched-file check need the new one after this lands. The new config produced no findings in vaultik, so there are no source-fix commits, and the lint run prints no deprecation warnings. Disclosures: - One difference from canonical, in its own commit: `sneak.berlin/go/vaultik/internal/storage/faultstore` is added to the `depguard` `test-support` deny list, as the canonical comment asks for a repo's own test-support packages. Its directory name does not end in `test`, so the rule would not otherwise cover it. No non-test code imports it. - No `//nolint` added. Model: opus-5-5

clawbot added the needs-review label 2026-09-23 01:48:14 +02:00

clawbot self-assigned this 2026-09-23 01:48:14 +02:00

clawbot added 1 commit 2026-09-23 01:48:14 +02:00

Vendor the canonical .golangci.yml from prompts (closes #90 ) 9f79834b59

Fetched byte for byte from prompts main. It replaces the deprecated
gomodguard with gomodguard_v2 and turns on the depguard test-support
rule. vaultik had no deny entries of its own to carry forward.

Model: opus-5-5

clawbot referenced this pull request

2026-09-23 01:48:18 +02:00

golangci-lint deprecation: gomodguard replaced by gomodguard_v2 #90

clawbot commented

2026-09-23 01:52:16 +02:00

Review: FAIL (needs-rework)

.golangci.yml, depguard test-support deny list: sneak.berlin/go/vaultik/internal/storage/faultstore is left out. It is vaultik's own test-support package, and its directory name does not end in test. The canonical file's comment says a repository's test-support packages "have to be named here one at a time ... Add them". Without the entry, a non-test file can import faultstore into the shipped binary and lint stays green. Only net/http/httptest is guarded, and it is not vaultik's own package. So the PR's claim that the rule runs on vaultik and finds nothing is true only because the rule covers nothing of vaultik's. Acceptable: add that one import path to the deny list, keep the rest byte-identical to canonical, and in the PR body list it as the one allowed difference, with the resulting sha256.
PR body: rewrite the "No difference from canonical" and "Judgement call" disclosures to match the change above.

Model: opus-5-5

Review: FAIL (needs-rework) 1. `.golangci.yml`, `depguard` `test-support` deny list: `sneak.berlin/go/vaultik/internal/storage/faultstore` is left out. It is vaultik's own test-support package, and its directory name does not end in `test`. The canonical file's comment says a repository's test-support packages "have to be named here one at a time ... Add them". Without the entry, a non-test file can import `faultstore` into the shipped binary and lint stays green. Only `net/http/httptest` is guarded, and it is not vaultik's own package. So the PR's claim that the rule runs on vaultik and finds nothing is true only because the rule covers nothing of vaultik's. Acceptable: add that one import path to the deny list, keep the rest byte-identical to canonical, and in the PR body list it as the one allowed difference, with the resulting sha256. 2. PR body: rewrite the "No difference from canonical" and "Judgement call" disclosures to match the change above. Model: opus-5-5

clawbot added needs-rework and removed needs-review labels 2026-09-23 01:55:42 +02:00

clawbot added 1 commit 2026-09-23 01:58:53 +02:00

Deny vaultik's faultstore package to non-test code in depguard a995ad97dc

The canonical config asks each repo to name its own test-support
packages in the depguard test-support deny list. faultstore is one
and its directory name does not end in test.

Model: opus-5-5

clawbot commented

2026-09-23 01:58:58 +02:00

Rework: added sneak.berlin/go/vaultik/internal/storage/faultstore to the depguard test-support deny list in its own commit (lint still 0 issues, make check green); PR body disclosures updated with the new sha256.

Model: opus-5-5

Rework: added `sneak.berlin/go/vaultik/internal/storage/faultstore` to the `depguard` `test-support` deny list in its own commit (lint still 0 issues, `make check` green); PR body disclosures updated with the new sha256. Model: opus-5-5

clawbot added needs-review and removed needs-rework labels 2026-09-23 01:58:58 +02:00

clawbot commented

2026-09-23 02:04:53 +02:00