Removes four confirmed-dead pieces and fixes one formatting bug, each re-verified by grep against origin/next before deleting:
internal/models/ — the whole package plus its coverage-only test; grep found no production import.
internal/cli/vaultik_snapshot_types.go — a second SnapshotInfo type in package cli with no cli.SnapshotInfo references; the live one is in internal/vaultik.
test-config.yml (repo root) and test/integration-config.yml — both use source_dirs and other keys config.Config no longer has, so they would fail Validate(); no Go file or script references either. test/config.yaml stays (used by internal/config/config_test.go).
config set wrote back with bare yaml.Marshal, whose 4-space default reindented the whole file on the first set despite the README/help promise to preserve formatting. It now uses yaml.NewEncoder with 2-space indent, matching defaultConfigTemplate. A new test asserts a set round-trip keeps both comments and 2-space indent.
What a reviewer would trip over: the two same-named SnapshotInfo types made the cli one look live under a plain grep for the name; only the qualified cli.SnapshotInfo confirms it dead.
Disclosures:
Single commit, not one commit per deletion (issue DoD item 4), per task instruction.
test/integration-config.yml removed per the manager note on the issue; it carried a live-looking S3 endpoint and key that were unused.
No behavior change beyond item 4.
Model: opus-4-8
Closes https://git.eeqj.de/sneak/vaultik/issues/70.
Removes four confirmed-dead pieces and fixes one formatting bug, each re-verified by grep against `origin/next` before deleting:
- `internal/models/` — the whole package plus its coverage-only test; grep found no production import.
- `internal/cli/vaultik_snapshot_types.go` — a second `SnapshotInfo` type in package `cli` with no `cli.SnapshotInfo` references; the live one is in `internal/vaultik`.
- `test-config.yml` (repo root) and `test/integration-config.yml` — both use `source_dirs` and other keys `config.Config` no longer has, so they would fail `Validate()`; no Go file or script references either. `test/config.yaml` stays (used by `internal/config/config_test.go`).
- `config set` wrote back with bare `yaml.Marshal`, whose 4-space default reindented the whole file on the first set despite the README/help promise to preserve formatting. It now uses `yaml.NewEncoder` with 2-space indent, matching `defaultConfigTemplate`. A new test asserts a set round-trip keeps both comments and 2-space indent.
What a reviewer would trip over: the two same-named `SnapshotInfo` types made the `cli` one look live under a plain grep for the name; only the qualified `cli.SnapshotInfo` confirms it dead.
Disclosures:
- Single commit, not one commit per deletion (issue DoD item 4), per task instruction.
- `test/integration-config.yml` removed per the manager note on the issue; it carried a live-looking S3 endpoint and key that were unused.
- No behavior change beyond item 4.
Model: opus-4-8
Remove the unused internal/models package (and its coverage-only test),
internal/cli/vaultik_snapshot_types.go (a second, dead SnapshotInfo that
shadowed the live type in internal/vaultik), and two fixtures
(test-config.yml, test/integration-config.yml) that use source_dirs and
other keys config.Config no longer has. All confirmed by grep against
origin/next; none has a production consumer.
config set now writes via yaml.NewEncoder with 2-space indent, matching
defaultConfigTemplate, so the first set no longer reindents the file it
promises to preserve. A test covers the round-trip.
Single commit rather than one commit per deletion, per task instruction.
test/integration-config.yml removed per the manager note on the issue.
Model: opus-4-8
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #70.
Removes four confirmed-dead pieces and fixes one formatting bug, each re-verified by grep against
origin/nextbefore deleting:internal/models/— the whole package plus its coverage-only test; grep found no production import.internal/cli/vaultik_snapshot_types.go— a secondSnapshotInfotype in packagecliwith nocli.SnapshotInforeferences; the live one is ininternal/vaultik.test-config.yml(repo root) andtest/integration-config.yml— both usesource_dirsand other keysconfig.Configno longer has, so they would failValidate(); no Go file or script references either.test/config.yamlstays (used byinternal/config/config_test.go).config setwrote back with bareyaml.Marshal, whose 4-space default reindented the whole file on the first set despite the README/help promise to preserve formatting. It now usesyaml.NewEncoderwith 2-space indent, matchingdefaultConfigTemplate. A new test asserts a set round-trip keeps both comments and 2-space indent.What a reviewer would trip over: the two same-named
SnapshotInfotypes made theclione look live under a plain grep for the name; only the qualifiedcli.SnapshotInfoconfirms it dead.Disclosures:
test/integration-config.ymlremoved per the manager note on the issue; it carried a live-looking S3 endpoint and key that were unused.Model: opus-4-8
PASS
model: claude-opus-4-8