Correct --cron flag help to name warnings as unsuppressed (closes #87) #126

Merged
clawbot merged 1 commits from issue-87-cron-help-text into next 2026-09-21 14:55:46 +02:00
Collaborator

Changes the --cron cobra flag help string in internal/cli/snapshot.go from Run in cron mode (silent unless error) to Run in cron mode (silent unless warning or error).

--cron sets UI.SetQuiet(true), which silences only the seven quiet-aware UI methods; Warningf and Errorf are unconditional. The snapshot terminus routes its end-of-run summary through Warningf on purpose so cron delivers something on a successful run, so the old wording could lead a user to read normal output as failure. New wording matches the README corrected in #84.

A grep across .go and .md confirms this was the last user-facing string claiming --cron is silent except on error; the remaining --cron mentions are code comments (already accurate, addressed under #84) and the already-correct README. Help text is program output, so this is a user-visible change that #84 deliberately left out of a docs-only PR.

make check ran green under the shared gate lock (248s wall). The containerised lint layer executed genuinely rather than replaying a cache: a fresh per-run check-epoch value forces the lint steps to run, and it reported 0 issues; tests ran with real per-package timings.

Judgement call: TODO.md was not touched. Its Workflow section describes an older single-track model (branch from main, merge to main) superseded by the parallel next-branch process, and its Completed Steps hold narratives for structural changes; a one-word help-string fix does not warrant an entry.

Model: opus-4-8

Changes the `--cron` cobra flag help string in `internal/cli/snapshot.go` from `Run in cron mode (silent unless error)` to `Run in cron mode (silent unless warning or error)`. `--cron` sets `UI.SetQuiet(true)`, which silences only the seven quiet-aware `UI` methods; `Warningf` and `Errorf` are unconditional. The snapshot terminus routes its end-of-run summary through `Warningf` on purpose so cron delivers something on a successful run, so the old wording could lead a user to read normal output as failure. New wording matches the README corrected in https://git.eeqj.de/sneak/vaultik/issues/84. A grep across `.go` and `.md` confirms this was the last user-facing string claiming `--cron` is silent except on error; the remaining `--cron` mentions are code comments (already accurate, addressed under https://git.eeqj.de/sneak/vaultik/issues/84) and the already-correct README. Help text is program output, so this is a user-visible change that https://git.eeqj.de/sneak/vaultik/issues/84 deliberately left out of a docs-only PR. `make check` ran green under the shared gate lock (248s wall). The containerised lint layer executed genuinely rather than replaying a cache: a fresh per-run check-epoch value forces the lint steps to run, and it reported 0 issues; tests ran with real per-package timings. Judgement call: `TODO.md` was not touched. Its Workflow section describes an older single-track model (branch from `main`, merge to `main`) superseded by the parallel `next`-branch process, and its Completed Steps hold narratives for structural changes; a one-word help-string fix does not warrant an entry. Model: opus-4-8
clawbot added 1 commit 2026-09-21 09:27:43 +02:00
The --cron help string claimed "silent unless error", but cron mode sets
UI.SetQuiet(true), which suppresses only the seven quiet-aware UI methods;
Warningf and Errorf still print. The snapshot terminus deliberately routes
its end-of-run summary through Warningf so cron delivers something on
success, so a user trusting the old text could read normal output as a
failure signal. The string now reads "silent unless warning or error",
matching the README wording corrected in #84. No behavior change.

Model: opus-4-8
clawbot self-assigned this 2026-09-21 09:27:52 +02:00
clawbot added this to the 1.0.0 milestone 2026-09-21 09:27:52 +02:00
clawbot added the needs-review label 2026-09-21 09:27:53 +02:00
Author
Collaborator

PASS — the one-line --cron help string now correctly reads silent unless warning or error, matching the actual UI.SetQuiet behavior and the README, with no other user-facing string left claiming silent-except-on-error and make check green on a genuine (non-cached) lint run against current next.

Model: opus-4-8

PASS — the one-line `--cron` help string now correctly reads `silent unless warning or error`, matching the actual `UI.SetQuiet` behavior and the README, with no other user-facing string left claiming silent-except-on-error and `make check` green on a genuine (non-cached) lint run against current `next`. Model: opus-4-8
clawbot merged commit 583f65040a into next 2026-09-21 14:55:46 +02:00
clawbot deleted branch issue-87-cron-help-text 2026-09-21 14:55:46 +02:00
Sign in to join this conversation.