sneak
a4b8ea4402
All checks were successful
Check / check (pull_request) Successful in 3m22s
Bump golangci-lint from v2.10.1 to v2.12.2 in the Dockerfile lint stage (tag+digest pin) and script/bootstrap release-archive pins (linux amd64/arm64 sha256s). Replace .golangci.yml with the canonical v2-layout config so linter settings (lll 88, funlen 80/50, cyclop 15, dupl 100) actually apply. Fix all findings surfaced by the new linter and config: - noctx: use httptest.NewRequestWithContext in all tests - gosec G710/G703: route app redirects through a path-escaping redirectToApp helper; annotate internal log path usage - goconst: introduce shared constants for template/JSON keys and repeated test literals - lll: wrap lines to the 88-column limit - dupl: extract shared helpers (generic findAllByAppID in models, deleteAppResource in handlers, parsePush in webhook payloads, table-driven/helper-based test dedup) - nolintlint: drop nolint directives made obsolete by the new limits Record the change in TODO.md; make check is green.
67 lines
1.8 KiB
Go
67 lines
1.8 KiB
Go
package deploy_test
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"sneak.berlin/go/upaas/internal/config"
|
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
|
)
|
|
|
|
func TestCleanupCancelledDeploy_RemovesBuildDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tmpDir := t.TempDir()
|
|
cfg := &config.Config{DataDir: tmpDir}
|
|
|
|
svc := deploy.NewTestServiceWithConfig(slog.Default(), cfg, nil)
|
|
|
|
// Create a fake build directory matching the deployment pattern
|
|
appName := "test-app"
|
|
buildDir := svc.GetBuildDirExported(appName)
|
|
require.NoError(t, os.MkdirAll(buildDir, 0o750))
|
|
|
|
// Create deployment-specific dir: <deploymentID>-<random>
|
|
deployDir := filepath.Join(buildDir, "42-abc123")
|
|
require.NoError(t, os.MkdirAll(deployDir, 0o750))
|
|
|
|
// Create a file inside to verify full removal
|
|
require.NoError(
|
|
t,
|
|
os.WriteFile(filepath.Join(deployDir, "work"), []byte("test"), 0o600),
|
|
)
|
|
|
|
// Also create a dir for a different deployment (should NOT be removed)
|
|
otherDir := filepath.Join(buildDir, "99-xyz789")
|
|
require.NoError(t, os.MkdirAll(otherDir, 0o750))
|
|
|
|
// Run cleanup for deployment 42
|
|
svc.CleanupCancelledDeploy(context.Background(), appName, 42, "")
|
|
|
|
// Deployment 42's dir should be gone
|
|
_, err := os.Stat(deployDir)
|
|
assert.True(t, os.IsNotExist(err), "deployment build dir should be removed")
|
|
|
|
// Deployment 99's dir should still exist
|
|
_, err = os.Stat(otherDir)
|
|
assert.NoError(t, err, "other deployment build dir should not be removed")
|
|
}
|
|
|
|
func TestCleanupCancelledDeploy_NoBuildDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tmpDir := t.TempDir()
|
|
cfg := &config.Config{DataDir: tmpDir}
|
|
|
|
svc := deploy.NewTestServiceWithConfig(slog.Default(), cfg, nil)
|
|
|
|
// Should not panic when build dir doesn't exist
|
|
svc.CleanupCancelledDeploy(context.Background(), "nonexistent-app", 1, "")
|
|
}
|