sneak
a4b8ea4402
All checks were successful
Check / check (pull_request) Successful in 3m22s
Bump golangci-lint from v2.10.1 to v2.12.2 in the Dockerfile lint stage (tag+digest pin) and script/bootstrap release-archive pins (linux amd64/arm64 sha256s). Replace .golangci.yml with the canonical v2-layout config so linter settings (lll 88, funlen 80/50, cyclop 15, dupl 100) actually apply. Fix all findings surfaced by the new linter and config: - noctx: use httptest.NewRequestWithContext in all tests - gosec G710/G703: route app redirects through a path-escaping redirectToApp helper; annotate internal log path usage - goconst: introduce shared constants for template/JSON keys and repeated test literals - lll: wrap lines to the 88-column limit - dupl: extract shared helpers (generic findAllByAppID in models, deleteAppResource in handlers, parsePush in webhook payloads, table-driven/helper-based test dedup) - nolintlint: drop nolint directives made obsolete by the new limits Record the change in TODO.md; make check is green.
135 lines
2.8 KiB
Go
135 lines
2.8 KiB
Go
package models
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"sneak.berlin/go/upaas/internal/database"
|
|
)
|
|
|
|
// Volume represents a volume mount for an app container.
|
|
type Volume struct {
|
|
db *database.Database
|
|
|
|
ID int64
|
|
AppID string
|
|
HostPath string
|
|
ContainerPath string
|
|
ReadOnly bool
|
|
}
|
|
|
|
// NewVolume creates a new Volume with a database reference.
|
|
func NewVolume(db *database.Database) *Volume {
|
|
return &Volume{db: db}
|
|
}
|
|
|
|
// Save inserts or updates the volume in the database.
|
|
func (v *Volume) Save(ctx context.Context) error {
|
|
if v.ID == 0 {
|
|
return v.insert(ctx)
|
|
}
|
|
|
|
return v.update(ctx)
|
|
}
|
|
|
|
// Delete removes the volume from the database.
|
|
func (v *Volume) Delete(ctx context.Context) error {
|
|
_, err := v.db.Exec(ctx, "DELETE FROM app_volumes WHERE id = ?", v.ID)
|
|
|
|
return err
|
|
}
|
|
|
|
func (v *Volume) insert(ctx context.Context) error {
|
|
query := `
|
|
INSERT INTO app_volumes (app_id, host_path, container_path, readonly)
|
|
VALUES (?, ?, ?, ?)`
|
|
|
|
result, err := v.db.Exec(ctx, query,
|
|
v.AppID, v.HostPath, v.ContainerPath, v.ReadOnly,
|
|
)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
id, err := result.LastInsertId()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
v.ID = id
|
|
|
|
return nil
|
|
}
|
|
|
|
func (v *Volume) update(ctx context.Context) error {
|
|
query := `
|
|
UPDATE app_volumes SET host_path = ?, container_path = ?, readonly = ?
|
|
WHERE id = ?`
|
|
|
|
_, err := v.db.Exec(ctx, query, v.HostPath, v.ContainerPath, v.ReadOnly, v.ID)
|
|
|
|
return err
|
|
}
|
|
|
|
// FindVolume finds a volume by ID.
|
|
//
|
|
//nolint:nilnil // returning nil,nil is idiomatic for "not found" in Active Record
|
|
func FindVolume(
|
|
ctx context.Context,
|
|
db *database.Database,
|
|
id int64,
|
|
) (*Volume, error) {
|
|
vol := NewVolume(db)
|
|
|
|
query := `
|
|
SELECT id, app_id, host_path, container_path, readonly
|
|
FROM app_volumes WHERE id = ?`
|
|
|
|
row := db.QueryRow(ctx, query, id)
|
|
|
|
err := row.Scan(
|
|
&vol.ID, &vol.AppID, &vol.HostPath, &vol.ContainerPath, &vol.ReadOnly,
|
|
)
|
|
if err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, nil
|
|
}
|
|
|
|
return nil, fmt.Errorf("scanning volume: %w", err)
|
|
}
|
|
|
|
return vol, nil
|
|
}
|
|
|
|
func (v *Volume) scanDest() []any {
|
|
return []any{
|
|
&v.ID, &v.AppID, &v.HostPath, &v.ContainerPath, &v.ReadOnly,
|
|
}
|
|
}
|
|
|
|
// FindVolumesByAppID finds all volumes for an app.
|
|
func FindVolumesByAppID(
|
|
ctx context.Context,
|
|
db *database.Database,
|
|
appID string,
|
|
) ([]*Volume, error) {
|
|
query := `
|
|
SELECT id, app_id, host_path, container_path, readonly
|
|
FROM app_volumes WHERE app_id = ? ORDER BY container_path`
|
|
|
|
return findAllByAppID(ctx, db, query, appID, "volumes", NewVolume)
|
|
}
|
|
|
|
// DeleteVolumesByAppID deletes all volumes for an app.
|
|
func DeleteVolumesByAppID(
|
|
ctx context.Context,
|
|
db *database.Database,
|
|
appID string,
|
|
) error {
|
|
_, err := db.Exec(ctx, "DELETE FROM app_volumes WHERE app_id = ?", appID)
|
|
|
|
return err
|
|
}
|