sneak
a4b8ea4402
All checks were successful
Check / check (pull_request) Successful in 3m22s
Bump golangci-lint from v2.10.1 to v2.12.2 in the Dockerfile lint stage (tag+digest pin) and script/bootstrap release-archive pins (linux amd64/arm64 sha256s). Replace .golangci.yml with the canonical v2-layout config so linter settings (lll 88, funlen 80/50, cyclop 15, dupl 100) actually apply. Fix all findings surfaced by the new linter and config: - noctx: use httptest.NewRequestWithContext in all tests - gosec G710/G703: route app redirects through a path-escaping redirectToApp helper; annotate internal log path usage - goconst: introduce shared constants for template/JSON keys and repeated test literals - lll: wrap lines to the 88-column limit - dupl: extract shared helpers (generic findAllByAppID in models, deleteAppResource in handlers, parsePush in webhook payloads, table-driven/helper-based test dedup) - nolintlint: drop nolint directives made obsolete by the new limits Record the change in TODO.md; make check is green.
123 lines
2.4 KiB
Go
123 lines
2.4 KiB
Go
package models
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"sneak.berlin/go/upaas/internal/database"
|
|
)
|
|
|
|
// Label represents a Docker label for an app container.
|
|
type Label struct {
|
|
db *database.Database
|
|
|
|
ID int64
|
|
AppID string
|
|
Key string
|
|
Value string
|
|
}
|
|
|
|
// NewLabel creates a new Label with a database reference.
|
|
func NewLabel(db *database.Database) *Label {
|
|
return &Label{db: db}
|
|
}
|
|
|
|
// Save inserts or updates the label in the database.
|
|
func (l *Label) Save(ctx context.Context) error {
|
|
if l.ID == 0 {
|
|
return l.insert(ctx)
|
|
}
|
|
|
|
return l.update(ctx)
|
|
}
|
|
|
|
// Delete removes the label from the database.
|
|
func (l *Label) Delete(ctx context.Context) error {
|
|
_, err := l.db.Exec(ctx, "DELETE FROM app_labels WHERE id = ?", l.ID)
|
|
|
|
return err
|
|
}
|
|
|
|
func (l *Label) insert(ctx context.Context) error {
|
|
query := "INSERT INTO app_labels (app_id, key, value) VALUES (?, ?, ?)"
|
|
|
|
result, err := l.db.Exec(ctx, query, l.AppID, l.Key, l.Value)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
id, err := result.LastInsertId()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
l.ID = id
|
|
|
|
return nil
|
|
}
|
|
|
|
func (l *Label) update(ctx context.Context) error {
|
|
query := "UPDATE app_labels SET key = ?, value = ? WHERE id = ?"
|
|
|
|
_, err := l.db.Exec(ctx, query, l.Key, l.Value, l.ID)
|
|
|
|
return err
|
|
}
|
|
|
|
// FindLabel finds a label by ID.
|
|
//
|
|
//nolint:nilnil // returning nil,nil is idiomatic for "not found" in Active Record
|
|
func FindLabel(
|
|
ctx context.Context,
|
|
db *database.Database,
|
|
id int64,
|
|
) (*Label, error) {
|
|
label := NewLabel(db)
|
|
|
|
row := db.QueryRow(ctx,
|
|
"SELECT id, app_id, key, value FROM app_labels WHERE id = ?",
|
|
id,
|
|
)
|
|
|
|
err := row.Scan(&label.ID, &label.AppID, &label.Key, &label.Value)
|
|
if err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, nil
|
|
}
|
|
|
|
return nil, fmt.Errorf("scanning label: %w", err)
|
|
}
|
|
|
|
return label, nil
|
|
}
|
|
|
|
func (l *Label) scanDest() []any {
|
|
return []any{&l.ID, &l.AppID, &l.Key, &l.Value}
|
|
}
|
|
|
|
// FindLabelsByAppID finds all labels for an app.
|
|
func FindLabelsByAppID(
|
|
ctx context.Context,
|
|
db *database.Database,
|
|
appID string,
|
|
) ([]*Label, error) {
|
|
query := `
|
|
SELECT id, app_id, key, value FROM app_labels
|
|
WHERE app_id = ? ORDER BY key`
|
|
|
|
return findAllByAppID(ctx, db, query, appID, "labels", NewLabel)
|
|
}
|
|
|
|
// DeleteLabelsByAppID deletes all labels for an app.
|
|
func DeleteLabelsByAppID(
|
|
ctx context.Context,
|
|
db *database.Database,
|
|
appID string,
|
|
) error {
|
|
_, err := db.Exec(ctx, "DELETE FROM app_labels WHERE app_id = ?", appID)
|
|
|
|
return err
|
|
}
|