sneak
a4b8ea4402
All checks were successful
Check / check (pull_request) Successful in 3m22s
Bump golangci-lint from v2.10.1 to v2.12.2 in the Dockerfile lint stage (tag+digest pin) and script/bootstrap release-archive pins (linux amd64/arm64 sha256s). Replace .golangci.yml with the canonical v2-layout config so linter settings (lll 88, funlen 80/50, cyclop 15, dupl 100) actually apply. Fix all findings surfaced by the new linter and config: - noctx: use httptest.NewRequestWithContext in all tests - gosec G710/G703: route app redirects through a path-escaping redirectToApp helper; annotate internal log path usage - goconst: introduce shared constants for template/JSON keys and repeated test literals - lll: wrap lines to the 88-column limit - dupl: extract shared helpers (generic findAllByAppID in models, deleteAppResource in handlers, parsePush in webhook payloads, table-driven/helper-based test dedup) - nolintlint: drop nolint directives made obsolete by the new limits Record the change in TODO.md; make check is green.
57 lines
1.3 KiB
Go
57 lines
1.3 KiB
Go
package handlers
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
|
|
"sneak.berlin/go/upaas/internal/models"
|
|
"sneak.berlin/go/upaas/templates"
|
|
)
|
|
|
|
// webhookEventsLimit is the number of webhook events to show in history.
|
|
const webhookEventsLimit = 100
|
|
|
|
// HandleAppWebhookEvents returns the webhook event history handler.
|
|
func (h *Handlers) HandleAppWebhookEvents() http.HandlerFunc {
|
|
tmpl := templates.GetParsed()
|
|
|
|
return func(writer http.ResponseWriter, request *http.Request) {
|
|
appID := chi.URLParam(request, "id")
|
|
|
|
application, findErr := models.FindApp(request.Context(), h.db, appID)
|
|
if findErr != nil {
|
|
h.log.Error("failed to find app", "error", findErr)
|
|
http.Error(writer, "Internal Server Error", http.StatusInternalServerError)
|
|
|
|
return
|
|
}
|
|
|
|
if application == nil {
|
|
http.NotFound(writer, request)
|
|
|
|
return
|
|
}
|
|
|
|
events, eventsErr := application.GetWebhookEvents(
|
|
request.Context(),
|
|
webhookEventsLimit,
|
|
)
|
|
if eventsErr != nil {
|
|
h.log.Error("failed to get webhook events",
|
|
"error", eventsErr,
|
|
"app", appID,
|
|
)
|
|
|
|
events = []*models.WebhookEvent{}
|
|
}
|
|
|
|
data := h.addGlobals(map[string]any{
|
|
dataKeyApp: application,
|
|
"Events": events,
|
|
}, request)
|
|
|
|
h.renderTemplate(writer, tmpl, "webhook_events.html", data)
|
|
}
|
|
}
|