sneak
a4b8ea4402
All checks were successful
Check / check (pull_request) Successful in 3m22s
Bump golangci-lint from v2.10.1 to v2.12.2 in the Dockerfile lint stage (tag+digest pin) and script/bootstrap release-archive pins (linux amd64/arm64 sha256s). Replace .golangci.yml with the canonical v2-layout config so linter settings (lll 88, funlen 80/50, cyclop 15, dupl 100) actually apply. Fix all findings surfaced by the new linter and config: - noctx: use httptest.NewRequestWithContext in all tests - gosec G710/G703: route app redirects through a path-escaping redirectToApp helper; annotate internal log path usage - goconst: introduce shared constants for template/JSON keys and repeated test literals - lll: wrap lines to the 88-column limit - dupl: extract shared helpers (generic findAllByAppID in models, deleteAppResource in handlers, parsePush in webhook payloads, table-driven/helper-based test dedup) - nolintlint: drop nolint directives made obsolete by the new limits Record the change in TODO.md; make check is green.
136 lines
3.2 KiB
Go
136 lines
3.2 KiB
Go
// Package handlers provides HTTP request handlers.
|
|
package handlers
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
|
|
"github.com/gorilla/csrf"
|
|
"go.uber.org/fx"
|
|
|
|
"sneak.berlin/go/upaas/internal/database"
|
|
"sneak.berlin/go/upaas/internal/docker"
|
|
"sneak.berlin/go/upaas/internal/globals"
|
|
"sneak.berlin/go/upaas/internal/healthcheck"
|
|
"sneak.berlin/go/upaas/internal/logger"
|
|
"sneak.berlin/go/upaas/internal/service/app"
|
|
"sneak.berlin/go/upaas/internal/service/auth"
|
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
|
"sneak.berlin/go/upaas/internal/service/webhook"
|
|
"sneak.berlin/go/upaas/templates"
|
|
)
|
|
|
|
// Template data keys shared across handlers.
|
|
const (
|
|
dataKeyApp = "App"
|
|
dataKeyError = "Error"
|
|
)
|
|
|
|
// JSON response keys shared across handlers.
|
|
const (
|
|
jsonKeyError = "error"
|
|
jsonKeyLogs = "logs"
|
|
jsonKeyStatus = "status"
|
|
)
|
|
|
|
// Params contains dependencies for Handlers.
|
|
type Params struct {
|
|
fx.In
|
|
|
|
Logger *logger.Logger
|
|
Globals *globals.Globals
|
|
Database *database.Database
|
|
Healthcheck *healthcheck.Healthcheck
|
|
Auth *auth.Service
|
|
App *app.Service
|
|
Deploy *deploy.Service
|
|
Webhook *webhook.Service
|
|
Docker *docker.Client
|
|
}
|
|
|
|
// Handlers provides HTTP request handlers.
|
|
type Handlers struct {
|
|
log *slog.Logger
|
|
params *Params
|
|
db *database.Database
|
|
hc *healthcheck.Healthcheck
|
|
auth *auth.Service
|
|
appService *app.Service
|
|
deploy *deploy.Service
|
|
webhook *webhook.Service
|
|
docker *docker.Client
|
|
globals *globals.Globals
|
|
}
|
|
|
|
// New creates a new Handlers instance.
|
|
func New(_ fx.Lifecycle, params Params) (*Handlers, error) {
|
|
return &Handlers{
|
|
log: params.Logger.Get(),
|
|
params: ¶ms,
|
|
db: params.Database,
|
|
hc: params.Healthcheck,
|
|
auth: params.Auth,
|
|
appService: params.App,
|
|
deploy: params.Deploy,
|
|
webhook: params.Webhook,
|
|
docker: params.Docker,
|
|
globals: params.Globals,
|
|
}, nil
|
|
}
|
|
|
|
// addGlobals adds version info and CSRF token to template data map.
|
|
func (h *Handlers) addGlobals(
|
|
data map[string]any,
|
|
request *http.Request,
|
|
) map[string]any {
|
|
data["Version"] = h.globals.Version
|
|
data["Appname"] = h.globals.Appname
|
|
|
|
if request != nil {
|
|
data["CSRFField"] = csrf.TemplateField(request)
|
|
}
|
|
|
|
return data
|
|
}
|
|
|
|
// renderTemplate executes the named template into a buffer first, then writes
|
|
// to the ResponseWriter only on success. This prevents partial/corrupt HTML
|
|
// responses when template execution fails partway through.
|
|
func (h *Handlers) renderTemplate(
|
|
writer http.ResponseWriter,
|
|
tmpl *templates.TemplateExecutor,
|
|
name string,
|
|
data any,
|
|
) {
|
|
var buf bytes.Buffer
|
|
|
|
err := tmpl.ExecuteTemplate(&buf, name, data)
|
|
if err != nil {
|
|
h.log.Error("template execution failed", "error", err)
|
|
http.Error(writer, "Internal Server Error", http.StatusInternalServerError)
|
|
|
|
return
|
|
}
|
|
|
|
_, _ = buf.WriteTo(writer)
|
|
}
|
|
|
|
func (h *Handlers) respondJSON(
|
|
writer http.ResponseWriter,
|
|
_ *http.Request,
|
|
data any,
|
|
status int,
|
|
) {
|
|
writer.Header().Set("Content-Type", "application/json")
|
|
writer.WriteHeader(status)
|
|
|
|
if data != nil {
|
|
err := json.NewEncoder(writer).Encode(data)
|
|
if err != nil {
|
|
h.log.Error("json encode error", "error", err)
|
|
}
|
|
}
|
|
}
|