All checks were successful
Check / check (push) Successful in 4s
Bumps golangci-lint from v2.10.1 to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then fixes every finding the new linter surfaces so `make check` is green. ## Version pins - `Dockerfile` lint stage: `golangci/golangci-lint:v2.12.2` (Debian-based), tag plus digest pin - `script/bootstrap`: `GOLANGCI_LINT_VERSION=2.12.2` with updated `linux-amd64`/`linux-arm64` release-archive sha256 pins ## Config `.golangci.yml` replaced with the canonical config. Material change: the old file declared `version: "2"` but kept settings under the legacy top-level `linters-settings` key, which golangci-lint v2 ignores — so the intended thresholds (`lll` 88, `funlen` 80/50, `cyclop` 15, `dupl` 100) were not being applied. The canonical file moves them under `linters.settings` and drops `issues.exclude-use-default`. ## Lint fixes (216 findings) - `lll` (96): wrapped lines to the 88-column limit - `noctx` (46): `httptest.NewRequestWithContext` with `t.Context()` throughout the tests - `goconst` (24): shared constants for template/JSON keys in `internal/handlers` and repeated test literals - `gosec` (23): app-page redirects now go through a `redirectToApp` helper that path-escapes the app ID (G710 open redirect); `http.ServeFile` of the internally derived deployment log path annotated like the adjacent `os.Stat` (G703) - `dupl` (22): extracted a generic `findAllByAppID` in `internal/models`, a `deleteAppResource` helper in `internal/handlers`, a shared `parsePush` in `internal/service/webhook`, and table-driven/helper-based dedup in tests - `nolintlint` (5): removed `//nolint:funlen` directives made obsolete by the new limits (plus one more that became obsolete after refactoring) - `nilerr` (3, surfaced during fixing): resource-delete lookups now propagate the find error to the caller No behavior changes intended; all tests pass and `make check` is green. Note: golangci-lint v2.12 warns that `gomodguard` is deprecated in favor of `gomodguard_v2` — a future canonical-config update should address this centrally. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #187 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
135 lines
4.4 KiB
Go
135 lines
4.4 KiB
Go
package server
|
|
|
|
import (
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
chimw "github.com/go-chi/chi/v5/middleware"
|
|
"github.com/prometheus/client_golang/prometheus/promhttp"
|
|
|
|
"sneak.berlin/go/upaas/static"
|
|
)
|
|
|
|
// requestTimeout is the maximum duration for handling a request.
|
|
const requestTimeout = 60 * time.Second
|
|
|
|
// SetupRoutes configures all HTTP routes.
|
|
//
|
|
//nolint:funlen // route configuration is inherently long but straightforward
|
|
func (s *Server) SetupRoutes() {
|
|
s.router = chi.NewRouter()
|
|
|
|
// Global middleware
|
|
s.router.Use(chimw.Recoverer)
|
|
s.router.Use(chimw.RequestID)
|
|
s.router.Use(s.mw.Logging())
|
|
s.router.Use(s.mw.CORS())
|
|
s.router.Use(chimw.Timeout(requestTimeout))
|
|
s.router.Use(s.mw.SetupRequired())
|
|
|
|
// Health check (no auth required)
|
|
s.router.Get("/health", s.handlers.HandleHealthCheck())
|
|
|
|
// Static files
|
|
s.router.Handle("/s/*", http.StripPrefix(
|
|
"/s/",
|
|
http.FileServer(http.FS(static.Static)),
|
|
))
|
|
|
|
// Webhook endpoint (uses secret for auth, not session — no CSRF)
|
|
s.router.Post("/webhook/{secret}", s.handlers.HandleWebhook())
|
|
|
|
// All HTML-serving routes get CSRF protection
|
|
s.router.Group(func(r chi.Router) {
|
|
r.Use(s.mw.CSRF())
|
|
|
|
// Public routes
|
|
r.Get("/login", s.handlers.HandleLoginGET())
|
|
r.With(s.mw.LoginRateLimit()).Post("/login", s.handlers.HandleLoginPOST())
|
|
r.Get("/setup", s.handlers.HandleSetupGET())
|
|
r.Post("/setup", s.handlers.HandleSetupPOST())
|
|
|
|
// Protected routes (require session auth)
|
|
r.Group(func(r chi.Router) {
|
|
r.Use(s.mw.SessionAuth())
|
|
|
|
// Dashboard
|
|
r.Get("/", s.handlers.HandleDashboard())
|
|
|
|
// Logout
|
|
r.Post("/logout", s.handlers.HandleLogout())
|
|
|
|
// App routes
|
|
r.Get("/apps/new", s.handlers.HandleAppNew())
|
|
r.Post("/apps", s.handlers.HandleAppCreate())
|
|
r.Get("/apps/{id}", s.handlers.HandleAppDetail())
|
|
r.Get("/apps/{id}/edit", s.handlers.HandleAppEdit())
|
|
r.Post("/apps/{id}", s.handlers.HandleAppUpdate())
|
|
r.Post("/apps/{id}/delete", s.handlers.HandleAppDelete())
|
|
r.Post("/apps/{id}/deploy", s.handlers.HandleAppDeploy())
|
|
r.Post("/apps/{id}/deployments/cancel", s.handlers.HandleCancelDeploy())
|
|
r.Get("/apps/{id}/deployments", s.handlers.HandleAppDeployments())
|
|
r.Get("/apps/{id}/webhooks", s.handlers.HandleAppWebhookEvents())
|
|
r.Get(
|
|
"/apps/{id}/deployments/{deploymentID}/logs",
|
|
s.handlers.HandleDeploymentLogsAPI(),
|
|
)
|
|
r.Get(
|
|
"/apps/{id}/deployments/{deploymentID}/download",
|
|
s.handlers.HandleDeploymentLogDownload(),
|
|
)
|
|
r.Get("/apps/{id}/logs", s.handlers.HandleAppLogs())
|
|
r.Get("/apps/{id}/container-logs", s.handlers.HandleContainerLogsAPI())
|
|
r.Get("/apps/{id}/status", s.handlers.HandleAppStatusAPI())
|
|
r.Get("/apps/{id}/recent-deployments", s.handlers.HandleRecentDeploymentsAPI())
|
|
r.Post("/apps/{id}/rollback", s.handlers.HandleAppRollback())
|
|
r.Post("/apps/{id}/restart", s.handlers.HandleAppRestart())
|
|
r.Post("/apps/{id}/stop", s.handlers.HandleAppStop())
|
|
r.Post("/apps/{id}/start", s.handlers.HandleAppStart())
|
|
|
|
// Environment variables (monolithic bulk save)
|
|
r.Post("/apps/{id}/env", s.handlers.HandleEnvVarSave())
|
|
|
|
// Labels
|
|
r.Post("/apps/{id}/labels", s.handlers.HandleLabelAdd())
|
|
r.Post("/apps/{id}/labels/{labelID}/edit", s.handlers.HandleLabelEdit())
|
|
r.Post("/apps/{id}/labels/{labelID}/delete", s.handlers.HandleLabelDelete())
|
|
|
|
// Volumes
|
|
r.Post("/apps/{id}/volumes", s.handlers.HandleVolumeAdd())
|
|
r.Post("/apps/{id}/volumes/{volumeID}/edit", s.handlers.HandleVolumeEdit())
|
|
r.Post("/apps/{id}/volumes/{volumeID}/delete", s.handlers.HandleVolumeDelete())
|
|
|
|
// Ports
|
|
r.Post("/apps/{id}/ports", s.handlers.HandlePortAdd())
|
|
r.Post("/apps/{id}/ports/{portID}/delete", s.handlers.HandlePortDelete())
|
|
})
|
|
})
|
|
|
|
// API v1 routes (cookie-based session auth, no CSRF)
|
|
s.router.Route("/api/v1", func(r chi.Router) {
|
|
// Login endpoint is public (returns session cookie)
|
|
r.With(s.mw.LoginRateLimit()).Post("/login", s.handlers.HandleAPILoginPOST())
|
|
|
|
// All other API routes require session auth
|
|
r.Group(func(r chi.Router) {
|
|
r.Use(s.mw.APISessionAuth())
|
|
|
|
r.Get("/whoami", s.handlers.HandleAPIWhoAmI())
|
|
|
|
r.Get("/apps", s.handlers.HandleAPIListApps())
|
|
r.Get("/apps/{id}", s.handlers.HandleAPIGetApp())
|
|
r.Get("/apps/{id}/deployments", s.handlers.HandleAPIListDeployments())
|
|
})
|
|
})
|
|
|
|
// Metrics endpoint (optional, with basic auth)
|
|
if s.params.Config.MetricsUsername != "" {
|
|
s.router.Group(func(r chi.Router) {
|
|
r.Use(s.mw.MetricsAuth())
|
|
r.Get("/metrics", promhttp.Handler().ServeHTTP)
|
|
})
|
|
}
|
|
}
|