feat: edit existing env vars, labels, and volume mounts (closes #67) #77

clawbot · 2026-02-16T09:26:23+01:00

clawbot commented

2026-02-16 09:26:23 +01:00

Summary

Adds inline editing for environment variables, labels, and volume mounts on the app detail page.

Changes

3 new POST endpoints: /apps/{id}/env-vars/{varID}/edit, /apps/{id}/labels/{labelID}/edit, /apps/{id}/volumes/{volumeID}/edit
Inline edit UI: Alpine.js toggle on each row — click Edit to reveal form, Save/Cancel
Path validation: ValidateVolumePath ensures absolute, clean paths for volume edits
Restart warning: Env var edit form shows amber warning about container restart
Tests: TestValidateVolumePath covering empty, relative, unclean, and valid paths

Test Results

✅ make test — all packages pass
✅ golangci-lint run ./... — 0 issues

Closes #67

## Summary Adds inline editing for environment variables, labels, and volume mounts on the app detail page. ## Changes - **3 new POST endpoints**: `/apps/{id}/env-vars/{varID}/edit`, `/apps/{id}/labels/{labelID}/edit`, `/apps/{id}/volumes/{volumeID}/edit` - **Inline edit UI**: Alpine.js toggle on each row — click Edit to reveal form, Save/Cancel - **Path validation**: `ValidateVolumePath` ensures absolute, clean paths for volume edits - **Restart warning**: Env var edit form shows amber warning about container restart - **Tests**: `TestValidateVolumePath` covering empty, relative, unclean, and valid paths ## Test Results ✅ `make test` — all packages pass ✅ `golangci-lint run ./...` — 0 issues Closes #67

sneak was assigned by clawbot

2026-02-16 09:26:24 +01:00

clawbot added 1 commit 2026-02-16 09:26:25 +01:00

feat: edit existing env vars, labels, and volume mounts e9d284698a

Add inline edit functionality for environment variables, labels, and
volume mounts on the app detail page. Each entity row now has an Edit
button that reveals an inline form using Alpine.js.

- POST /apps/{id}/env-vars/{varID}/edit
- POST /apps/{id}/labels/{labelID}/edit
- POST /apps/{id}/volumes/{volumeID}/edit
- Path validation for volume host and container paths
- Warning banner about container restart after env var changes
- Tests for ValidateVolumePath

fixes #67

clawbot commented

2026-02-16 09:26:34 +01:00

CI Results

`make test`

✅ All 10 packages pass

`golangci-lint run ./...`

✅ 0 issues

New test coverage

TestValidateVolumePath: 8 cases (empty, relative, dotdot, trailing slash, double slash, dot, valid absolute, root)

## CI Results ### `make test` ✅ All 10 packages pass ### `golangci-lint run ./...` ✅ 0 issues ### New test coverage - `TestValidateVolumePath`: 8 cases (empty, relative, dotdot, trailing slash, double slash, dot, valid absolute, root)

sneak added 1 commit 2026-02-16 09:28:35 +01:00

Merge branch 'main' into feature/edit-config-entities 0c8dcc2eb1

sneak merged commit b83e68fafd into main

2026-02-16 09:33:47 +01:00

sneak referenced this issue from a commit

2026-02-16 09:33:51 +01:00

Merge pull request 'feat: edit existing env vars, labels, and volume mounts (closes #67)' (#77) from feature/edit-config-entities into main

Sign in to join this conversation.

No reviewers