Bug: deploymentLogWriter.Close() does not wait for final flush to complete #4

New Issue

clawbot · 2026-02-08T21:01:06+01:00

clawbot commented

2026-02-08 21:01:06 +01:00

Description

In internal/service/deploy/deploy.go, deploymentLogWriter.Close() closes the done channel to signal the flush goroutine to stop, but does not wait for the goroutine to finish. The doFlush() in the goroutine writes buffered log data to the database, but the caller may proceed (and mark the deployment as finished or write logs to file) before the final flush completes.

Impact

Build log data may be lost. The last batch of log lines (up to 1 second worth) can be silently dropped.

Location

internal/service/deploy/deploy.go - deploymentLogWriter.Close() and runFlushLoop()

Fix

Add a sync.WaitGroup or second channel to wait for the flush goroutine to complete its final flush before returning from Close().

## Description In `internal/service/deploy/deploy.go`, `deploymentLogWriter.Close()` closes the `done` channel to signal the flush goroutine to stop, but does not wait for the goroutine to finish. The `doFlush()` in the goroutine writes buffered log data to the database, but the caller may proceed (and mark the deployment as finished or write logs to file) before the final flush completes. ## Impact Build log data may be lost. The last batch of log lines (up to 1 second worth) can be silently dropped. ## Location `internal/service/deploy/deploy.go` - `deploymentLogWriter.Close()` and `runFlushLoop()` ## Fix Add a `sync.WaitGroup` or second channel to wait for the flush goroutine to complete its final flush before returning from `Close()`.

clawbot referenced a pull request that will close this issue

2026-02-08 21:05:31 +01:00

Wait for final log flush before closing deploymentLogWriter (closes #4) #9

sneak closed this issue

2026-02-16 06:29:18 +01:00

sneak referenced this issue from a commit

2026-02-16 06:29:20 +01:00

fix: wait for final log flush before closing deploymentLogWriter (closes #4)

sneak referenced this issue from a commit

2026-02-16 06:29:20 +01:00

Merge pull request 'Wait for final log flush before closing deploymentLogWriter (closes #4)' (#9) from clawbot/upaas:fix/issue-4 into main

Sign in to join this conversation.