HIGH: Arbitrary host path mount via volume add — no path validation #20

New Issue

clawbot · 2026-02-16T05:47:10+01:00

clawbot commented

2026-02-16 05:47:10 +01:00

Bug

File: internal/handlers/app.go, HandleVolumeAdd()

Severity: HIGH — Security / Container escape

Description

The HandleVolumeAdd handler accepts a host_path form value and stores it directly without any validation:

hostPath := request.FormValue("host_path")
// ...
volume.HostPath = hostPath

This allows an authenticated user to mount any host path into a container, including:

/etc/shadow — credential theft
/var/run/docker.sock — full Docker control (container escape)
/ — full host filesystem access

Suggested Fix

At minimum:

Validate host paths against an allowlist or a restricted base directory (e.g., must be under /data/upaas/volumes/)
Reject paths containing .. components
Reject known sensitive paths (/var/run/docker.sock, /etc, /proc, etc.)
Consider removing the host path feature entirely and using Docker named volumes instead

## Bug **File:** `internal/handlers/app.go`, `HandleVolumeAdd()` **Severity:** HIGH — Security / Container escape ### Description The `HandleVolumeAdd` handler accepts a `host_path` form value and stores it directly without any validation: ```go hostPath := request.FormValue("host_path") // ... volume.HostPath = hostPath ``` This allows an authenticated user to mount any host path into a container, including: - `/etc/shadow` — credential theft - `/var/run/docker.sock` — full Docker control (container escape) - `/` — full host filesystem access ### Suggested Fix At minimum: 1. Validate host paths against an allowlist or a restricted base directory (e.g., must be under `/data/upaas/volumes/`) 2. Reject paths containing `..` components 3. Reject known sensitive paths (`/var/run/docker.sock`, `/etc`, `/proc`, etc.) 4. Consider removing the host path feature entirely and using Docker named volumes instead

sneak commented

2026-02-16 05:48:18 +01:00

this isn't a bug - this is by design. any admin of upaas is expected to have root on the system on which it's running.

sneak closed this issue

2026-02-16 05:48:18 +01:00

sneak referenced this issue

2026-02-16 07:09:03 +01:00

SECURITY: No validation on volume host paths allows arbitrary filesystem access #35

Sign in to join this conversation.