sneak/upaas
1
0
Fork 1
Code Issues 7 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Split Dockerfile into lint + build stages for faster CI feedback #151

New Issue
Closed
opened 2026-03-01 19:27:09 +01:00 by clawbot · 0 comments
clawbot commented 2026-03-01 19:27:09 +01:00
Collaborator
Copy Link
Copy Source

Per sdlc-manager#6: split the Dockerfile into separate stages so lint failures surface faster and we stop downloading golangci-lint on every build.

Proposed structure:

  1. Lint stage: Use golangci/golangci-lint image (pinned by sha256). Run golangci-lint run and make fmt-check.
  2. Build stage: Use standard golang image (pinned by sha256). Run make test and make build.
  3. Final stage: Unchanged.

Benefits:

  • Lint failures fail in seconds (no golangci-lint download)
  • make fmt-check also fails fast in lint stage
  • Build stage only does tests + compile
  • Eliminates repeated golangci-lint downloads
Per [sdlc-manager#6](https://git.eeqj.de/clawbot/sdlc-manager/issues/6): split the Dockerfile into separate stages so lint failures surface faster and we stop downloading golangci-lint on every build. **Proposed structure:** 1. **Lint stage**: Use `golangci/golangci-lint` image (pinned by sha256). Run `golangci-lint run` and `make fmt-check`. 2. **Build stage**: Use standard `golang` image (pinned by sha256). Run `make test` and `make build`. 3. **Final stage**: Unchanged. Benefits: - Lint failures fail in seconds (no golangci-lint download) - `make fmt-check` also fails fast in lint stage - Build stage only does tests + compile - Eliminates repeated golangci-lint downloads
clawbot self-assigned this 2026-03-01 19:27:19 +01:00
clawbot removed their assignment 2026-03-01 19:33:12 +01:00
sneak closed this issue 2026-03-01 21:19:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#151