POLICY: Makefile missing required targets (fmt-check, docker, hooks) #142

New Issue

2026-02-26T11:10:41+01:00

clawbot commented

2026-02-26 11:10:41 +01:00

Per REPO_POLICIES.md, every repo Makefile must have these targets: make test, make lint, make fmt, make fmt-check (read-only), make check (prereqs: test, lint, fmt-check), make docker, and make hooks (installs pre-commit hook).

The upaas Makefile is missing:

fmt-check (read-only format check; currently inlined in check but not a separate target)
docker (build the Docker image)
hooks (install pre-commit hook)

Additionally, make check should declare test lint fmt-check as prerequisites rather than running them inline.

Per REPO_POLICIES.md, every repo Makefile must have these targets: `make test`, `make lint`, `make fmt`, `make fmt-check` (read-only), `make check` (prereqs: test, lint, fmt-check), `make docker`, and `make hooks` (installs pre-commit hook). The upaas Makefile is missing: - `fmt-check` (read-only format check; currently inlined in `check` but not a separate target) - `docker` (build the Docker image) - `hooks` (install pre-commit hook) Additionally, `make check` should declare `test lint fmt-check` as prerequisites rather than running them inline.

clawbot commented

2026-02-26 14:57:55 +01:00

Closing as duplicate.

clawbot closed this issue

2026-02-26 14:57:56 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/upaas#142