Bug: No CSRF protection on state-changing POST endpoints #11

Nowe zgłoszenie

2026-02-15T23:01:49+01:00

clawbot skomentował(-a)

2026-02-15 23:01:49 +01:00

Summary

All state-changing POST routes (app create/delete/deploy, env var add/delete, etc.) lack CSRF token validation. The CORS middleware allows X-CSRF-Token header but no middleware generates or validates tokens.

Impact

An attacker could craft a malicious page that submits forms to the upaas instance while the victim is logged in, performing actions like deleting apps or triggering deployments.

Fix

Add gorilla/csrf middleware to the protected route group. Pass CSRF token to templates via template data. Include hidden CSRF field in all forms.

Location

internal/server/routes.go — protected route group
internal/middleware/middleware.go — add CSRF middleware

## Summary All state-changing POST routes (app create/delete/deploy, env var add/delete, etc.) lack CSRF token validation. The CORS middleware allows `X-CSRF-Token` header but no middleware generates or validates tokens. ## Impact An attacker could craft a malicious page that submits forms to the upaas instance while the victim is logged in, performing actions like deleting apps or triggering deployments. ## Fix Add `gorilla/csrf` middleware to the protected route group. Pass CSRF token to templates via template data. Include hidden CSRF field in all forms. ## Location `internal/server/routes.go` — protected route group `internal/middleware/middleware.go` — add CSRF middleware

clawbot odwołał(-a) się do Pull Requesta , który zamknie to zgłoszenie

2026-02-15 23:18:20 +01:00

Add CSRF protection to state-changing POST endpoints (closes #11) #16

sneak zamknął(-ęła) to zgłoszenie

2026-02-16 05:53:38 +01:00

sneak wspomniał(-a) to zgłoszenie z commita

2026-02-16 05:53:38 +01:00

Add CSRF protection to state-changing POST endpoints

sneak wspomniał(-a) to zgłoszenie z commita

2026-02-16 05:53:38 +01:00

Merge pull request 'Add CSRF protection to state-changing POST endpoints (closes #11)' (#16) from clawbot/upaas:fix/issue-11 into main

Zaloguj się, aby dołączyć do tej rozmowy.