Compare commits
2 Commits
feature/cu
...
feature/ob
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ef109b9513 | ||
|
|
f558e2cdd8 |
70
README.md
70
README.md
@@ -8,7 +8,7 @@ A simple self-hosted PaaS that auto-deploys Docker containers from Git repositor
|
|||||||
- Per-app SSH keypairs for read-only deploy keys
|
- Per-app SSH keypairs for read-only deploy keys
|
||||||
- Per-app UUID-based webhook URLs for Gitea integration
|
- Per-app UUID-based webhook URLs for Gitea integration
|
||||||
- Branch filtering - only deploy on configured branch changes
|
- Branch filtering - only deploy on configured branch changes
|
||||||
- Environment variables, labels, volume mounts, and custom health checks per app
|
- Environment variables, labels, and volume mounts per app
|
||||||
- Docker builds via socket access
|
- Docker builds via socket access
|
||||||
- Notifications via ntfy and Slack-compatible webhooks
|
- Notifications via ntfy and Slack-compatible webhooks
|
||||||
- Simple server-rendered UI with Tailwind CSS
|
- Simple server-rendered UI with Tailwind CSS
|
||||||
@@ -36,11 +36,13 @@ upaas/
|
|||||||
│ ├── handlers/ # HTTP request handlers
|
│ ├── handlers/ # HTTP request handlers
|
||||||
│ ├── healthcheck/ # Health status service
|
│ ├── healthcheck/ # Health status service
|
||||||
│ ├── logger/ # Structured logging (slog)
|
│ ├── logger/ # Structured logging (slog)
|
||||||
│ ├── middleware/ # HTTP middleware (auth, logging, CORS)
|
│ ├── metrics/ # Prometheus metrics registration
|
||||||
|
│ ├── middleware/ # HTTP middleware (auth, logging, CORS, metrics)
|
||||||
│ ├── models/ # Active Record style database models
|
│ ├── models/ # Active Record style database models
|
||||||
│ ├── server/ # HTTP server and routes
|
│ ├── server/ # HTTP server and routes
|
||||||
│ ├── service/
|
│ ├── service/
|
||||||
│ │ ├── app/ # App management service
|
│ │ ├── app/ # App management service
|
||||||
|
│ │ ├── audit/ # Audit logging service
|
||||||
│ │ ├── auth/ # Authentication service
|
│ │ ├── auth/ # Authentication service
|
||||||
│ │ ├── deploy/ # Deployment orchestration
|
│ │ ├── deploy/ # Deployment orchestration
|
||||||
│ │ ├── notify/ # Notifications (ntfy, Slack)
|
│ │ ├── notify/ # Notifications (ntfy, Slack)
|
||||||
@@ -58,16 +60,18 @@ Uses Uber fx for dependency injection. Components are wired in this order:
|
|||||||
2. `logger` - Structured logging
|
2. `logger` - Structured logging
|
||||||
3. `config` - Configuration loading
|
3. `config` - Configuration loading
|
||||||
4. `database` - SQLite connection + migrations
|
4. `database` - SQLite connection + migrations
|
||||||
5. `healthcheck` - Health status
|
5. `metrics` - Prometheus metrics registration
|
||||||
6. `auth` - Authentication service
|
6. `healthcheck` - Health status
|
||||||
7. `app` - App management
|
7. `auth` - Authentication service
|
||||||
8. `docker` - Docker client
|
8. `app` - App management
|
||||||
9. `notify` - Notification service
|
9. `docker` - Docker client
|
||||||
10. `deploy` - Deployment service
|
10. `notify` - Notification service
|
||||||
11. `webhook` - Webhook processing
|
11. `audit` - Audit logging service
|
||||||
12. `middleware` - HTTP middleware
|
12. `deploy` - Deployment service
|
||||||
13. `handlers` - HTTP handlers
|
13. `webhook` - Webhook processing
|
||||||
14. `server` - HTTP server
|
14. `middleware` - HTTP middleware
|
||||||
|
15. `handlers` - HTTP handlers
|
||||||
|
16. `server` - HTTP server
|
||||||
|
|
||||||
### Request Flow
|
### Request Flow
|
||||||
|
|
||||||
@@ -211,6 +215,48 @@ Example: `HOST_DATA_DIR=/srv/upaas/data docker compose up -d`
|
|||||||
|
|
||||||
Session secrets are automatically generated on first startup and persisted to `$UPAAS_DATA_DIR/session.key`.
|
Session secrets are automatically generated on first startup and persisted to `$UPAAS_DATA_DIR/session.key`.
|
||||||
|
|
||||||
|
## Observability
|
||||||
|
|
||||||
|
### Prometheus Metrics
|
||||||
|
|
||||||
|
All custom metrics are exposed under the `upaas_` namespace at `/metrics`. The
|
||||||
|
endpoint is always available and can be optionally protected with basic auth via
|
||||||
|
`METRICS_USERNAME` and `METRICS_PASSWORD`.
|
||||||
|
|
||||||
|
| Metric | Type | Labels | Description |
|
||||||
|
|--------|------|--------|-------------|
|
||||||
|
| `upaas_deployments_total` | Counter | `app`, `status` | Total deployments (success/failed/cancelled) |
|
||||||
|
| `upaas_deployments_duration_seconds` | Histogram | `app`, `status` | Deployment duration |
|
||||||
|
| `upaas_deployments_in_flight` | Gauge | `app` | Currently running deployments |
|
||||||
|
| `upaas_container_healthy` | Gauge | `app` | Container health (1=healthy, 0=unhealthy) |
|
||||||
|
| `upaas_webhook_events_total` | Counter | `app`, `event_type`, `matched` | Webhook events received |
|
||||||
|
| `upaas_http_requests_total` | Counter | `method`, `status_code` | HTTP requests |
|
||||||
|
| `upaas_http_request_duration_seconds` | Histogram | `method` | HTTP request latency |
|
||||||
|
| `upaas_http_response_size_bytes` | Histogram | `method` | HTTP response sizes |
|
||||||
|
| `upaas_audit_events_total` | Counter | `action` | Audit log events |
|
||||||
|
|
||||||
|
### Audit Log
|
||||||
|
|
||||||
|
All user-facing actions are recorded in an `audit_log` SQLite table with:
|
||||||
|
|
||||||
|
- **Who**: user ID and username
|
||||||
|
- **What**: action type and affected resource (app, deployment, session, etc.)
|
||||||
|
- **Where**: client IP (via X-Real-IP/X-Forwarded-For/RemoteAddr)
|
||||||
|
- **When**: timestamp
|
||||||
|
|
||||||
|
Audited actions include login/logout, app CRUD, deployments, container
|
||||||
|
start/stop/restart, rollbacks, deployment cancellation, and webhook receipt.
|
||||||
|
|
||||||
|
The audit log is available via the API at `GET /api/v1/audit?limit=N` (max 500,
|
||||||
|
default 50).
|
||||||
|
|
||||||
|
### Structured Logging
|
||||||
|
|
||||||
|
All operations use Go's `slog` structured logger. HTTP requests are logged with
|
||||||
|
method, URL, status code, response size, latency, user agent, and client IP.
|
||||||
|
Deployment events are logged with app name, status, and duration. Audit events
|
||||||
|
are also logged to stdout for correlation with external log aggregators.
|
||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
||||||
WTFPL
|
WTFPL
|
||||||
|
|||||||
@@ -11,9 +11,11 @@ import (
|
|||||||
"sneak.berlin/go/upaas/internal/handlers"
|
"sneak.berlin/go/upaas/internal/handlers"
|
||||||
"sneak.berlin/go/upaas/internal/healthcheck"
|
"sneak.berlin/go/upaas/internal/healthcheck"
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
"sneak.berlin/go/upaas/internal/middleware"
|
"sneak.berlin/go/upaas/internal/middleware"
|
||||||
"sneak.berlin/go/upaas/internal/server"
|
"sneak.berlin/go/upaas/internal/server"
|
||||||
"sneak.berlin/go/upaas/internal/service/app"
|
"sneak.berlin/go/upaas/internal/service/app"
|
||||||
|
"sneak.berlin/go/upaas/internal/service/audit"
|
||||||
"sneak.berlin/go/upaas/internal/service/auth"
|
"sneak.berlin/go/upaas/internal/service/auth"
|
||||||
"sneak.berlin/go/upaas/internal/service/deploy"
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
||||||
"sneak.berlin/go/upaas/internal/service/notify"
|
"sneak.berlin/go/upaas/internal/service/notify"
|
||||||
@@ -41,6 +43,7 @@ func main() {
|
|||||||
logger.New,
|
logger.New,
|
||||||
config.New,
|
config.New,
|
||||||
database.New,
|
database.New,
|
||||||
|
metrics.New,
|
||||||
healthcheck.New,
|
healthcheck.New,
|
||||||
auth.New,
|
auth.New,
|
||||||
app.New,
|
app.New,
|
||||||
@@ -48,6 +51,7 @@ func main() {
|
|||||||
notify.New,
|
notify.New,
|
||||||
deploy.New,
|
deploy.New,
|
||||||
webhook.New,
|
webhook.New,
|
||||||
|
audit.New,
|
||||||
middleware.New,
|
middleware.New,
|
||||||
handlers.New,
|
handlers.New,
|
||||||
server.New,
|
server.New,
|
||||||
|
|||||||
16
internal/database/migrations/007_add_audit_log.sql
Normal file
16
internal/database/migrations/007_add_audit_log.sql
Normal file
@@ -0,0 +1,16 @@
|
|||||||
|
-- Audit log table for tracking user actions.
|
||||||
|
CREATE TABLE audit_log (
|
||||||
|
id INTEGER PRIMARY KEY,
|
||||||
|
user_id INTEGER,
|
||||||
|
username TEXT NOT NULL,
|
||||||
|
action TEXT NOT NULL,
|
||||||
|
resource_type TEXT NOT NULL,
|
||||||
|
resource_id TEXT,
|
||||||
|
detail TEXT,
|
||||||
|
remote_ip TEXT,
|
||||||
|
created_at DATETIME DEFAULT CURRENT_TIMESTAMP
|
||||||
|
);
|
||||||
|
|
||||||
|
CREATE INDEX idx_audit_log_created_at ON audit_log(created_at);
|
||||||
|
CREATE INDEX idx_audit_log_action ON audit_log(action);
|
||||||
|
CREATE INDEX idx_audit_log_resource ON audit_log(resource_type, resource_id);
|
||||||
@@ -1,2 +0,0 @@
|
|||||||
-- Add custom health check command per app
|
|
||||||
ALTER TABLE apps ADD COLUMN healthcheck_command TEXT;
|
|
||||||
@@ -13,7 +13,6 @@ import (
|
|||||||
"regexp"
|
"regexp"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
|
||||||
|
|
||||||
dockertypes "github.com/docker/docker/api/types"
|
dockertypes "github.com/docker/docker/api/types"
|
||||||
"github.com/docker/docker/api/types/container"
|
"github.com/docker/docker/api/types/container"
|
||||||
@@ -146,7 +145,6 @@ type CreateContainerOptions struct {
|
|||||||
Volumes []VolumeMount
|
Volumes []VolumeMount
|
||||||
Ports []PortMapping
|
Ports []PortMapping
|
||||||
Network string
|
Network string
|
||||||
HealthcheckCommand string // Custom health check shell command (empty = use image default)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// VolumeMount represents a volume mount.
|
// VolumeMount represents a volume mount.
|
||||||
@@ -187,29 +185,6 @@ func buildPortConfig(ports []PortMapping) (nat.PortSet, nat.PortMap) {
|
|||||||
return exposedPorts, portBindings
|
return exposedPorts, portBindings
|
||||||
}
|
}
|
||||||
|
|
||||||
// healthcheckInterval is the time between health check attempts.
|
|
||||||
const healthcheckInterval = 30 * time.Second
|
|
||||||
|
|
||||||
// healthcheckTimeout is the maximum time a single health check can take.
|
|
||||||
const healthcheckTimeout = 10 * time.Second
|
|
||||||
|
|
||||||
// healthcheckStartPeriod is the grace period before health checks start counting failures.
|
|
||||||
const healthcheckStartPeriod = 15 * time.Second
|
|
||||||
|
|
||||||
// healthcheckRetries is the number of consecutive failures needed to mark unhealthy.
|
|
||||||
const healthcheckRetries = 3
|
|
||||||
|
|
||||||
// buildHealthcheck creates a Docker health check config from a shell command string.
|
|
||||||
func buildHealthcheck(command string) *container.HealthConfig {
|
|
||||||
return &container.HealthConfig{
|
|
||||||
Test: []string{"CMD-SHELL", command},
|
|
||||||
Interval: healthcheckInterval,
|
|
||||||
Timeout: healthcheckTimeout,
|
|
||||||
StartPeriod: healthcheckStartPeriod,
|
|
||||||
Retries: healthcheckRetries,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// CreateContainer creates a new container.
|
// CreateContainer creates a new container.
|
||||||
func (c *Client) CreateContainer(
|
func (c *Client) CreateContainer(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
@@ -243,22 +218,14 @@ func (c *Client) CreateContainer(
|
|||||||
// Convert ports to exposed ports and port bindings
|
// Convert ports to exposed ports and port bindings
|
||||||
exposedPorts, portBindings := buildPortConfig(opts.Ports)
|
exposedPorts, portBindings := buildPortConfig(opts.Ports)
|
||||||
|
|
||||||
// Build container config
|
// Create container
|
||||||
containerConfig := &container.Config{
|
resp, err := c.docker.ContainerCreate(ctx,
|
||||||
|
&container.Config{
|
||||||
Image: opts.Image,
|
Image: opts.Image,
|
||||||
Env: envSlice,
|
Env: envSlice,
|
||||||
Labels: opts.Labels,
|
Labels: opts.Labels,
|
||||||
ExposedPorts: exposedPorts,
|
ExposedPorts: exposedPorts,
|
||||||
}
|
},
|
||||||
|
|
||||||
// Apply custom health check if configured
|
|
||||||
if opts.HealthcheckCommand != "" {
|
|
||||||
containerConfig.Healthcheck = buildHealthcheck(opts.HealthcheckCommand)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Create container
|
|
||||||
resp, err := c.docker.ContainerCreate(ctx,
|
|
||||||
containerConfig,
|
|
||||||
&container.HostConfig{
|
&container.HostConfig{
|
||||||
Mounts: mounts,
|
Mounts: mounts,
|
||||||
PortBindings: portBindings,
|
PortBindings: portBindings,
|
||||||
|
|||||||
@@ -4,7 +4,6 @@ import (
|
|||||||
"errors"
|
"errors"
|
||||||
"log/slog"
|
"log/slog"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestValidBranchRegex(t *testing.T) {
|
func TestValidBranchRegex(t *testing.T) {
|
||||||
@@ -147,52 +146,3 @@ func TestCloneRepoRejectsInjection(t *testing.T) { //nolint:funlen // table-driv
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildHealthcheck(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
t.Run("creates CMD-SHELL health check", func(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
cmd := "curl -f http://localhost:8080/healthz || exit 1"
|
|
||||||
hc := buildHealthcheck(cmd)
|
|
||||||
|
|
||||||
if len(hc.Test) != 2 {
|
|
||||||
t.Fatalf("expected 2 test elements, got %d", len(hc.Test))
|
|
||||||
}
|
|
||||||
|
|
||||||
if hc.Test[0] != "CMD-SHELL" {
|
|
||||||
t.Errorf("expected Test[0]=%q, got %q", "CMD-SHELL", hc.Test[0])
|
|
||||||
}
|
|
||||||
|
|
||||||
if hc.Test[1] != cmd {
|
|
||||||
t.Errorf("expected Test[1]=%q, got %q", cmd, hc.Test[1])
|
|
||||||
}
|
|
||||||
})
|
|
||||||
|
|
||||||
t.Run("sets expected intervals", func(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
hc := buildHealthcheck("true")
|
|
||||||
|
|
||||||
expectedInterval := 30 * time.Second
|
|
||||||
if hc.Interval != expectedInterval {
|
|
||||||
t.Errorf("expected Interval=%v, got %v", expectedInterval, hc.Interval)
|
|
||||||
}
|
|
||||||
|
|
||||||
expectedTimeout := 10 * time.Second
|
|
||||||
if hc.Timeout != expectedTimeout {
|
|
||||||
t.Errorf("expected Timeout=%v, got %v", expectedTimeout, hc.Timeout)
|
|
||||||
}
|
|
||||||
|
|
||||||
expectedStartPeriod := 15 * time.Second
|
|
||||||
if hc.StartPeriod != expectedStartPeriod {
|
|
||||||
t.Errorf("expected StartPeriod=%v, got %v", expectedStartPeriod, hc.StartPeriod)
|
|
||||||
}
|
|
||||||
|
|
||||||
expectedRetries := 3
|
|
||||||
if hc.Retries != expectedRetries {
|
|
||||||
t.Errorf("expected Retries=%d, got %d", expectedRetries, hc.Retries)
|
|
||||||
}
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
package handlers
|
package handlers
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"database/sql"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"net/http"
|
"net/http"
|
||||||
"strconv"
|
"strconv"
|
||||||
@@ -120,6 +121,9 @@ func (h *Handlers) HandleAPILoginPOST() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionLogin,
|
||||||
|
models.AuditResourceSession, "", "api login")
|
||||||
|
|
||||||
h.respondJSON(writer, request, loginResponse{
|
h.respondJSON(writer, request, loginResponse{
|
||||||
UserID: user.ID,
|
UserID: user.ID,
|
||||||
Username: user.Username,
|
Username: user.Username,
|
||||||
@@ -243,3 +247,79 @@ func (h *Handlers) HandleAPIWhoAmI() http.HandlerFunc {
|
|||||||
}, http.StatusOK)
|
}, http.StatusOK)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// auditLogDefaultLimit is the default number of audit entries returned.
|
||||||
|
const auditLogDefaultLimit = 50
|
||||||
|
|
||||||
|
// auditLogMaxLimit is the maximum number of audit entries returned.
|
||||||
|
const auditLogMaxLimit = 500
|
||||||
|
|
||||||
|
// HandleAPIAuditLog returns a handler that lists recent audit log entries.
|
||||||
|
func (h *Handlers) HandleAPIAuditLog() http.HandlerFunc {
|
||||||
|
type auditEntryResponse struct {
|
||||||
|
ID int64 `json:"id"`
|
||||||
|
UserID *int64 `json:"userId,omitempty"`
|
||||||
|
Username string `json:"username"`
|
||||||
|
Action string `json:"action"`
|
||||||
|
ResourceType string `json:"resourceType"`
|
||||||
|
ResourceID string `json:"resourceId,omitempty"`
|
||||||
|
Detail string `json:"detail,omitempty"`
|
||||||
|
RemoteIP string `json:"remoteIp,omitempty"`
|
||||||
|
CreatedAt string `json:"createdAt"`
|
||||||
|
}
|
||||||
|
|
||||||
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
limit := auditLogDefaultLimit
|
||||||
|
|
||||||
|
if limitStr := request.URL.Query().Get("limit"); limitStr != "" {
|
||||||
|
parsed, parseErr := strconv.Atoi(limitStr)
|
||||||
|
if parseErr == nil && parsed > 0 && parsed <= auditLogMaxLimit {
|
||||||
|
limit = parsed
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
entries, err := h.audit.Recent(request.Context(), limit)
|
||||||
|
if err != nil {
|
||||||
|
h.log.Error("failed to fetch audit log", "error", err)
|
||||||
|
h.respondJSON(writer, request,
|
||||||
|
map[string]string{"error": "failed to fetch audit log"},
|
||||||
|
http.StatusInternalServerError)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
result := make([]auditEntryResponse, 0, len(entries))
|
||||||
|
|
||||||
|
for _, e := range entries {
|
||||||
|
entry := auditEntryResponse{
|
||||||
|
ID: e.ID,
|
||||||
|
Username: e.Username,
|
||||||
|
Action: string(e.Action),
|
||||||
|
ResourceType: string(e.ResourceType),
|
||||||
|
CreatedAt: e.CreatedAt.UTC().Format("2006-01-02T15:04:05Z"),
|
||||||
|
}
|
||||||
|
|
||||||
|
if e.UserID.Valid {
|
||||||
|
id := e.UserID.Int64
|
||||||
|
entry.UserID = &id
|
||||||
|
}
|
||||||
|
|
||||||
|
entry.ResourceID = nullStringValue(e.ResourceID)
|
||||||
|
entry.Detail = nullStringValue(e.Detail)
|
||||||
|
entry.RemoteIP = nullStringValue(e.RemoteIP)
|
||||||
|
|
||||||
|
result = append(result, entry)
|
||||||
|
}
|
||||||
|
|
||||||
|
h.respondJSON(writer, request, result, http.StatusOK)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// nullStringValue returns the string value if valid, empty string otherwise.
|
||||||
|
func nullStringValue(ns sql.NullString) string {
|
||||||
|
if ns.Valid {
|
||||||
|
return ns.String
|
||||||
|
}
|
||||||
|
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|||||||
@@ -57,7 +57,6 @@ func (h *Handlers) HandleAppCreate() http.HandlerFunc { //nolint:funlen // valid
|
|||||||
dockerNetwork := request.FormValue("docker_network")
|
dockerNetwork := request.FormValue("docker_network")
|
||||||
ntfyTopic := request.FormValue("ntfy_topic")
|
ntfyTopic := request.FormValue("ntfy_topic")
|
||||||
slackWebhook := request.FormValue("slack_webhook")
|
slackWebhook := request.FormValue("slack_webhook")
|
||||||
healthcheckCommand := request.FormValue("healthcheck_command")
|
|
||||||
|
|
||||||
data := h.addGlobals(map[string]any{
|
data := h.addGlobals(map[string]any{
|
||||||
"Name": name,
|
"Name": name,
|
||||||
@@ -67,7 +66,6 @@ func (h *Handlers) HandleAppCreate() http.HandlerFunc { //nolint:funlen // valid
|
|||||||
"DockerNetwork": dockerNetwork,
|
"DockerNetwork": dockerNetwork,
|
||||||
"NtfyTopic": ntfyTopic,
|
"NtfyTopic": ntfyTopic,
|
||||||
"SlackWebhook": slackWebhook,
|
"SlackWebhook": slackWebhook,
|
||||||
"HealthcheckCommand": healthcheckCommand,
|
|
||||||
}, request)
|
}, request)
|
||||||
|
|
||||||
if name == "" || repoURL == "" {
|
if name == "" || repoURL == "" {
|
||||||
@@ -111,7 +109,6 @@ func (h *Handlers) HandleAppCreate() http.HandlerFunc { //nolint:funlen // valid
|
|||||||
DockerNetwork: dockerNetwork,
|
DockerNetwork: dockerNetwork,
|
||||||
NtfyTopic: ntfyTopic,
|
NtfyTopic: ntfyTopic,
|
||||||
SlackWebhook: slackWebhook,
|
SlackWebhook: slackWebhook,
|
||||||
HealthcheckCommand: healthcheckCommand,
|
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
if createErr != nil {
|
if createErr != nil {
|
||||||
@@ -122,6 +119,9 @@ func (h *Handlers) HandleAppCreate() http.HandlerFunc { //nolint:funlen // valid
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionAppCreate,
|
||||||
|
models.AuditResourceApp, createdApp.ID, "created app: "+createdApp.Name)
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+createdApp.ID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+createdApp.ID, http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -211,11 +211,6 @@ func (h *Handlers) HandleAppEdit() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// optionalNullString returns a valid NullString if the value is non-empty, or an empty NullString.
|
|
||||||
func optionalNullString(value string) sql.NullString {
|
|
||||||
return sql.NullString{String: value, Valid: value != ""}
|
|
||||||
}
|
|
||||||
|
|
||||||
// HandleAppUpdate handles app updates.
|
// HandleAppUpdate handles app updates.
|
||||||
func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // validation adds necessary length
|
func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // validation adds necessary length
|
||||||
tmpl := templates.GetParsed()
|
tmpl := templates.GetParsed()
|
||||||
@@ -265,10 +260,24 @@ func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // valid
|
|||||||
application.RepoURL = request.FormValue("repo_url")
|
application.RepoURL = request.FormValue("repo_url")
|
||||||
application.Branch = request.FormValue("branch")
|
application.Branch = request.FormValue("branch")
|
||||||
application.DockerfilePath = request.FormValue("dockerfile_path")
|
application.DockerfilePath = request.FormValue("dockerfile_path")
|
||||||
application.DockerNetwork = optionalNullString(request.FormValue("docker_network"))
|
|
||||||
application.NtfyTopic = optionalNullString(request.FormValue("ntfy_topic"))
|
if network := request.FormValue("docker_network"); network != "" {
|
||||||
application.SlackWebhook = optionalNullString(request.FormValue("slack_webhook"))
|
application.DockerNetwork = sql.NullString{String: network, Valid: true}
|
||||||
application.HealthcheckCommand = optionalNullString(request.FormValue("healthcheck_command"))
|
} else {
|
||||||
|
application.DockerNetwork = sql.NullString{}
|
||||||
|
}
|
||||||
|
|
||||||
|
if ntfy := request.FormValue("ntfy_topic"); ntfy != "" {
|
||||||
|
application.NtfyTopic = sql.NullString{String: ntfy, Valid: true}
|
||||||
|
} else {
|
||||||
|
application.NtfyTopic = sql.NullString{}
|
||||||
|
}
|
||||||
|
|
||||||
|
if slack := request.FormValue("slack_webhook"); slack != "" {
|
||||||
|
application.SlackWebhook = sql.NullString{String: slack, Valid: true}
|
||||||
|
} else {
|
||||||
|
application.SlackWebhook = sql.NullString{}
|
||||||
|
}
|
||||||
|
|
||||||
saveErr := application.Save(request.Context())
|
saveErr := application.Save(request.Context())
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
@@ -283,6 +292,9 @@ func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // valid
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionAppUpdate,
|
||||||
|
models.AuditResourceApp, application.ID, "updated app: "+application.Name)
|
||||||
|
|
||||||
redirectURL := "/apps/" + application.ID + "?success=updated"
|
redirectURL := "/apps/" + application.ID + "?success=updated"
|
||||||
http.Redirect(writer, request, redirectURL, http.StatusSeeOther)
|
http.Redirect(writer, request, redirectURL, http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
@@ -338,6 +350,9 @@ func (h *Handlers) HandleAppDelete() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionAppDelete,
|
||||||
|
models.AuditResourceApp, appID, "deleted app: "+application.Name)
|
||||||
|
|
||||||
http.Redirect(writer, request, "/", http.StatusSeeOther)
|
http.Redirect(writer, request, "/", http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -354,6 +369,9 @@ func (h *Handlers) HandleAppDeploy() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionAppDeploy,
|
||||||
|
models.AuditResourceApp, application.ID, "manual deploy: "+application.Name)
|
||||||
|
|
||||||
// Trigger deployment in background with a detached context
|
// Trigger deployment in background with a detached context
|
||||||
// so the deployment continues even if the HTTP request is cancelled
|
// so the deployment continues even if the HTTP request is cancelled
|
||||||
deployCtx := context.WithoutCancel(request.Context())
|
deployCtx := context.WithoutCancel(request.Context())
|
||||||
@@ -393,6 +411,8 @@ func (h *Handlers) HandleCancelDeploy() http.HandlerFunc {
|
|||||||
cancelled := h.deploy.CancelDeploy(application.ID)
|
cancelled := h.deploy.CancelDeploy(application.ID)
|
||||||
if cancelled {
|
if cancelled {
|
||||||
h.log.Info("deployment cancelled by user", "app", application.Name)
|
h.log.Info("deployment cancelled by user", "app", application.Name)
|
||||||
|
h.auditLog(request, models.AuditActionDeployCancel,
|
||||||
|
models.AuditResourceDeployment, application.ID, "cancelled deploy: "+application.Name)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(
|
http.Redirect(
|
||||||
@@ -424,6 +444,9 @@ func (h *Handlers) HandleAppRollback() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionAppRollback,
|
||||||
|
models.AuditResourceApp, application.ID, "rolled back: "+application.Name)
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+application.ID+"?success=rolledback", http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+application.ID+"?success=rolledback", http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -828,11 +851,29 @@ func (h *Handlers) handleContainerAction(
|
|||||||
} else {
|
} else {
|
||||||
h.log.Info("container action completed",
|
h.log.Info("container action completed",
|
||||||
"action", action, "app", application.Name, "container", containerID)
|
"action", action, "app", application.Name, "container", containerID)
|
||||||
|
|
||||||
|
auditAction := containerActionToAuditAction(action)
|
||||||
|
h.auditLog(request, auditAction,
|
||||||
|
models.AuditResourceApp, appID, string(action)+" container: "+application.Name)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// containerActionToAuditAction maps container actions to audit actions.
|
||||||
|
func containerActionToAuditAction(action containerAction) models.AuditAction {
|
||||||
|
switch action {
|
||||||
|
case actionRestart:
|
||||||
|
return models.AuditActionAppRestart
|
||||||
|
case actionStop:
|
||||||
|
return models.AuditActionAppStop
|
||||||
|
case actionStart:
|
||||||
|
return models.AuditActionAppStart
|
||||||
|
default:
|
||||||
|
return models.AuditAction("app." + string(action))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// HandleAppRestart handles restarting an app's container.
|
// HandleAppRestart handles restarting an app's container.
|
||||||
func (h *Handlers) HandleAppRestart() http.HandlerFunc {
|
func (h *Handlers) HandleAppRestart() http.HandlerFunc {
|
||||||
return func(writer http.ResponseWriter, request *http.Request) {
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
@@ -982,6 +1023,10 @@ func (h *Handlers) HandleEnvVarSave() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionEnvVarSave,
|
||||||
|
models.AuditResourceEnvVar, application.ID,
|
||||||
|
fmt.Sprintf("saved %d env vars", len(modelPairs)))
|
||||||
|
|
||||||
h.respondJSON(writer, request, map[string]bool{"ok": true}, http.StatusOK)
|
h.respondJSON(writer, request, map[string]bool{"ok": true}, http.StatusOK)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -998,7 +1043,13 @@ func (h *Handlers) HandleLabelAdd() http.HandlerFunc {
|
|||||||
label.Key = key
|
label.Key = key
|
||||||
label.Value = value
|
label.Value = value
|
||||||
|
|
||||||
return label.Save(ctx)
|
err := label.Save(ctx)
|
||||||
|
if err == nil {
|
||||||
|
h.auditLog(request, models.AuditActionLabelAdd,
|
||||||
|
models.AuditResourceLabel, application.ID, "added label: "+key)
|
||||||
|
}
|
||||||
|
|
||||||
|
return err
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
@@ -1027,6 +1078,9 @@ func (h *Handlers) HandleLabelDelete() http.HandlerFunc {
|
|||||||
deleteErr := label.Delete(request.Context())
|
deleteErr := label.Delete(request.Context())
|
||||||
if deleteErr != nil {
|
if deleteErr != nil {
|
||||||
h.log.Error("failed to delete label", "error", deleteErr)
|
h.log.Error("failed to delete label", "error", deleteErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionLabelDelete,
|
||||||
|
models.AuditResourceLabel, appID, "deleted label: "+label.Key)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
@@ -1084,6 +1138,10 @@ func (h *Handlers) HandleVolumeAdd() http.HandlerFunc {
|
|||||||
saveErr := volume.Save(request.Context())
|
saveErr := volume.Save(request.Context())
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
h.log.Error("failed to add volume", "error", saveErr)
|
h.log.Error("failed to add volume", "error", saveErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionVolumeAdd,
|
||||||
|
models.AuditResourceVolume, application.ID,
|
||||||
|
"added volume: "+hostPath+":"+containerPath)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+application.ID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+application.ID, http.StatusSeeOther)
|
||||||
@@ -1113,6 +1171,10 @@ func (h *Handlers) HandleVolumeDelete() http.HandlerFunc {
|
|||||||
deleteErr := volume.Delete(request.Context())
|
deleteErr := volume.Delete(request.Context())
|
||||||
if deleteErr != nil {
|
if deleteErr != nil {
|
||||||
h.log.Error("failed to delete volume", "error", deleteErr)
|
h.log.Error("failed to delete volume", "error", deleteErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionVolumeDelete,
|
||||||
|
models.AuditResourceVolume, appID,
|
||||||
|
"deleted volume: "+volume.HostPath+":"+volume.ContainerPath)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
@@ -1162,6 +1224,10 @@ func (h *Handlers) HandlePortAdd() http.HandlerFunc {
|
|||||||
saveErr := port.Save(request.Context())
|
saveErr := port.Save(request.Context())
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
h.log.Error("failed to save port", "error", saveErr)
|
h.log.Error("failed to save port", "error", saveErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionPortAdd,
|
||||||
|
models.AuditResourcePort, application.ID,
|
||||||
|
fmt.Sprintf("added port: %d:%d/%s", hostPort, containerPort, protocol))
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+application.ID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+application.ID, http.StatusSeeOther)
|
||||||
@@ -1208,6 +1274,10 @@ func (h *Handlers) HandlePortDelete() http.HandlerFunc {
|
|||||||
deleteErr := port.Delete(request.Context())
|
deleteErr := port.Delete(request.Context())
|
||||||
if deleteErr != nil {
|
if deleteErr != nil {
|
||||||
h.log.Error("failed to delete port", "error", deleteErr)
|
h.log.Error("failed to delete port", "error", deleteErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionPortDelete,
|
||||||
|
models.AuditResourcePort, appID,
|
||||||
|
fmt.Sprintf("deleted port: %d:%d/%s", port.HostPort, port.ContainerPort, port.Protocol))
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
@@ -1283,6 +1353,9 @@ func (h *Handlers) HandleLabelEdit() http.HandlerFunc {
|
|||||||
saveErr := label.Save(request.Context())
|
saveErr := label.Save(request.Context())
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
h.log.Error("failed to update label", "error", saveErr)
|
h.log.Error("failed to update label", "error", saveErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionLabelEdit,
|
||||||
|
models.AuditResourceLabel, appID, "edited label: "+key)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
@@ -1341,6 +1414,10 @@ func (h *Handlers) HandleVolumeEdit() http.HandlerFunc {
|
|||||||
saveErr := volume.Save(request.Context())
|
saveErr := volume.Save(request.Context())
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
h.log.Error("failed to update volume", "error", saveErr)
|
h.log.Error("failed to update volume", "error", saveErr)
|
||||||
|
} else {
|
||||||
|
h.auditLog(request, models.AuditActionVolumeEdit,
|
||||||
|
models.AuditResourceVolume, appID,
|
||||||
|
"edited volume: "+hostPath+":"+containerPath)
|
||||||
}
|
}
|
||||||
|
|
||||||
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package handlers
|
|||||||
import (
|
import (
|
||||||
"net/http"
|
"net/http"
|
||||||
|
|
||||||
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
"sneak.berlin/go/upaas/templates"
|
"sneak.berlin/go/upaas/templates"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -61,6 +62,9 @@ func (h *Handlers) HandleLoginPOST() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionLogin,
|
||||||
|
models.AuditResourceSession, "", "user logged in")
|
||||||
|
|
||||||
http.Redirect(writer, request, "/", http.StatusSeeOther)
|
http.Redirect(writer, request, "/", http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -68,6 +72,9 @@ func (h *Handlers) HandleLoginPOST() http.HandlerFunc {
|
|||||||
// HandleLogout handles logout requests.
|
// HandleLogout handles logout requests.
|
||||||
func (h *Handlers) HandleLogout() http.HandlerFunc {
|
func (h *Handlers) HandleLogout() http.HandlerFunc {
|
||||||
return func(writer http.ResponseWriter, request *http.Request) {
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
h.auditLog(request, models.AuditActionLogout,
|
||||||
|
models.AuditResourceSession, "", "user logged out")
|
||||||
|
|
||||||
destroyErr := h.auth.DestroySession(writer, request)
|
destroyErr := h.auth.DestroySession(writer, request)
|
||||||
if destroyErr != nil {
|
if destroyErr != nil {
|
||||||
h.log.Error("failed to destroy session", "error", destroyErr)
|
h.log.Error("failed to destroy session", "error", destroyErr)
|
||||||
|
|||||||
@@ -15,7 +15,9 @@ import (
|
|||||||
"sneak.berlin/go/upaas/internal/globals"
|
"sneak.berlin/go/upaas/internal/globals"
|
||||||
"sneak.berlin/go/upaas/internal/healthcheck"
|
"sneak.berlin/go/upaas/internal/healthcheck"
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
"sneak.berlin/go/upaas/internal/service/app"
|
"sneak.berlin/go/upaas/internal/service/app"
|
||||||
|
"sneak.berlin/go/upaas/internal/service/audit"
|
||||||
"sneak.berlin/go/upaas/internal/service/auth"
|
"sneak.berlin/go/upaas/internal/service/auth"
|
||||||
"sneak.berlin/go/upaas/internal/service/deploy"
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
||||||
"sneak.berlin/go/upaas/internal/service/webhook"
|
"sneak.berlin/go/upaas/internal/service/webhook"
|
||||||
@@ -35,6 +37,7 @@ type Params struct {
|
|||||||
Deploy *deploy.Service
|
Deploy *deploy.Service
|
||||||
Webhook *webhook.Service
|
Webhook *webhook.Service
|
||||||
Docker *docker.Client
|
Docker *docker.Client
|
||||||
|
Audit *audit.Service
|
||||||
}
|
}
|
||||||
|
|
||||||
// Handlers provides HTTP request handlers.
|
// Handlers provides HTTP request handlers.
|
||||||
@@ -48,6 +51,7 @@ type Handlers struct {
|
|||||||
deploy *deploy.Service
|
deploy *deploy.Service
|
||||||
webhook *webhook.Service
|
webhook *webhook.Service
|
||||||
docker *docker.Client
|
docker *docker.Client
|
||||||
|
audit *audit.Service
|
||||||
globals *globals.Globals
|
globals *globals.Globals
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -63,10 +67,48 @@ func New(_ fx.Lifecycle, params Params) (*Handlers, error) {
|
|||||||
deploy: params.Deploy,
|
deploy: params.Deploy,
|
||||||
webhook: params.Webhook,
|
webhook: params.Webhook,
|
||||||
docker: params.Docker,
|
docker: params.Docker,
|
||||||
|
audit: params.Audit,
|
||||||
globals: params.Globals,
|
globals: params.Globals,
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// currentUser returns the currently authenticated user, or nil if not authenticated.
|
||||||
|
func (h *Handlers) currentUser(request *http.Request) *models.User {
|
||||||
|
user, err := h.auth.GetCurrentUser(request.Context(), request)
|
||||||
|
if err != nil || user == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
return user
|
||||||
|
}
|
||||||
|
|
||||||
|
// auditLog records an audit entry for the current request.
|
||||||
|
func (h *Handlers) auditLog(
|
||||||
|
request *http.Request,
|
||||||
|
action models.AuditAction,
|
||||||
|
resourceType models.AuditResourceType,
|
||||||
|
resourceID string,
|
||||||
|
detail string,
|
||||||
|
) {
|
||||||
|
user := h.currentUser(request)
|
||||||
|
|
||||||
|
entry := audit.LogEntry{
|
||||||
|
Action: action,
|
||||||
|
ResourceType: resourceType,
|
||||||
|
ResourceID: resourceID,
|
||||||
|
Detail: detail,
|
||||||
|
}
|
||||||
|
|
||||||
|
if user != nil {
|
||||||
|
entry.UserID = user.ID
|
||||||
|
entry.Username = user.Username
|
||||||
|
} else {
|
||||||
|
entry.Username = "anonymous"
|
||||||
|
}
|
||||||
|
|
||||||
|
h.audit.LogFromRequest(request.Context(), request, entry)
|
||||||
|
}
|
||||||
|
|
||||||
// addGlobals adds version info and CSRF token to template data map.
|
// addGlobals adds version info and CSRF token to template data map.
|
||||||
func (h *Handlers) addGlobals(
|
func (h *Handlers) addGlobals(
|
||||||
data map[string]any,
|
data map[string]any,
|
||||||
|
|||||||
@@ -11,6 +11,7 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/go-chi/chi/v5"
|
"github.com/go-chi/chi/v5"
|
||||||
|
"github.com/prometheus/client_golang/prometheus"
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/stretchr/testify/assert"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
"go.uber.org/fx"
|
"go.uber.org/fx"
|
||||||
@@ -24,8 +25,10 @@ import (
|
|||||||
"sneak.berlin/go/upaas/internal/handlers"
|
"sneak.berlin/go/upaas/internal/handlers"
|
||||||
"sneak.berlin/go/upaas/internal/healthcheck"
|
"sneak.berlin/go/upaas/internal/healthcheck"
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
"sneak.berlin/go/upaas/internal/middleware"
|
"sneak.berlin/go/upaas/internal/middleware"
|
||||||
"sneak.berlin/go/upaas/internal/service/app"
|
"sneak.berlin/go/upaas/internal/service/app"
|
||||||
|
"sneak.berlin/go/upaas/internal/service/audit"
|
||||||
"sneak.berlin/go/upaas/internal/service/auth"
|
"sneak.berlin/go/upaas/internal/service/auth"
|
||||||
"sneak.berlin/go/upaas/internal/service/deploy"
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
||||||
"sneak.berlin/go/upaas/internal/service/notify"
|
"sneak.berlin/go/upaas/internal/service/notify"
|
||||||
@@ -92,7 +95,8 @@ func createAppServices(
|
|||||||
logInstance *logger.Logger,
|
logInstance *logger.Logger,
|
||||||
dbInstance *database.Database,
|
dbInstance *database.Database,
|
||||||
cfg *config.Config,
|
cfg *config.Config,
|
||||||
) (*auth.Service, *app.Service, *deploy.Service, *webhook.Service, *docker.Client) {
|
metricsInstance *metrics.Metrics,
|
||||||
|
) (*auth.Service, *app.Service, *deploy.Service, *webhook.Service, *docker.Client, *audit.Service) {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
|
|
||||||
authSvc, authErr := auth.New(fx.Lifecycle(nil), auth.ServiceParams{
|
authSvc, authErr := auth.New(fx.Lifecycle(nil), auth.ServiceParams{
|
||||||
@@ -125,6 +129,7 @@ func createAppServices(
|
|||||||
Database: dbInstance,
|
Database: dbInstance,
|
||||||
Docker: dockerClient,
|
Docker: dockerClient,
|
||||||
Notify: notifySvc,
|
Notify: notifySvc,
|
||||||
|
Metrics: metricsInstance,
|
||||||
})
|
})
|
||||||
require.NoError(t, deployErr)
|
require.NoError(t, deployErr)
|
||||||
|
|
||||||
@@ -132,10 +137,18 @@ func createAppServices(
|
|||||||
Logger: logInstance,
|
Logger: logInstance,
|
||||||
Database: dbInstance,
|
Database: dbInstance,
|
||||||
Deploy: deploySvc,
|
Deploy: deploySvc,
|
||||||
|
Metrics: metricsInstance,
|
||||||
})
|
})
|
||||||
require.NoError(t, webhookErr)
|
require.NoError(t, webhookErr)
|
||||||
|
|
||||||
return authSvc, appSvc, deploySvc, webhookSvc, dockerClient
|
auditSvc, auditErr := audit.New(fx.Lifecycle(nil), audit.ServiceParams{
|
||||||
|
Logger: logInstance,
|
||||||
|
Database: dbInstance,
|
||||||
|
Metrics: metricsInstance,
|
||||||
|
})
|
||||||
|
require.NoError(t, auditErr)
|
||||||
|
|
||||||
|
return authSvc, appSvc, deploySvc, webhookSvc, dockerClient, auditSvc
|
||||||
}
|
}
|
||||||
|
|
||||||
func setupTestHandlers(t *testing.T) *testContext {
|
func setupTestHandlers(t *testing.T) *testContext {
|
||||||
@@ -145,11 +158,14 @@ func setupTestHandlers(t *testing.T) *testContext {
|
|||||||
|
|
||||||
globalInstance, logInstance, dbInstance, hcInstance := createCoreServices(t, cfg)
|
globalInstance, logInstance, dbInstance, hcInstance := createCoreServices(t, cfg)
|
||||||
|
|
||||||
authSvc, appSvc, deploySvc, webhookSvc, dockerClient := createAppServices(
|
metricsInstance := metrics.NewForTest(prometheus.NewRegistry())
|
||||||
|
|
||||||
|
authSvc, appSvc, deploySvc, webhookSvc, dockerClient, auditSvc := createAppServices(
|
||||||
t,
|
t,
|
||||||
logInstance,
|
logInstance,
|
||||||
dbInstance,
|
dbInstance,
|
||||||
cfg,
|
cfg,
|
||||||
|
metricsInstance,
|
||||||
)
|
)
|
||||||
|
|
||||||
handlersInstance, handlerErr := handlers.New(
|
handlersInstance, handlerErr := handlers.New(
|
||||||
@@ -164,6 +180,7 @@ func setupTestHandlers(t *testing.T) *testContext {
|
|||||||
Deploy: deploySvc,
|
Deploy: deploySvc,
|
||||||
Webhook: webhookSvc,
|
Webhook: webhookSvc,
|
||||||
Docker: dockerClient,
|
Docker: dockerClient,
|
||||||
|
Audit: auditSvc,
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
require.NoError(t, handlerErr)
|
require.NoError(t, handlerErr)
|
||||||
@@ -173,6 +190,7 @@ func setupTestHandlers(t *testing.T) *testContext {
|
|||||||
Globals: globalInstance,
|
Globals: globalInstance,
|
||||||
Config: cfg,
|
Config: cfg,
|
||||||
Auth: authSvc,
|
Auth: authSvc,
|
||||||
|
Metrics: metricsInstance,
|
||||||
})
|
})
|
||||||
require.NoError(t, mwErr)
|
require.NoError(t, mwErr)
|
||||||
|
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package handlers
|
|||||||
import (
|
import (
|
||||||
"net/http"
|
"net/http"
|
||||||
|
|
||||||
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
"sneak.berlin/go/upaas/templates"
|
"sneak.berlin/go/upaas/templates"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -111,6 +112,9 @@ func (h *Handlers) HandleSetupPOST() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
h.auditLog(request, models.AuditActionSetup,
|
||||||
|
models.AuditResourceUser, "", "initial setup completed")
|
||||||
|
|
||||||
http.Redirect(writer, request, "/", http.StatusSeeOther)
|
http.Redirect(writer, request, "/", http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -7,13 +7,14 @@ import (
|
|||||||
"github.com/go-chi/chi/v5"
|
"github.com/go-chi/chi/v5"
|
||||||
|
|
||||||
"sneak.berlin/go/upaas/internal/models"
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
|
"sneak.berlin/go/upaas/internal/service/audit"
|
||||||
)
|
)
|
||||||
|
|
||||||
// maxWebhookBodySize is the maximum allowed size of a webhook request body (1MB).
|
// maxWebhookBodySize is the maximum allowed size of a webhook request body (1MB).
|
||||||
const maxWebhookBodySize = 1 << 20
|
const maxWebhookBodySize = 1 << 20
|
||||||
|
|
||||||
// HandleWebhook handles incoming Gitea webhooks.
|
// HandleWebhook handles incoming Gitea webhooks.
|
||||||
func (h *Handlers) HandleWebhook() http.HandlerFunc {
|
func (h *Handlers) HandleWebhook() http.HandlerFunc { //nolint:funlen // audit logging adds necessary length
|
||||||
return func(writer http.ResponseWriter, request *http.Request) {
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
secret := chi.URLParam(request, "secret")
|
secret := chi.URLParam(request, "secret")
|
||||||
if secret == "" {
|
if secret == "" {
|
||||||
@@ -56,6 +57,15 @@ func (h *Handlers) HandleWebhook() http.HandlerFunc {
|
|||||||
eventType = "push"
|
eventType = "push"
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Log webhook receipt
|
||||||
|
h.audit.LogFromRequest(request.Context(), request, audit.LogEntry{
|
||||||
|
Username: "webhook",
|
||||||
|
Action: models.AuditActionWebhookReceive,
|
||||||
|
ResourceType: models.AuditResourceWebhook,
|
||||||
|
ResourceID: application.ID,
|
||||||
|
Detail: "webhook from app: " + application.Name + ", event: " + eventType,
|
||||||
|
})
|
||||||
|
|
||||||
// Process webhook
|
// Process webhook
|
||||||
webhookErr := h.webhook.HandleWebhook(
|
webhookErr := h.webhook.HandleWebhook(
|
||||||
request.Context(),
|
request.Context(),
|
||||||
|
|||||||
148
internal/metrics/metrics.go
Normal file
148
internal/metrics/metrics.go
Normal file
@@ -0,0 +1,148 @@
|
|||||||
|
// Package metrics provides Prometheus metrics for upaas.
|
||||||
|
//
|
||||||
|
//nolint:revive // "metrics" matches the domain; runtime/metrics is rarely imported directly
|
||||||
|
package metrics
|
||||||
|
|
||||||
|
import (
|
||||||
|
"github.com/prometheus/client_golang/prometheus"
|
||||||
|
"github.com/prometheus/client_golang/prometheus/promauto"
|
||||||
|
"go.uber.org/fx"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Params contains dependencies for Metrics.
|
||||||
|
type Params struct {
|
||||||
|
fx.In
|
||||||
|
}
|
||||||
|
|
||||||
|
// Metrics holds all Prometheus metrics for the application.
|
||||||
|
type Metrics struct {
|
||||||
|
// Deployment metrics.
|
||||||
|
DeploymentsTotal *prometheus.CounterVec
|
||||||
|
DeploymentDuration *prometheus.HistogramVec
|
||||||
|
DeploymentsInFlight *prometheus.GaugeVec
|
||||||
|
|
||||||
|
// Container health metrics.
|
||||||
|
ContainerHealthy *prometheus.GaugeVec
|
||||||
|
|
||||||
|
// Webhook metrics.
|
||||||
|
WebhookEventsTotal *prometheus.CounterVec
|
||||||
|
|
||||||
|
// HTTP request metrics.
|
||||||
|
HTTPRequestsTotal *prometheus.CounterVec
|
||||||
|
HTTPRequestDuration *prometheus.HistogramVec
|
||||||
|
HTTPResponseSizeBytes *prometheus.HistogramVec
|
||||||
|
|
||||||
|
// Audit log metrics.
|
||||||
|
AuditEventsTotal *prometheus.CounterVec
|
||||||
|
}
|
||||||
|
|
||||||
|
// New creates a new Metrics instance with all Prometheus metrics registered
|
||||||
|
// in the default Prometheus registry.
|
||||||
|
func New(_ fx.Lifecycle, _ Params) (*Metrics, error) {
|
||||||
|
return newMetrics(promauto.With(prometheus.DefaultRegisterer)), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewForTest creates a Metrics instance with a custom registry for test isolation.
|
||||||
|
func NewForTest(reg prometheus.Registerer) *Metrics {
|
||||||
|
return newMetrics(promauto.With(reg))
|
||||||
|
}
|
||||||
|
|
||||||
|
// newMetrics creates a Metrics instance using the given factory.
|
||||||
|
func newMetrics(factory promauto.Factory) *Metrics {
|
||||||
|
return &Metrics{
|
||||||
|
DeploymentsTotal: newDeploymentsTotal(factory),
|
||||||
|
DeploymentDuration: newDeploymentDuration(factory),
|
||||||
|
DeploymentsInFlight: newDeploymentsInFlight(factory),
|
||||||
|
ContainerHealthy: newContainerHealthy(factory),
|
||||||
|
WebhookEventsTotal: newWebhookEventsTotal(factory),
|
||||||
|
HTTPRequestsTotal: newHTTPRequestsTotal(factory),
|
||||||
|
HTTPRequestDuration: newHTTPRequestDuration(factory),
|
||||||
|
HTTPResponseSizeBytes: newHTTPResponseSizeBytes(factory),
|
||||||
|
AuditEventsTotal: newAuditEventsTotal(factory),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func newDeploymentsTotal(f promauto.Factory) *prometheus.CounterVec {
|
||||||
|
return f.NewCounterVec(prometheus.CounterOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "deployments",
|
||||||
|
Name: "total",
|
||||||
|
Help: "Total number of deployments by app and status.",
|
||||||
|
}, []string{"app", "status"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newDeploymentDuration(f promauto.Factory) *prometheus.HistogramVec {
|
||||||
|
return f.NewHistogramVec(prometheus.HistogramOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "deployments",
|
||||||
|
Name: "duration_seconds",
|
||||||
|
Help: "Duration of deployments in seconds by app and status.",
|
||||||
|
Buckets: []float64{10, 30, 60, 120, 300, 600, 1800},
|
||||||
|
}, []string{"app", "status"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newDeploymentsInFlight(f promauto.Factory) *prometheus.GaugeVec {
|
||||||
|
return f.NewGaugeVec(prometheus.GaugeOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "deployments",
|
||||||
|
Name: "in_flight",
|
||||||
|
Help: "Number of deployments currently in progress by app.",
|
||||||
|
}, []string{"app"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newContainerHealthy(f promauto.Factory) *prometheus.GaugeVec {
|
||||||
|
return f.NewGaugeVec(prometheus.GaugeOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "container",
|
||||||
|
Name: "healthy",
|
||||||
|
Help: "Whether the app container is healthy (1) or unhealthy (0).",
|
||||||
|
}, []string{"app"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newWebhookEventsTotal(f promauto.Factory) *prometheus.CounterVec {
|
||||||
|
return f.NewCounterVec(prometheus.CounterOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "webhook",
|
||||||
|
Name: "events_total",
|
||||||
|
Help: "Total number of webhook events by app, event type, and matched status.",
|
||||||
|
}, []string{"app", "event_type", "matched"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newHTTPRequestsTotal(f promauto.Factory) *prometheus.CounterVec {
|
||||||
|
return f.NewCounterVec(prometheus.CounterOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "http",
|
||||||
|
Name: "requests_total",
|
||||||
|
Help: "Total number of HTTP requests by method and status code.",
|
||||||
|
}, []string{"method", "status_code"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newHTTPRequestDuration(f promauto.Factory) *prometheus.HistogramVec {
|
||||||
|
return f.NewHistogramVec(prometheus.HistogramOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "http",
|
||||||
|
Name: "request_duration_seconds",
|
||||||
|
Help: "Duration of HTTP requests in seconds by method.",
|
||||||
|
Buckets: prometheus.DefBuckets,
|
||||||
|
}, []string{"method"})
|
||||||
|
}
|
||||||
|
|
||||||
|
//nolint:mnd // bucket boundaries are domain-specific constants
|
||||||
|
func newHTTPResponseSizeBytes(f promauto.Factory) *prometheus.HistogramVec {
|
||||||
|
return f.NewHistogramVec(prometheus.HistogramOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "http",
|
||||||
|
Name: "response_size_bytes",
|
||||||
|
Help: "Size of HTTP responses in bytes by method.",
|
||||||
|
Buckets: prometheus.ExponentialBuckets(100, 10, 7),
|
||||||
|
}, []string{"method"})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newAuditEventsTotal(f promauto.Factory) *prometheus.CounterVec {
|
||||||
|
return f.NewCounterVec(prometheus.CounterOpts{
|
||||||
|
Namespace: "upaas",
|
||||||
|
Subsystem: "audit",
|
||||||
|
Name: "events_total",
|
||||||
|
Help: "Total number of audit log events by action.",
|
||||||
|
}, []string{"action"})
|
||||||
|
}
|
||||||
158
internal/metrics/metrics_test.go
Normal file
158
internal/metrics/metrics_test.go
Normal file
@@ -0,0 +1,158 @@
|
|||||||
|
package metrics_test
|
||||||
|
|
||||||
|
import (
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/prometheus/client_golang/prometheus"
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
"github.com/stretchr/testify/require"
|
||||||
|
"go.uber.org/fx"
|
||||||
|
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestNewForTest(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
m := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
require.NotNil(t, m)
|
||||||
|
assert.NotNil(t, m.DeploymentsTotal)
|
||||||
|
assert.NotNil(t, m.DeploymentDuration)
|
||||||
|
assert.NotNil(t, m.DeploymentsInFlight)
|
||||||
|
assert.NotNil(t, m.ContainerHealthy)
|
||||||
|
assert.NotNil(t, m.WebhookEventsTotal)
|
||||||
|
assert.NotNil(t, m.HTTPRequestsTotal)
|
||||||
|
assert.NotNil(t, m.HTTPRequestDuration)
|
||||||
|
assert.NotNil(t, m.HTTPResponseSizeBytes)
|
||||||
|
assert.NotNil(t, m.AuditEventsTotal)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNew(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
m, err := metrics.New(fx.Lifecycle(nil), metrics.Params{})
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.NotNil(t, m)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestDeploymentMetrics(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
m := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
m.DeploymentsTotal.WithLabelValues("test-app", "success").Inc()
|
||||||
|
m.DeploymentDuration.WithLabelValues("test-app", "success").Observe(42.5)
|
||||||
|
m.DeploymentsInFlight.WithLabelValues("test-app").Set(1)
|
||||||
|
|
||||||
|
families, err := reg.Gather()
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
names := make(map[string]bool)
|
||||||
|
|
||||||
|
for _, f := range families {
|
||||||
|
names[f.GetName()] = true
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.True(t, names["upaas_deployments_total"])
|
||||||
|
assert.True(t, names["upaas_deployments_duration_seconds"])
|
||||||
|
assert.True(t, names["upaas_deployments_in_flight"])
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestContainerHealthMetrics(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
m := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
m.ContainerHealthy.WithLabelValues("my-app").Set(1)
|
||||||
|
|
||||||
|
families, err := reg.Gather()
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
found := false
|
||||||
|
|
||||||
|
for _, f := range families {
|
||||||
|
if f.GetName() == "upaas_container_healthy" {
|
||||||
|
found = true
|
||||||
|
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.True(t, found)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWebhookMetrics(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
m := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
m.WebhookEventsTotal.WithLabelValues("test-app", "push", "true").Inc()
|
||||||
|
|
||||||
|
families, err := reg.Gather()
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
found := false
|
||||||
|
|
||||||
|
for _, f := range families {
|
||||||
|
if f.GetName() == "upaas_webhook_events_total" {
|
||||||
|
found = true
|
||||||
|
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.True(t, found)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestHTTPMetrics(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
m := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
m.HTTPRequestsTotal.WithLabelValues("GET", "200").Inc()
|
||||||
|
m.HTTPRequestDuration.WithLabelValues("GET").Observe(0.05)
|
||||||
|
m.HTTPResponseSizeBytes.WithLabelValues("GET").Observe(1024)
|
||||||
|
|
||||||
|
families, err := reg.Gather()
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
names := make(map[string]bool)
|
||||||
|
|
||||||
|
for _, f := range families {
|
||||||
|
names[f.GetName()] = true
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.True(t, names["upaas_http_requests_total"])
|
||||||
|
assert.True(t, names["upaas_http_request_duration_seconds"])
|
||||||
|
assert.True(t, names["upaas_http_response_size_bytes"])
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditMetrics(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
m := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
m.AuditEventsTotal.WithLabelValues("login").Inc()
|
||||||
|
|
||||||
|
families, err := reg.Gather()
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
found := false
|
||||||
|
|
||||||
|
for _, f := range families {
|
||||||
|
if f.GetName() == "upaas_audit_events_total" {
|
||||||
|
found = true
|
||||||
|
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.True(t, found)
|
||||||
|
}
|
||||||
@@ -21,6 +21,7 @@ import (
|
|||||||
"sneak.berlin/go/upaas/internal/config"
|
"sneak.berlin/go/upaas/internal/config"
|
||||||
"sneak.berlin/go/upaas/internal/globals"
|
"sneak.berlin/go/upaas/internal/globals"
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
"sneak.berlin/go/upaas/internal/service/auth"
|
"sneak.berlin/go/upaas/internal/service/auth"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -35,11 +36,13 @@ type Params struct {
|
|||||||
Globals *globals.Globals
|
Globals *globals.Globals
|
||||||
Config *config.Config
|
Config *config.Config
|
||||||
Auth *auth.Service
|
Auth *auth.Service
|
||||||
|
Metrics *metrics.Metrics
|
||||||
}
|
}
|
||||||
|
|
||||||
// Middleware provides HTTP middleware.
|
// Middleware provides HTTP middleware.
|
||||||
type Middleware struct {
|
type Middleware struct {
|
||||||
log *slog.Logger
|
log *slog.Logger
|
||||||
|
metrics *metrics.Metrics
|
||||||
params *Params
|
params *Params
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -47,21 +50,23 @@ type Middleware struct {
|
|||||||
func New(_ fx.Lifecycle, params Params) (*Middleware, error) {
|
func New(_ fx.Lifecycle, params Params) (*Middleware, error) {
|
||||||
return &Middleware{
|
return &Middleware{
|
||||||
log: params.Logger.Get(),
|
log: params.Logger.Get(),
|
||||||
|
metrics: params.Metrics,
|
||||||
params: ¶ms,
|
params: ¶ms,
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// loggingResponseWriter wraps http.ResponseWriter to capture status code.
|
// loggingResponseWriter wraps http.ResponseWriter to capture status code and bytes written.
|
||||||
type loggingResponseWriter struct {
|
type loggingResponseWriter struct {
|
||||||
http.ResponseWriter
|
http.ResponseWriter
|
||||||
|
|
||||||
statusCode int
|
statusCode int
|
||||||
|
bytesWritten int
|
||||||
}
|
}
|
||||||
|
|
||||||
func newLoggingResponseWriter(
|
func newLoggingResponseWriter(
|
||||||
writer http.ResponseWriter,
|
writer http.ResponseWriter,
|
||||||
) *loggingResponseWriter {
|
) *loggingResponseWriter {
|
||||||
return &loggingResponseWriter{writer, http.StatusOK}
|
return &loggingResponseWriter{ResponseWriter: writer, statusCode: http.StatusOK}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (lrw *loggingResponseWriter) WriteHeader(code int) {
|
func (lrw *loggingResponseWriter) WriteHeader(code int) {
|
||||||
@@ -69,7 +74,14 @@ func (lrw *loggingResponseWriter) WriteHeader(code int) {
|
|||||||
lrw.ResponseWriter.WriteHeader(code)
|
lrw.ResponseWriter.WriteHeader(code)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Logging returns a request logging middleware.
|
func (lrw *loggingResponseWriter) Write(b []byte) (int, error) {
|
||||||
|
n, err := lrw.ResponseWriter.Write(b)
|
||||||
|
lrw.bytesWritten += n
|
||||||
|
|
||||||
|
return n, err
|
||||||
|
}
|
||||||
|
|
||||||
|
// Logging returns a request logging middleware that also records HTTP metrics.
|
||||||
func (m *Middleware) Logging() func(http.Handler) http.Handler {
|
func (m *Middleware) Logging() func(http.Handler) http.Handler {
|
||||||
return func(next http.Handler) http.Handler {
|
return func(next http.Handler) http.Handler {
|
||||||
return http.HandlerFunc(func(
|
return http.HandlerFunc(func(
|
||||||
@@ -83,6 +95,8 @@ func (m *Middleware) Logging() func(http.Handler) http.Handler {
|
|||||||
defer func() {
|
defer func() {
|
||||||
latency := time.Since(start)
|
latency := time.Since(start)
|
||||||
reqID := middleware.GetReqID(ctx)
|
reqID := middleware.GetReqID(ctx)
|
||||||
|
statusStr := strconv.Itoa(lrw.statusCode)
|
||||||
|
|
||||||
m.log.InfoContext(ctx, "request",
|
m.log.InfoContext(ctx, "request",
|
||||||
"request_start", start,
|
"request_start", start,
|
||||||
"method", request.Method,
|
"method", request.Method,
|
||||||
@@ -91,10 +105,21 @@ func (m *Middleware) Logging() func(http.Handler) http.Handler {
|
|||||||
"request_id", reqID,
|
"request_id", reqID,
|
||||||
"referer", request.Referer(),
|
"referer", request.Referer(),
|
||||||
"proto", request.Proto,
|
"proto", request.Proto,
|
||||||
"remoteIP", realIP(request),
|
"remoteIP", RealIP(request),
|
||||||
"status", lrw.statusCode,
|
"status", lrw.statusCode,
|
||||||
|
"bytes", lrw.bytesWritten,
|
||||||
"latency_ms", latency.Milliseconds(),
|
"latency_ms", latency.Milliseconds(),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
m.metrics.HTTPRequestsTotal.WithLabelValues(
|
||||||
|
request.Method, statusStr,
|
||||||
|
).Inc()
|
||||||
|
m.metrics.HTTPRequestDuration.WithLabelValues(
|
||||||
|
request.Method,
|
||||||
|
).Observe(latency.Seconds())
|
||||||
|
m.metrics.HTTPResponseSizeBytes.WithLabelValues(
|
||||||
|
request.Method,
|
||||||
|
).Observe(float64(lrw.bytesWritten))
|
||||||
}()
|
}()
|
||||||
|
|
||||||
next.ServeHTTP(lrw, request)
|
next.ServeHTTP(lrw, request)
|
||||||
@@ -145,11 +170,11 @@ func isTrustedProxy(ip net.IP) bool {
|
|||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
// realIP extracts the client's real IP address from the request.
|
// RealIP extracts the client's real IP address from the request.
|
||||||
// Proxy headers (X-Real-IP, X-Forwarded-For) are only trusted when the
|
// Proxy headers (X-Real-IP, X-Forwarded-For) are only trusted when the
|
||||||
// direct connection originates from an RFC1918/loopback address.
|
// direct connection originates from an RFC1918/loopback address.
|
||||||
// Otherwise, headers are ignored and RemoteAddr is used (fail closed).
|
// Otherwise, headers are ignored and RemoteAddr is used (fail closed).
|
||||||
func realIP(r *http.Request) string {
|
func RealIP(r *http.Request) string {
|
||||||
addr := ipFromHostPort(r.RemoteAddr)
|
addr := ipFromHostPort(r.RemoteAddr)
|
||||||
remoteIP := net.ParseIP(addr)
|
remoteIP := net.ParseIP(addr)
|
||||||
|
|
||||||
@@ -340,7 +365,7 @@ func (m *Middleware) LoginRateLimit() func(http.Handler) http.Handler {
|
|||||||
writer http.ResponseWriter,
|
writer http.ResponseWriter,
|
||||||
request *http.Request,
|
request *http.Request,
|
||||||
) {
|
) {
|
||||||
ip := realIP(request)
|
ip := RealIP(request)
|
||||||
limiter := loginLimiter.getLimiter(ip)
|
limiter := loginLimiter.getLimiter(ip)
|
||||||
|
|
||||||
if !limiter.Allow() {
|
if !limiter.Allow() {
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
package middleware //nolint:testpackage // tests unexported realIP function
|
package middleware //nolint:testpackage // tests RealIP via internal package access
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
@@ -126,9 +126,9 @@ func TestRealIP(t *testing.T) { //nolint:funlen // table-driven test
|
|||||||
req.Header.Set("X-Forwarded-For", tt.xff)
|
req.Header.Set("X-Forwarded-For", tt.xff)
|
||||||
}
|
}
|
||||||
|
|
||||||
got := realIP(req)
|
got := RealIP(req)
|
||||||
if got != tt.want {
|
if got != tt.want {
|
||||||
t.Errorf("realIP() = %q, want %q", got, tt.want)
|
t.Errorf("RealIP() = %q, want %q", got, tt.want)
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -14,7 +14,7 @@ import (
|
|||||||
const appColumns = `id, name, repo_url, branch, dockerfile_path, webhook_secret,
|
const appColumns = `id, name, repo_url, branch, dockerfile_path, webhook_secret,
|
||||||
ssh_private_key, ssh_public_key, image_id, status,
|
ssh_private_key, ssh_public_key, image_id, status,
|
||||||
docker_network, ntfy_topic, slack_webhook, webhook_secret_hash,
|
docker_network, ntfy_topic, slack_webhook, webhook_secret_hash,
|
||||||
previous_image_id, healthcheck_command, created_at, updated_at`
|
previous_image_id, created_at, updated_at`
|
||||||
|
|
||||||
// AppStatus represents the status of an app.
|
// AppStatus represents the status of an app.
|
||||||
type AppStatus string
|
type AppStatus string
|
||||||
@@ -47,7 +47,6 @@ type App struct {
|
|||||||
DockerNetwork sql.NullString
|
DockerNetwork sql.NullString
|
||||||
NtfyTopic sql.NullString
|
NtfyTopic sql.NullString
|
||||||
SlackWebhook sql.NullString
|
SlackWebhook sql.NullString
|
||||||
HealthcheckCommand sql.NullString
|
|
||||||
CreatedAt time.Time
|
CreatedAt time.Time
|
||||||
UpdatedAt time.Time
|
UpdatedAt time.Time
|
||||||
}
|
}
|
||||||
@@ -143,14 +142,14 @@ func (a *App) insert(ctx context.Context) error {
|
|||||||
id, name, repo_url, branch, dockerfile_path, webhook_secret,
|
id, name, repo_url, branch, dockerfile_path, webhook_secret,
|
||||||
ssh_private_key, ssh_public_key, image_id, status,
|
ssh_private_key, ssh_public_key, image_id, status,
|
||||||
docker_network, ntfy_topic, slack_webhook, webhook_secret_hash,
|
docker_network, ntfy_topic, slack_webhook, webhook_secret_hash,
|
||||||
previous_image_id, healthcheck_command
|
previous_image_id
|
||||||
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
|
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
|
||||||
|
|
||||||
_, err := a.db.Exec(ctx, query,
|
_, err := a.db.Exec(ctx, query,
|
||||||
a.ID, a.Name, a.RepoURL, a.Branch, a.DockerfilePath, a.WebhookSecret,
|
a.ID, a.Name, a.RepoURL, a.Branch, a.DockerfilePath, a.WebhookSecret,
|
||||||
a.SSHPrivateKey, a.SSHPublicKey, a.ImageID, a.Status,
|
a.SSHPrivateKey, a.SSHPublicKey, a.ImageID, a.Status,
|
||||||
a.DockerNetwork, a.NtfyTopic, a.SlackWebhook, a.WebhookSecretHash,
|
a.DockerNetwork, a.NtfyTopic, a.SlackWebhook, a.WebhookSecretHash,
|
||||||
a.PreviousImageID, a.HealthcheckCommand,
|
a.PreviousImageID,
|
||||||
)
|
)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
@@ -165,7 +164,7 @@ func (a *App) update(ctx context.Context) error {
|
|||||||
name = ?, repo_url = ?, branch = ?, dockerfile_path = ?,
|
name = ?, repo_url = ?, branch = ?, dockerfile_path = ?,
|
||||||
image_id = ?, status = ?,
|
image_id = ?, status = ?,
|
||||||
docker_network = ?, ntfy_topic = ?, slack_webhook = ?,
|
docker_network = ?, ntfy_topic = ?, slack_webhook = ?,
|
||||||
previous_image_id = ?, healthcheck_command = ?,
|
previous_image_id = ?,
|
||||||
updated_at = CURRENT_TIMESTAMP
|
updated_at = CURRENT_TIMESTAMP
|
||||||
WHERE id = ?`
|
WHERE id = ?`
|
||||||
|
|
||||||
@@ -173,7 +172,7 @@ func (a *App) update(ctx context.Context) error {
|
|||||||
a.Name, a.RepoURL, a.Branch, a.DockerfilePath,
|
a.Name, a.RepoURL, a.Branch, a.DockerfilePath,
|
||||||
a.ImageID, a.Status,
|
a.ImageID, a.Status,
|
||||||
a.DockerNetwork, a.NtfyTopic, a.SlackWebhook,
|
a.DockerNetwork, a.NtfyTopic, a.SlackWebhook,
|
||||||
a.PreviousImageID, a.HealthcheckCommand,
|
a.PreviousImageID,
|
||||||
a.ID,
|
a.ID,
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -188,7 +187,7 @@ func (a *App) scan(row *sql.Row) error {
|
|||||||
&a.ImageID, &a.Status,
|
&a.ImageID, &a.Status,
|
||||||
&a.DockerNetwork, &a.NtfyTopic, &a.SlackWebhook,
|
&a.DockerNetwork, &a.NtfyTopic, &a.SlackWebhook,
|
||||||
&a.WebhookSecretHash,
|
&a.WebhookSecretHash,
|
||||||
&a.PreviousImageID, &a.HealthcheckCommand,
|
&a.PreviousImageID,
|
||||||
&a.CreatedAt, &a.UpdatedAt,
|
&a.CreatedAt, &a.UpdatedAt,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
@@ -206,7 +205,7 @@ func scanApps(appDB *database.Database, rows *sql.Rows) ([]*App, error) {
|
|||||||
&app.ImageID, &app.Status,
|
&app.ImageID, &app.Status,
|
||||||
&app.DockerNetwork, &app.NtfyTopic, &app.SlackWebhook,
|
&app.DockerNetwork, &app.NtfyTopic, &app.SlackWebhook,
|
||||||
&app.WebhookSecretHash,
|
&app.WebhookSecretHash,
|
||||||
&app.PreviousImageID, &app.HealthcheckCommand,
|
&app.PreviousImageID,
|
||||||
&app.CreatedAt, &app.UpdatedAt,
|
&app.CreatedAt, &app.UpdatedAt,
|
||||||
)
|
)
|
||||||
if scanErr != nil {
|
if scanErr != nil {
|
||||||
|
|||||||
193
internal/models/audit_log.go
Normal file
193
internal/models/audit_log.go
Normal file
@@ -0,0 +1,193 @@
|
|||||||
|
package models
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"fmt"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"sneak.berlin/go/upaas/internal/database"
|
||||||
|
)
|
||||||
|
|
||||||
|
// AuditAction represents the type of audited user action.
|
||||||
|
type AuditAction string
|
||||||
|
|
||||||
|
// Audit action constants.
|
||||||
|
const (
|
||||||
|
AuditActionLogin AuditAction = "login"
|
||||||
|
AuditActionLogout AuditAction = "logout"
|
||||||
|
AuditActionAppCreate AuditAction = "app.create"
|
||||||
|
AuditActionAppUpdate AuditAction = "app.update"
|
||||||
|
AuditActionAppDelete AuditAction = "app.delete"
|
||||||
|
AuditActionAppDeploy AuditAction = "app.deploy"
|
||||||
|
AuditActionAppRollback AuditAction = "app.rollback"
|
||||||
|
AuditActionAppRestart AuditAction = "app.restart"
|
||||||
|
AuditActionAppStop AuditAction = "app.stop"
|
||||||
|
AuditActionAppStart AuditAction = "app.start"
|
||||||
|
AuditActionDeployCancel AuditAction = "deploy.cancel"
|
||||||
|
AuditActionEnvVarSave AuditAction = "env_var.save"
|
||||||
|
AuditActionLabelAdd AuditAction = "label.add"
|
||||||
|
AuditActionLabelEdit AuditAction = "label.edit"
|
||||||
|
AuditActionLabelDelete AuditAction = "label.delete"
|
||||||
|
AuditActionVolumeAdd AuditAction = "volume.add"
|
||||||
|
AuditActionVolumeEdit AuditAction = "volume.edit"
|
||||||
|
AuditActionVolumeDelete AuditAction = "volume.delete"
|
||||||
|
AuditActionPortAdd AuditAction = "port.add"
|
||||||
|
AuditActionPortDelete AuditAction = "port.delete"
|
||||||
|
AuditActionSetup AuditAction = "setup"
|
||||||
|
AuditActionWebhookReceive AuditAction = "webhook.receive"
|
||||||
|
)
|
||||||
|
|
||||||
|
// AuditResourceType represents the type of resource being acted on.
|
||||||
|
type AuditResourceType string
|
||||||
|
|
||||||
|
// Audit resource type constants.
|
||||||
|
const (
|
||||||
|
AuditResourceApp AuditResourceType = "app"
|
||||||
|
AuditResourceUser AuditResourceType = "user"
|
||||||
|
AuditResourceSession AuditResourceType = "session"
|
||||||
|
AuditResourceEnvVar AuditResourceType = "env_var"
|
||||||
|
AuditResourceLabel AuditResourceType = "label"
|
||||||
|
AuditResourceVolume AuditResourceType = "volume"
|
||||||
|
AuditResourcePort AuditResourceType = "port"
|
||||||
|
AuditResourceDeployment AuditResourceType = "deployment"
|
||||||
|
AuditResourceWebhook AuditResourceType = "webhook"
|
||||||
|
)
|
||||||
|
|
||||||
|
// AuditEntry represents a single audit log entry.
|
||||||
|
type AuditEntry struct {
|
||||||
|
db *database.Database
|
||||||
|
|
||||||
|
ID int64
|
||||||
|
UserID sql.NullInt64
|
||||||
|
Username string
|
||||||
|
Action AuditAction
|
||||||
|
ResourceType AuditResourceType
|
||||||
|
ResourceID sql.NullString
|
||||||
|
Detail sql.NullString
|
||||||
|
RemoteIP sql.NullString
|
||||||
|
CreatedAt time.Time
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewAuditEntry creates a new AuditEntry with a database reference.
|
||||||
|
func NewAuditEntry(db *database.Database) *AuditEntry {
|
||||||
|
return &AuditEntry{db: db}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Save inserts the audit entry into the database.
|
||||||
|
func (a *AuditEntry) Save(ctx context.Context) error {
|
||||||
|
query := `
|
||||||
|
INSERT INTO audit_log (
|
||||||
|
user_id, username, action, resource_type, resource_id,
|
||||||
|
detail, remote_ip
|
||||||
|
) VALUES (?, ?, ?, ?, ?, ?, ?)`
|
||||||
|
|
||||||
|
result, err := a.db.Exec(ctx, query,
|
||||||
|
a.UserID, a.Username, a.Action, a.ResourceType,
|
||||||
|
a.ResourceID, a.Detail, a.RemoteIP,
|
||||||
|
)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("inserting audit entry: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
id, err := result.LastInsertId()
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("getting audit entry id: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
a.ID = id
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// FindAuditEntries returns recent audit log entries, newest first.
|
||||||
|
func FindAuditEntries(
|
||||||
|
ctx context.Context,
|
||||||
|
db *database.Database,
|
||||||
|
limit int,
|
||||||
|
) ([]*AuditEntry, error) {
|
||||||
|
query := `
|
||||||
|
SELECT id, user_id, username, action, resource_type, resource_id,
|
||||||
|
detail, remote_ip, created_at
|
||||||
|
FROM audit_log
|
||||||
|
ORDER BY created_at DESC
|
||||||
|
LIMIT ?`
|
||||||
|
|
||||||
|
rows, err := db.Query(ctx, query, limit)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("querying audit entries: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
defer func() { _ = rows.Close() }()
|
||||||
|
|
||||||
|
return scanAuditRows(rows)
|
||||||
|
}
|
||||||
|
|
||||||
|
// FindAuditEntriesByResource returns audit log entries for a specific resource.
|
||||||
|
func FindAuditEntriesByResource(
|
||||||
|
ctx context.Context,
|
||||||
|
db *database.Database,
|
||||||
|
resourceType AuditResourceType,
|
||||||
|
resourceID string,
|
||||||
|
limit int,
|
||||||
|
) ([]*AuditEntry, error) {
|
||||||
|
query := `
|
||||||
|
SELECT id, user_id, username, action, resource_type, resource_id,
|
||||||
|
detail, remote_ip, created_at
|
||||||
|
FROM audit_log
|
||||||
|
WHERE resource_type = ? AND resource_id = ?
|
||||||
|
ORDER BY created_at DESC
|
||||||
|
LIMIT ?`
|
||||||
|
|
||||||
|
rows, err := db.Query(ctx, query, resourceType, resourceID, limit)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("querying audit entries by resource: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
defer func() { _ = rows.Close() }()
|
||||||
|
|
||||||
|
return scanAuditRows(rows)
|
||||||
|
}
|
||||||
|
|
||||||
|
// CountAuditEntries returns the total number of audit log entries.
|
||||||
|
func CountAuditEntries(
|
||||||
|
ctx context.Context,
|
||||||
|
db *database.Database,
|
||||||
|
) (int, error) {
|
||||||
|
var count int
|
||||||
|
|
||||||
|
row := db.QueryRow(ctx, "SELECT COUNT(*) FROM audit_log")
|
||||||
|
|
||||||
|
err := row.Scan(&count)
|
||||||
|
if err != nil {
|
||||||
|
return 0, fmt.Errorf("counting audit entries: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return count, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func scanAuditRows(rows *sql.Rows) ([]*AuditEntry, error) {
|
||||||
|
var entries []*AuditEntry
|
||||||
|
|
||||||
|
for rows.Next() {
|
||||||
|
entry := &AuditEntry{}
|
||||||
|
|
||||||
|
scanErr := rows.Scan(
|
||||||
|
&entry.ID, &entry.UserID, &entry.Username, &entry.Action,
|
||||||
|
&entry.ResourceType, &entry.ResourceID, &entry.Detail,
|
||||||
|
&entry.RemoteIP, &entry.CreatedAt,
|
||||||
|
)
|
||||||
|
if scanErr != nil {
|
||||||
|
return nil, fmt.Errorf("scanning audit entry: %w", scanErr)
|
||||||
|
}
|
||||||
|
|
||||||
|
entries = append(entries, entry)
|
||||||
|
}
|
||||||
|
|
||||||
|
rowsErr := rows.Err()
|
||||||
|
if rowsErr != nil {
|
||||||
|
return nil, fmt.Errorf("iterating audit entries: %w", rowsErr)
|
||||||
|
}
|
||||||
|
|
||||||
|
return entries, nil
|
||||||
|
}
|
||||||
@@ -23,6 +23,7 @@ const (
|
|||||||
testBranch = "main"
|
testBranch = "main"
|
||||||
testValue = "value"
|
testValue = "value"
|
||||||
testEventType = "push"
|
testEventType = "push"
|
||||||
|
testAdmin = "admin"
|
||||||
)
|
)
|
||||||
|
|
||||||
func setupTestDB(t *testing.T) (*database.Database, func()) {
|
func setupTestDB(t *testing.T) (*database.Database, func()) {
|
||||||
@@ -183,7 +184,7 @@ func TestUserExists(t *testing.T) {
|
|||||||
defer cleanup()
|
defer cleanup()
|
||||||
|
|
||||||
user := models.NewUser(testDB)
|
user := models.NewUser(testDB)
|
||||||
user.Username = "admin"
|
user.Username = testAdmin
|
||||||
user.PasswordHash = testHash
|
user.PasswordHash = testHash
|
||||||
|
|
||||||
err := user.Save(context.Background())
|
err := user.Save(context.Background())
|
||||||
@@ -704,72 +705,6 @@ func TestAppGetWebhookEvents(t *testing.T) {
|
|||||||
assert.Len(t, events, 1)
|
assert.Len(t, events, 1)
|
||||||
}
|
}
|
||||||
|
|
||||||
// App HealthcheckCommand Tests.
|
|
||||||
|
|
||||||
func TestAppHealthcheckCommand(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
t.Run("saves and loads healthcheck command", func(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
testDB, cleanup := setupTestDB(t)
|
|
||||||
defer cleanup()
|
|
||||||
|
|
||||||
app := createTestApp(t, testDB)
|
|
||||||
app.HealthcheckCommand = sql.NullString{
|
|
||||||
String: "curl -f http://localhost:8080/healthz || exit 1",
|
|
||||||
Valid: true,
|
|
||||||
}
|
|
||||||
|
|
||||||
err := app.Save(context.Background())
|
|
||||||
require.NoError(t, err)
|
|
||||||
|
|
||||||
found, err := models.FindApp(context.Background(), testDB, app.ID)
|
|
||||||
require.NoError(t, err)
|
|
||||||
require.NotNil(t, found)
|
|
||||||
assert.True(t, found.HealthcheckCommand.Valid)
|
|
||||||
assert.Equal(t, "curl -f http://localhost:8080/healthz || exit 1", found.HealthcheckCommand.String)
|
|
||||||
})
|
|
||||||
|
|
||||||
t.Run("null when not set", func(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
testDB, cleanup := setupTestDB(t)
|
|
||||||
defer cleanup()
|
|
||||||
|
|
||||||
app := createTestApp(t, testDB)
|
|
||||||
|
|
||||||
found, err := models.FindApp(context.Background(), testDB, app.ID)
|
|
||||||
require.NoError(t, err)
|
|
||||||
require.NotNil(t, found)
|
|
||||||
assert.False(t, found.HealthcheckCommand.Valid)
|
|
||||||
})
|
|
||||||
|
|
||||||
t.Run("can be cleared", func(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
testDB, cleanup := setupTestDB(t)
|
|
||||||
defer cleanup()
|
|
||||||
|
|
||||||
app := createTestApp(t, testDB)
|
|
||||||
app.HealthcheckCommand = sql.NullString{String: "true", Valid: true}
|
|
||||||
|
|
||||||
err := app.Save(context.Background())
|
|
||||||
require.NoError(t, err)
|
|
||||||
|
|
||||||
// Clear it
|
|
||||||
app.HealthcheckCommand = sql.NullString{}
|
|
||||||
|
|
||||||
err = app.Save(context.Background())
|
|
||||||
require.NoError(t, err)
|
|
||||||
|
|
||||||
found, err := models.FindApp(context.Background(), testDB, app.ID)
|
|
||||||
require.NoError(t, err)
|
|
||||||
require.NotNil(t, found)
|
|
||||||
assert.False(t, found.HealthcheckCommand.Valid)
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
// Cascade Delete Tests.
|
// Cascade Delete Tests.
|
||||||
|
|
||||||
//nolint:funlen // Test function with many assertions - acceptable for integration tests
|
//nolint:funlen // Test function with many assertions - acceptable for integration tests
|
||||||
@@ -847,6 +782,179 @@ func TestCascadeDelete(t *testing.T) {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// AuditEntry Tests.
|
||||||
|
|
||||||
|
func TestAuditEntryCreateAndFind(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testDB, cleanup := setupTestDB(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = models.AuditActionLogin
|
||||||
|
entry.ResourceType = models.AuditResourceSession
|
||||||
|
|
||||||
|
err := entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.NotZero(t, entry.ID)
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(context.Background(), testDB, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.Equal(t, testAdmin, entries[0].Username)
|
||||||
|
assert.Equal(t, models.AuditActionLogin, entries[0].Action)
|
||||||
|
assert.Equal(t, models.AuditResourceSession, entries[0].ResourceType)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditEntryWithAllFields(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testDB, cleanup := setupTestDB(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.UserID = sql.NullInt64{Int64: 1, Valid: true}
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = models.AuditActionAppCreate
|
||||||
|
entry.ResourceType = models.AuditResourceApp
|
||||||
|
entry.ResourceID = sql.NullString{String: "app-123", Valid: true}
|
||||||
|
entry.Detail = sql.NullString{String: "created new app", Valid: true}
|
||||||
|
entry.RemoteIP = sql.NullString{String: "192.168.1.1", Valid: true}
|
||||||
|
|
||||||
|
err := entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(context.Background(), testDB, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.Equal(t, int64(1), entries[0].UserID.Int64)
|
||||||
|
assert.Equal(t, "app-123", entries[0].ResourceID.String)
|
||||||
|
assert.Equal(t, "created new app", entries[0].Detail.String)
|
||||||
|
assert.Equal(t, "192.168.1.1", entries[0].RemoteIP.String)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditEntryFindByResource(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testDB, cleanup := setupTestDB(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
// Create entries for different resources.
|
||||||
|
for _, action := range []models.AuditAction{
|
||||||
|
models.AuditActionAppCreate,
|
||||||
|
models.AuditActionAppUpdate,
|
||||||
|
models.AuditActionAppDeploy,
|
||||||
|
} {
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = action
|
||||||
|
entry.ResourceType = models.AuditResourceApp
|
||||||
|
entry.ResourceID = sql.NullString{String: "app-1", Valid: true}
|
||||||
|
|
||||||
|
err := entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Create entry for a different resource.
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = models.AuditActionLogin
|
||||||
|
entry.ResourceType = models.AuditResourceSession
|
||||||
|
|
||||||
|
err := entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
// Find by resource.
|
||||||
|
appEntries, err := models.FindAuditEntriesByResource(
|
||||||
|
context.Background(), testDB,
|
||||||
|
models.AuditResourceApp, "app-1", 10,
|
||||||
|
)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Len(t, appEntries, 3)
|
||||||
|
|
||||||
|
// All entries.
|
||||||
|
allEntries, err := models.FindAuditEntries(context.Background(), testDB, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Len(t, allEntries, 4)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditEntryCount(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testDB, cleanup := setupTestDB(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
count, err := models.CountAuditEntries(context.Background(), testDB)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Equal(t, 0, count)
|
||||||
|
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = models.AuditActionLogin
|
||||||
|
entry.ResourceType = models.AuditResourceSession
|
||||||
|
|
||||||
|
err = entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
count, err = models.CountAuditEntries(context.Background(), testDB)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Equal(t, 1, count)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditEntryFindLimit(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testDB, cleanup := setupTestDB(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
for range 5 {
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = models.AuditActionLogin
|
||||||
|
entry.ResourceType = models.AuditResourceSession
|
||||||
|
|
||||||
|
err := entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(context.Background(), testDB, 3)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Len(t, entries, 3)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditEntryOrderByCreatedAtDesc(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testDB, cleanup := setupTestDB(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
actions := []models.AuditAction{
|
||||||
|
models.AuditActionLogin,
|
||||||
|
models.AuditActionAppCreate,
|
||||||
|
models.AuditActionLogout,
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, action := range actions {
|
||||||
|
entry := models.NewAuditEntry(testDB)
|
||||||
|
entry.Username = testAdmin
|
||||||
|
entry.Action = action
|
||||||
|
entry.ResourceType = models.AuditResourceSession
|
||||||
|
|
||||||
|
err := entry.Save(context.Background())
|
||||||
|
require.NoError(t, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(context.Background(), testDB, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 3)
|
||||||
|
|
||||||
|
// Newest first (logout was last inserted).
|
||||||
|
assert.Equal(t, models.AuditActionLogout, entries[0].Action)
|
||||||
|
assert.Equal(t, models.AuditActionAppCreate, entries[1].Action)
|
||||||
|
assert.Equal(t, models.AuditActionLogin, entries[2].Action)
|
||||||
|
}
|
||||||
|
|
||||||
// Helper function to create a test app.
|
// Helper function to create a test app.
|
||||||
func createTestApp(t *testing.T, testDB *database.Database) *models.App {
|
func createTestApp(t *testing.T, testDB *database.Database) *models.App {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
|
|||||||
@@ -115,14 +115,13 @@ func (s *Server) SetupRoutes() {
|
|||||||
r.Get("/apps", s.handlers.HandleAPIListApps())
|
r.Get("/apps", s.handlers.HandleAPIListApps())
|
||||||
r.Get("/apps/{id}", s.handlers.HandleAPIGetApp())
|
r.Get("/apps/{id}", s.handlers.HandleAPIGetApp())
|
||||||
r.Get("/apps/{id}/deployments", s.handlers.HandleAPIListDeployments())
|
r.Get("/apps/{id}/deployments", s.handlers.HandleAPIListDeployments())
|
||||||
|
r.Get("/audit", s.handlers.HandleAPIAuditLog())
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
// Metrics endpoint (optional, with basic auth)
|
// Metrics endpoint (always available, optionally protected with basic auth)
|
||||||
if s.params.Config.MetricsUsername != "" {
|
|
||||||
s.router.Group(func(r chi.Router) {
|
s.router.Group(func(r chi.Router) {
|
||||||
r.Use(s.mw.MetricsAuth())
|
r.Use(s.mw.MetricsAuth())
|
||||||
r.Get("/metrics", promhttp.Handler().ServeHTTP)
|
r.Get("/metrics", promhttp.Handler().ServeHTTP)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|||||||
@@ -53,7 +53,6 @@ type CreateAppInput struct {
|
|||||||
DockerNetwork string
|
DockerNetwork string
|
||||||
NtfyTopic string
|
NtfyTopic string
|
||||||
SlackWebhook string
|
SlackWebhook string
|
||||||
HealthcheckCommand string
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// CreateApp creates a new application with generated SSH keys and webhook secret.
|
// CreateApp creates a new application with generated SSH keys and webhook secret.
|
||||||
@@ -101,10 +100,6 @@ func (svc *Service) CreateApp(
|
|||||||
app.SlackWebhook = sql.NullString{String: input.SlackWebhook, Valid: true}
|
app.SlackWebhook = sql.NullString{String: input.SlackWebhook, Valid: true}
|
||||||
}
|
}
|
||||||
|
|
||||||
if input.HealthcheckCommand != "" {
|
|
||||||
app.HealthcheckCommand = sql.NullString{String: input.HealthcheckCommand, Valid: true}
|
|
||||||
}
|
|
||||||
|
|
||||||
saveErr := app.Save(ctx)
|
saveErr := app.Save(ctx)
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
return nil, fmt.Errorf("failed to save app: %w", saveErr)
|
return nil, fmt.Errorf("failed to save app: %w", saveErr)
|
||||||
@@ -124,7 +119,6 @@ type UpdateAppInput struct {
|
|||||||
DockerNetwork string
|
DockerNetwork string
|
||||||
NtfyTopic string
|
NtfyTopic string
|
||||||
SlackWebhook string
|
SlackWebhook string
|
||||||
HealthcheckCommand string
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// UpdateApp updates an existing application.
|
// UpdateApp updates an existing application.
|
||||||
@@ -150,10 +144,6 @@ func (svc *Service) UpdateApp(
|
|||||||
String: input.SlackWebhook,
|
String: input.SlackWebhook,
|
||||||
Valid: input.SlackWebhook != "",
|
Valid: input.SlackWebhook != "",
|
||||||
}
|
}
|
||||||
app.HealthcheckCommand = sql.NullString{
|
|
||||||
String: input.HealthcheckCommand,
|
|
||||||
Valid: input.HealthcheckCommand != "",
|
|
||||||
}
|
|
||||||
|
|
||||||
saveErr := app.Save(ctx)
|
saveErr := app.Save(ctx)
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
|
|||||||
126
internal/service/audit/audit.go
Normal file
126
internal/service/audit/audit.go
Normal file
@@ -0,0 +1,126 @@
|
|||||||
|
// Package audit provides audit logging for user actions.
|
||||||
|
package audit
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"log/slog"
|
||||||
|
"net/http"
|
||||||
|
|
||||||
|
"go.uber.org/fx"
|
||||||
|
|
||||||
|
"sneak.berlin/go/upaas/internal/database"
|
||||||
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
|
"sneak.berlin/go/upaas/internal/middleware"
|
||||||
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
|
)
|
||||||
|
|
||||||
|
// ServiceParams contains dependencies for Service.
|
||||||
|
type ServiceParams struct {
|
||||||
|
fx.In
|
||||||
|
|
||||||
|
Logger *logger.Logger
|
||||||
|
Database *database.Database
|
||||||
|
Metrics *metrics.Metrics
|
||||||
|
}
|
||||||
|
|
||||||
|
// Service provides audit logging functionality.
|
||||||
|
type Service struct {
|
||||||
|
log *slog.Logger
|
||||||
|
db *database.Database
|
||||||
|
metrics *metrics.Metrics
|
||||||
|
}
|
||||||
|
|
||||||
|
// New creates a new audit Service.
|
||||||
|
func New(_ fx.Lifecycle, params ServiceParams) (*Service, error) {
|
||||||
|
return &Service{
|
||||||
|
log: params.Logger.Get(),
|
||||||
|
db: params.Database,
|
||||||
|
metrics: params.Metrics,
|
||||||
|
}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// LogEntry records an audit event.
|
||||||
|
type LogEntry struct {
|
||||||
|
UserID int64
|
||||||
|
Username string
|
||||||
|
Action models.AuditAction
|
||||||
|
ResourceType models.AuditResourceType
|
||||||
|
ResourceID string
|
||||||
|
Detail string
|
||||||
|
RemoteIP string
|
||||||
|
}
|
||||||
|
|
||||||
|
// Log records an audit log entry and increments the audit metrics counter.
|
||||||
|
func (svc *Service) Log(ctx context.Context, entry LogEntry) {
|
||||||
|
auditEntry := models.NewAuditEntry(svc.db)
|
||||||
|
auditEntry.Username = entry.Username
|
||||||
|
auditEntry.Action = entry.Action
|
||||||
|
auditEntry.ResourceType = entry.ResourceType
|
||||||
|
|
||||||
|
if entry.UserID != 0 {
|
||||||
|
auditEntry.UserID = sql.NullInt64{Int64: entry.UserID, Valid: true}
|
||||||
|
}
|
||||||
|
|
||||||
|
if entry.ResourceID != "" {
|
||||||
|
auditEntry.ResourceID = sql.NullString{String: entry.ResourceID, Valid: true}
|
||||||
|
}
|
||||||
|
|
||||||
|
if entry.Detail != "" {
|
||||||
|
auditEntry.Detail = sql.NullString{String: entry.Detail, Valid: true}
|
||||||
|
}
|
||||||
|
|
||||||
|
if entry.RemoteIP != "" {
|
||||||
|
auditEntry.RemoteIP = sql.NullString{String: entry.RemoteIP, Valid: true}
|
||||||
|
}
|
||||||
|
|
||||||
|
err := auditEntry.Save(ctx)
|
||||||
|
if err != nil {
|
||||||
|
svc.log.Error("failed to save audit entry",
|
||||||
|
"error", err,
|
||||||
|
"action", entry.Action,
|
||||||
|
"username", entry.Username,
|
||||||
|
)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
svc.metrics.AuditEventsTotal.WithLabelValues(string(entry.Action)).Inc()
|
||||||
|
|
||||||
|
svc.log.Info("audit",
|
||||||
|
"action", entry.Action,
|
||||||
|
"username", entry.Username,
|
||||||
|
"resource_type", entry.ResourceType,
|
||||||
|
"resource_id", entry.ResourceID,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
// LogFromRequest records an audit log entry, extracting the remote IP from
|
||||||
|
// the HTTP request using the middleware's trusted-proxy-aware IP resolution.
|
||||||
|
func (svc *Service) LogFromRequest(
|
||||||
|
ctx context.Context,
|
||||||
|
request *http.Request,
|
||||||
|
entry LogEntry,
|
||||||
|
) {
|
||||||
|
entry.RemoteIP = middleware.RealIP(request)
|
||||||
|
svc.Log(ctx, entry)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Recent returns the most recent audit log entries.
|
||||||
|
func (svc *Service) Recent(
|
||||||
|
ctx context.Context,
|
||||||
|
limit int,
|
||||||
|
) ([]*models.AuditEntry, error) {
|
||||||
|
return models.FindAuditEntries(ctx, svc.db, limit)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ForResource returns audit log entries for a specific resource.
|
||||||
|
func (svc *Service) ForResource(
|
||||||
|
ctx context.Context,
|
||||||
|
resourceType models.AuditResourceType,
|
||||||
|
resourceID string,
|
||||||
|
limit int,
|
||||||
|
) ([]*models.AuditEntry, error) {
|
||||||
|
return models.FindAuditEntriesByResource(ctx, svc.db, resourceType, resourceID, limit)
|
||||||
|
}
|
||||||
221
internal/service/audit/audit_test.go
Normal file
221
internal/service/audit/audit_test.go
Normal file
@@ -0,0 +1,221 @@
|
|||||||
|
package audit_test
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"log/slog"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"os"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/prometheus/client_golang/prometheus"
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
"github.com/stretchr/testify/require"
|
||||||
|
"go.uber.org/fx"
|
||||||
|
|
||||||
|
"sneak.berlin/go/upaas/internal/config"
|
||||||
|
"sneak.berlin/go/upaas/internal/database"
|
||||||
|
"sneak.berlin/go/upaas/internal/globals"
|
||||||
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
|
"sneak.berlin/go/upaas/internal/service/audit"
|
||||||
|
)
|
||||||
|
|
||||||
|
func setupTestAuditService(t *testing.T) (*audit.Service, *database.Database) {
|
||||||
|
t.Helper()
|
||||||
|
|
||||||
|
globals.SetAppname("upaas-test")
|
||||||
|
globals.SetVersion("test")
|
||||||
|
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
|
||||||
|
cfg := &config.Config{
|
||||||
|
DataDir: tmpDir,
|
||||||
|
}
|
||||||
|
|
||||||
|
log := slog.New(slog.NewTextHandler(os.Stderr, nil))
|
||||||
|
logWrapper := logger.NewForTest(log)
|
||||||
|
|
||||||
|
db, err := database.New(fx.Lifecycle(nil), database.Params{
|
||||||
|
Logger: logWrapper,
|
||||||
|
Config: cfg,
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
metricsInstance := metrics.NewForTest(reg)
|
||||||
|
|
||||||
|
svc, err := audit.New(fx.Lifecycle(nil), audit.ServiceParams{
|
||||||
|
Logger: logWrapper,
|
||||||
|
Database: db,
|
||||||
|
Metrics: metricsInstance,
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
return svc, db
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceLog(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, db := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
svc.Log(ctx, audit.LogEntry{
|
||||||
|
UserID: 1,
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionLogin,
|
||||||
|
ResourceType: models.AuditResourceSession,
|
||||||
|
Detail: "user logged in",
|
||||||
|
RemoteIP: "127.0.0.1",
|
||||||
|
})
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(ctx, db, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.Equal(t, "admin", entries[0].Username)
|
||||||
|
assert.Equal(t, models.AuditActionLogin, entries[0].Action)
|
||||||
|
assert.Equal(t, "127.0.0.1", entries[0].RemoteIP.String)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceLogFromRequest(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, db := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
request := httptest.NewRequest(http.MethodPost, "/apps", nil)
|
||||||
|
request.RemoteAddr = "10.0.0.1:12345"
|
||||||
|
|
||||||
|
svc.LogFromRequest(ctx, request, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionAppCreate,
|
||||||
|
ResourceType: models.AuditResourceApp,
|
||||||
|
ResourceID: "app-1",
|
||||||
|
Detail: "created app",
|
||||||
|
})
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(ctx, db, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.Equal(t, "10.0.0.1", entries[0].RemoteIP.String)
|
||||||
|
assert.Equal(t, "app-1", entries[0].ResourceID.String)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceLogFromRequestWithXRealIPTrustedProxy(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, db := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
// When the request comes from a trusted proxy (RFC1918), X-Real-IP is honoured.
|
||||||
|
request := httptest.NewRequest(http.MethodPost, "/apps", nil)
|
||||||
|
request.RemoteAddr = "10.0.0.1:1234"
|
||||||
|
request.Header.Set("X-Real-IP", "203.0.113.50")
|
||||||
|
|
||||||
|
svc.LogFromRequest(ctx, request, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionAppCreate,
|
||||||
|
ResourceType: models.AuditResourceApp,
|
||||||
|
})
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(ctx, db, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.Equal(t, "203.0.113.50", entries[0].RemoteIP.String)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceLogFromRequestWithXRealIPUntrustedProxy(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, db := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
// When the request comes from a public IP, X-Real-IP is ignored (anti-spoof).
|
||||||
|
request := httptest.NewRequest(http.MethodPost, "/apps", nil)
|
||||||
|
request.RemoteAddr = "203.0.113.99:1234"
|
||||||
|
request.Header.Set("X-Real-IP", "10.0.0.1")
|
||||||
|
|
||||||
|
svc.LogFromRequest(ctx, request, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionAppCreate,
|
||||||
|
ResourceType: models.AuditResourceApp,
|
||||||
|
})
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(ctx, db, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.Equal(t, "203.0.113.99", entries[0].RemoteIP.String)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceRecent(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, _ := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
for range 5 {
|
||||||
|
svc.Log(ctx, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionLogin,
|
||||||
|
ResourceType: models.AuditResourceSession,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
entries, err := svc.Recent(ctx, 3)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Len(t, entries, 3)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceForResource(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, _ := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
// Log entries for different resources.
|
||||||
|
svc.Log(ctx, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionAppCreate,
|
||||||
|
ResourceType: models.AuditResourceApp,
|
||||||
|
ResourceID: "app-1",
|
||||||
|
})
|
||||||
|
svc.Log(ctx, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionAppDeploy,
|
||||||
|
ResourceType: models.AuditResourceApp,
|
||||||
|
ResourceID: "app-1",
|
||||||
|
})
|
||||||
|
svc.Log(ctx, audit.LogEntry{
|
||||||
|
Username: "admin",
|
||||||
|
Action: models.AuditActionAppCreate,
|
||||||
|
ResourceType: models.AuditResourceApp,
|
||||||
|
ResourceID: "app-2",
|
||||||
|
})
|
||||||
|
|
||||||
|
entries, err := svc.ForResource(ctx, models.AuditResourceApp, "app-1", 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Len(t, entries, 2)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAuditServiceLogWithNoOptionalFields(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, db := setupTestAuditService(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
svc.Log(ctx, audit.LogEntry{
|
||||||
|
Username: "system",
|
||||||
|
Action: models.AuditActionWebhookReceive,
|
||||||
|
ResourceType: models.AuditResourceWebhook,
|
||||||
|
})
|
||||||
|
|
||||||
|
entries, err := models.FindAuditEntries(ctx, db, 10)
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.Len(t, entries, 1)
|
||||||
|
assert.False(t, entries[0].UserID.Valid)
|
||||||
|
assert.False(t, entries[0].ResourceID.Valid)
|
||||||
|
assert.False(t, entries[0].Detail.Valid)
|
||||||
|
assert.False(t, entries[0].RemoteIP.Valid)
|
||||||
|
}
|
||||||
@@ -21,6 +21,7 @@ import (
|
|||||||
"sneak.berlin/go/upaas/internal/database"
|
"sneak.berlin/go/upaas/internal/database"
|
||||||
"sneak.berlin/go/upaas/internal/docker"
|
"sneak.berlin/go/upaas/internal/docker"
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
"sneak.berlin/go/upaas/internal/models"
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
"sneak.berlin/go/upaas/internal/service/notify"
|
"sneak.berlin/go/upaas/internal/service/notify"
|
||||||
)
|
)
|
||||||
@@ -208,6 +209,7 @@ type ServiceParams struct {
|
|||||||
Database *database.Database
|
Database *database.Database
|
||||||
Docker *docker.Client
|
Docker *docker.Client
|
||||||
Notify *notify.Service
|
Notify *notify.Service
|
||||||
|
Metrics *metrics.Metrics
|
||||||
}
|
}
|
||||||
|
|
||||||
// activeDeploy tracks a running deployment so it can be cancelled.
|
// activeDeploy tracks a running deployment so it can be cancelled.
|
||||||
@@ -222,6 +224,7 @@ type Service struct {
|
|||||||
db *database.Database
|
db *database.Database
|
||||||
docker *docker.Client
|
docker *docker.Client
|
||||||
notify *notify.Service
|
notify *notify.Service
|
||||||
|
metrics *metrics.Metrics
|
||||||
config *config.Config
|
config *config.Config
|
||||||
params *ServiceParams
|
params *ServiceParams
|
||||||
activeDeploys sync.Map // map[string]*activeDeploy - per-app active deployment tracking
|
activeDeploys sync.Map // map[string]*activeDeploy - per-app active deployment tracking
|
||||||
@@ -235,6 +238,7 @@ func New(lc fx.Lifecycle, params ServiceParams) (*Service, error) {
|
|||||||
db: params.Database,
|
db: params.Database,
|
||||||
docker: params.Docker,
|
docker: params.Docker,
|
||||||
notify: params.Notify,
|
notify: params.Notify,
|
||||||
|
metrics: params.Metrics,
|
||||||
config: params.Config,
|
config: params.Config,
|
||||||
params: ¶ms,
|
params: ¶ms,
|
||||||
}
|
}
|
||||||
@@ -327,6 +331,11 @@ func (svc *Service) Deploy(
|
|||||||
}
|
}
|
||||||
defer svc.unlockApp(app.ID)
|
defer svc.unlockApp(app.ID)
|
||||||
|
|
||||||
|
// Track in-flight deployments
|
||||||
|
svc.metrics.DeploymentsInFlight.WithLabelValues(app.Name).Inc()
|
||||||
|
|
||||||
|
deployStart := time.Now()
|
||||||
|
|
||||||
// Set up cancellable context and register as active deploy
|
// Set up cancellable context and register as active deploy
|
||||||
deployCtx, cancel := context.WithCancel(ctx)
|
deployCtx, cancel := context.WithCancel(ctx)
|
||||||
done := make(chan struct{})
|
done := make(chan struct{})
|
||||||
@@ -334,6 +343,7 @@ func (svc *Service) Deploy(
|
|||||||
svc.activeDeploys.Store(app.ID, ad)
|
svc.activeDeploys.Store(app.ID, ad)
|
||||||
|
|
||||||
defer func() {
|
defer func() {
|
||||||
|
svc.metrics.DeploymentsInFlight.WithLabelValues(app.Name).Dec()
|
||||||
cancel()
|
cancel()
|
||||||
close(done)
|
close(done)
|
||||||
svc.activeDeploys.Delete(app.ID)
|
svc.activeDeploys.Delete(app.ID)
|
||||||
@@ -359,7 +369,7 @@ func (svc *Service) Deploy(
|
|||||||
|
|
||||||
svc.notify.NotifyBuildStart(bgCtx, app, deployment)
|
svc.notify.NotifyBuildStart(bgCtx, app, deployment)
|
||||||
|
|
||||||
return svc.runBuildAndDeploy(deployCtx, bgCtx, app, deployment)
|
return svc.runBuildAndDeploy(deployCtx, bgCtx, app, deployment, deployStart)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Rollback rolls back an app to its previous image.
|
// Rollback rolls back an app to its previous image.
|
||||||
@@ -467,15 +477,20 @@ func (svc *Service) runBuildAndDeploy(
|
|||||||
bgCtx context.Context,
|
bgCtx context.Context,
|
||||||
app *models.App,
|
app *models.App,
|
||||||
deployment *models.Deployment,
|
deployment *models.Deployment,
|
||||||
|
deployStart time.Time,
|
||||||
) error {
|
) error {
|
||||||
// Build phase with timeout
|
// Build phase with timeout
|
||||||
imageID, err := svc.buildImageWithTimeout(deployCtx, app, deployment)
|
imageID, err := svc.buildImageWithTimeout(deployCtx, app, deployment)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment, "")
|
cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment, "")
|
||||||
if cancelErr != nil {
|
if cancelErr != nil {
|
||||||
|
svc.recordDeployMetrics(app.Name, "cancelled", deployStart)
|
||||||
|
|
||||||
return cancelErr
|
return cancelErr
|
||||||
}
|
}
|
||||||
|
|
||||||
|
svc.recordDeployMetrics(app.Name, "failed", deployStart)
|
||||||
|
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -486,9 +501,13 @@ func (svc *Service) runBuildAndDeploy(
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment, imageID)
|
cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment, imageID)
|
||||||
if cancelErr != nil {
|
if cancelErr != nil {
|
||||||
|
svc.recordDeployMetrics(app.Name, "cancelled", deployStart)
|
||||||
|
|
||||||
return cancelErr
|
return cancelErr
|
||||||
}
|
}
|
||||||
|
|
||||||
|
svc.recordDeployMetrics(app.Name, "failed", deployStart)
|
||||||
|
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -504,11 +523,19 @@ func (svc *Service) runBuildAndDeploy(
|
|||||||
|
|
||||||
// Use context.WithoutCancel to ensure health check completes even if
|
// Use context.WithoutCancel to ensure health check completes even if
|
||||||
// the parent context is cancelled (e.g., HTTP request ends).
|
// the parent context is cancelled (e.g., HTTP request ends).
|
||||||
go svc.checkHealthAfterDelay(bgCtx, app, deployment)
|
go svc.checkHealthAfterDelay(bgCtx, app, deployment, deployStart)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// recordDeployMetrics records deployment completion metrics.
|
||||||
|
func (svc *Service) recordDeployMetrics(appName, status string, start time.Time) {
|
||||||
|
duration := time.Since(start).Seconds()
|
||||||
|
|
||||||
|
svc.metrics.DeploymentsTotal.WithLabelValues(appName, status).Inc()
|
||||||
|
svc.metrics.DeploymentDuration.WithLabelValues(appName, status).Observe(duration)
|
||||||
|
}
|
||||||
|
|
||||||
// buildImageWithTimeout runs the build phase with a timeout.
|
// buildImageWithTimeout runs the build phase with a timeout.
|
||||||
func (svc *Service) buildImageWithTimeout(
|
func (svc *Service) buildImageWithTimeout(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
@@ -1094,11 +1121,6 @@ func (svc *Service) buildContainerOptions(
|
|||||||
network = app.DockerNetwork.String
|
network = app.DockerNetwork.String
|
||||||
}
|
}
|
||||||
|
|
||||||
healthcheckCmd := ""
|
|
||||||
if app.HealthcheckCommand.Valid {
|
|
||||||
healthcheckCmd = app.HealthcheckCommand.String
|
|
||||||
}
|
|
||||||
|
|
||||||
return docker.CreateContainerOptions{
|
return docker.CreateContainerOptions{
|
||||||
Name: "upaas-" + app.Name,
|
Name: "upaas-" + app.Name,
|
||||||
Image: imageID.String(),
|
Image: imageID.String(),
|
||||||
@@ -1107,7 +1129,6 @@ func (svc *Service) buildContainerOptions(
|
|||||||
Volumes: buildVolumeMounts(volumes),
|
Volumes: buildVolumeMounts(volumes),
|
||||||
Ports: buildPortMappings(ports),
|
Ports: buildPortMappings(ports),
|
||||||
Network: network,
|
Network: network,
|
||||||
HealthcheckCommand: healthcheckCmd,
|
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1169,6 +1190,7 @@ func (svc *Service) checkHealthAfterDelay(
|
|||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
app *models.App,
|
app *models.App,
|
||||||
deployment *models.Deployment,
|
deployment *models.Deployment,
|
||||||
|
deployStart time.Time,
|
||||||
) {
|
) {
|
||||||
svc.log.Info(
|
svc.log.Info(
|
||||||
"waiting 60 seconds to check container health",
|
"waiting 60 seconds to check container health",
|
||||||
@@ -1195,6 +1217,8 @@ func (svc *Service) checkHealthAfterDelay(
|
|||||||
svc.notify.NotifyDeployFailed(ctx, reloadedApp, deployment, err)
|
svc.notify.NotifyDeployFailed(ctx, reloadedApp, deployment, err)
|
||||||
_ = deployment.MarkFinished(ctx, models.DeploymentStatusFailed)
|
_ = deployment.MarkFinished(ctx, models.DeploymentStatusFailed)
|
||||||
svc.writeLogsToFile(reloadedApp, deployment)
|
svc.writeLogsToFile(reloadedApp, deployment)
|
||||||
|
svc.recordDeployMetrics(reloadedApp.Name, "failed", deployStart)
|
||||||
|
svc.metrics.ContainerHealthy.WithLabelValues(reloadedApp.Name).Set(0)
|
||||||
reloadedApp.Status = models.AppStatusError
|
reloadedApp.Status = models.AppStatusError
|
||||||
_ = reloadedApp.Save(ctx)
|
_ = reloadedApp.Save(ctx)
|
||||||
|
|
||||||
@@ -1206,6 +1230,8 @@ func (svc *Service) checkHealthAfterDelay(
|
|||||||
svc.notify.NotifyDeploySuccess(ctx, reloadedApp, deployment)
|
svc.notify.NotifyDeploySuccess(ctx, reloadedApp, deployment)
|
||||||
_ = deployment.MarkFinished(ctx, models.DeploymentStatusSuccess)
|
_ = deployment.MarkFinished(ctx, models.DeploymentStatusSuccess)
|
||||||
svc.writeLogsToFile(reloadedApp, deployment)
|
svc.writeLogsToFile(reloadedApp, deployment)
|
||||||
|
svc.recordDeployMetrics(reloadedApp.Name, "success", deployStart)
|
||||||
|
svc.metrics.ContainerHealthy.WithLabelValues(reloadedApp.Name).Set(1)
|
||||||
} else {
|
} else {
|
||||||
svc.log.Warn(
|
svc.log.Warn(
|
||||||
"container unhealthy after 60 seconds",
|
"container unhealthy after 60 seconds",
|
||||||
@@ -1214,6 +1240,8 @@ func (svc *Service) checkHealthAfterDelay(
|
|||||||
svc.notify.NotifyDeployFailed(ctx, reloadedApp, deployment, ErrContainerUnhealthy)
|
svc.notify.NotifyDeployFailed(ctx, reloadedApp, deployment, ErrContainerUnhealthy)
|
||||||
_ = deployment.MarkFinished(ctx, models.DeploymentStatusFailed)
|
_ = deployment.MarkFinished(ctx, models.DeploymentStatusFailed)
|
||||||
svc.writeLogsToFile(reloadedApp, deployment)
|
svc.writeLogsToFile(reloadedApp, deployment)
|
||||||
|
svc.recordDeployMetrics(reloadedApp.Name, "failed", deployStart)
|
||||||
|
svc.metrics.ContainerHealthy.WithLabelValues(reloadedApp.Name).Set(0)
|
||||||
reloadedApp.Status = models.AppStatusError
|
reloadedApp.Status = models.AppStatusError
|
||||||
_ = reloadedApp.Save(ctx)
|
_ = reloadedApp.Save(ctx)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,7 +2,6 @@ package deploy_test
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"database/sql"
|
|
||||||
"log/slog"
|
"log/slog"
|
||||||
"os"
|
"os"
|
||||||
"testing"
|
"testing"
|
||||||
@@ -44,64 +43,3 @@ func TestBuildContainerOptionsUsesImageID(t *testing.T) {
|
|||||||
t.Errorf("expected Name=%q, got %q", "upaas-myapp", opts.Name)
|
t.Errorf("expected Name=%q, got %q", "upaas-myapp", opts.Name)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildContainerOptionsHealthcheckSet(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
db := database.NewTestDatabase(t)
|
|
||||||
|
|
||||||
app := models.NewApp(db)
|
|
||||||
app.Name = "hc-app"
|
|
||||||
app.HealthcheckCommand = sql.NullString{
|
|
||||||
String: "curl -f http://localhost:8080/healthz || exit 1",
|
|
||||||
Valid: true,
|
|
||||||
}
|
|
||||||
|
|
||||||
err := app.Save(context.Background())
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("failed to save app: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
log := slog.New(slog.NewTextHandler(os.Stderr, nil))
|
|
||||||
svc := deploy.NewTestService(log)
|
|
||||||
|
|
||||||
opts, err := svc.BuildContainerOptionsExported(
|
|
||||||
context.Background(), app, "sha256:test",
|
|
||||||
)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("buildContainerOptions returned error: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
expected := "curl -f http://localhost:8080/healthz || exit 1"
|
|
||||||
if opts.HealthcheckCommand != expected {
|
|
||||||
t.Errorf("expected HealthcheckCommand=%q, got %q", expected, opts.HealthcheckCommand)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestBuildContainerOptionsHealthcheckEmpty(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
db := database.NewTestDatabase(t)
|
|
||||||
|
|
||||||
app := models.NewApp(db)
|
|
||||||
app.Name = "no-hc-app"
|
|
||||||
|
|
||||||
err := app.Save(context.Background())
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("failed to save app: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
log := slog.New(slog.NewTextHandler(os.Stderr, nil))
|
|
||||||
svc := deploy.NewTestService(log)
|
|
||||||
|
|
||||||
opts, err := svc.BuildContainerOptionsExported(
|
|
||||||
context.Background(), app, "sha256:test",
|
|
||||||
)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("buildContainerOptions returned error: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
if opts.HealthcheckCommand != "" {
|
|
||||||
t.Errorf("expected empty HealthcheckCommand, got %q", opts.HealthcheckCommand)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -7,12 +7,14 @@ import (
|
|||||||
"encoding/json"
|
"encoding/json"
|
||||||
"fmt"
|
"fmt"
|
||||||
"log/slog"
|
"log/slog"
|
||||||
|
"strconv"
|
||||||
|
|
||||||
"go.uber.org/fx"
|
"go.uber.org/fx"
|
||||||
|
|
||||||
"sneak.berlin/go/upaas/internal/database"
|
"sneak.berlin/go/upaas/internal/database"
|
||||||
|
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
"sneak.berlin/go/upaas/internal/models"
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
"sneak.berlin/go/upaas/internal/service/deploy"
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
||||||
)
|
)
|
||||||
@@ -24,6 +26,7 @@ type ServiceParams struct {
|
|||||||
Logger *logger.Logger
|
Logger *logger.Logger
|
||||||
Database *database.Database
|
Database *database.Database
|
||||||
Deploy *deploy.Service
|
Deploy *deploy.Service
|
||||||
|
Metrics *metrics.Metrics
|
||||||
}
|
}
|
||||||
|
|
||||||
// Service provides webhook handling functionality.
|
// Service provides webhook handling functionality.
|
||||||
@@ -31,6 +34,7 @@ type Service struct {
|
|||||||
log *slog.Logger
|
log *slog.Logger
|
||||||
db *database.Database
|
db *database.Database
|
||||||
deploy *deploy.Service
|
deploy *deploy.Service
|
||||||
|
metrics *metrics.Metrics
|
||||||
params *ServiceParams
|
params *ServiceParams
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -40,6 +44,7 @@ func New(_ fx.Lifecycle, params ServiceParams) (*Service, error) {
|
|||||||
log: params.Logger.Get(),
|
log: params.Logger.Get(),
|
||||||
db: params.Database,
|
db: params.Database,
|
||||||
deploy: params.Deploy,
|
deploy: params.Deploy,
|
||||||
|
metrics: params.Metrics,
|
||||||
params: ¶ms,
|
params: ¶ms,
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
@@ -122,6 +127,10 @@ func (svc *Service) HandleWebhook(
|
|||||||
"commit", commitSHA,
|
"commit", commitSHA,
|
||||||
)
|
)
|
||||||
|
|
||||||
|
svc.metrics.WebhookEventsTotal.WithLabelValues(
|
||||||
|
app.Name, eventType, strconv.FormatBool(matched),
|
||||||
|
).Inc()
|
||||||
|
|
||||||
// If branch matches, trigger deployment
|
// If branch matches, trigger deployment
|
||||||
if matched {
|
if matched {
|
||||||
svc.triggerDeployment(ctx, app, event)
|
svc.triggerDeployment(ctx, app, event)
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"github.com/prometheus/client_golang/prometheus"
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/stretchr/testify/assert"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
"go.uber.org/fx"
|
"go.uber.org/fx"
|
||||||
@@ -17,6 +18,7 @@ import (
|
|||||||
"sneak.berlin/go/upaas/internal/docker"
|
"sneak.berlin/go/upaas/internal/docker"
|
||||||
"sneak.berlin/go/upaas/internal/globals"
|
"sneak.berlin/go/upaas/internal/globals"
|
||||||
"sneak.berlin/go/upaas/internal/logger"
|
"sneak.berlin/go/upaas/internal/logger"
|
||||||
|
"sneak.berlin/go/upaas/internal/metrics"
|
||||||
"sneak.berlin/go/upaas/internal/models"
|
"sneak.berlin/go/upaas/internal/models"
|
||||||
"sneak.berlin/go/upaas/internal/service/deploy"
|
"sneak.berlin/go/upaas/internal/service/deploy"
|
||||||
"sneak.berlin/go/upaas/internal/service/notify"
|
"sneak.berlin/go/upaas/internal/service/notify"
|
||||||
@@ -63,13 +65,17 @@ func setupTestService(t *testing.T) (*webhook.Service, *database.Database, func(
|
|||||||
notifySvc, err := notify.New(fx.Lifecycle(nil), notify.ServiceParams{Logger: deps.logger})
|
notifySvc, err := notify.New(fx.Lifecycle(nil), notify.ServiceParams{Logger: deps.logger})
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
metricsInstance := metrics.NewForTest(prometheus.NewRegistry())
|
||||||
|
|
||||||
deploySvc, err := deploy.New(fx.Lifecycle(nil), deploy.ServiceParams{
|
deploySvc, err := deploy.New(fx.Lifecycle(nil), deploy.ServiceParams{
|
||||||
Logger: deps.logger, Config: deps.config, Database: deps.db, Docker: dockerClient, Notify: notifySvc,
|
Logger: deps.logger, Config: deps.config, Database: deps.db, Docker: dockerClient, Notify: notifySvc,
|
||||||
|
Metrics: metricsInstance,
|
||||||
})
|
})
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
svc, err := webhook.New(fx.Lifecycle(nil), webhook.ServiceParams{
|
svc, err := webhook.New(fx.Lifecycle(nil), webhook.ServiceParams{
|
||||||
Logger: deps.logger, Database: deps.db, Deploy: deploySvc,
|
Logger: deps.logger, Database: deps.db, Deploy: deploySvc,
|
||||||
|
Metrics: metricsInstance,
|
||||||
})
|
})
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
|||||||
@@ -114,19 +114,6 @@
|
|||||||
>
|
>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div class="form-group">
|
|
||||||
<label for="healthcheck_command" class="label">Health Check Command</label>
|
|
||||||
<input
|
|
||||||
type="text"
|
|
||||||
id="healthcheck_command"
|
|
||||||
name="healthcheck_command"
|
|
||||||
value="{{if .App.HealthcheckCommand.Valid}}{{.App.HealthcheckCommand.String}}{{end}}"
|
|
||||||
class="input font-mono"
|
|
||||||
placeholder="curl -f http://localhost:8080/healthz || exit 1"
|
|
||||||
>
|
|
||||||
<p class="text-sm text-gray-500 mt-1">Custom shell command to check container health. Leave empty to use the image's default health check.</p>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div class="flex justify-end gap-3 pt-4">
|
<div class="flex justify-end gap-3 pt-4">
|
||||||
<a href="/apps/{{.App.ID}}" class="btn-secondary">Cancel</a>
|
<a href="/apps/{{.App.ID}}" class="btn-secondary">Cancel</a>
|
||||||
<button type="submit" class="btn-primary">Save Changes</button>
|
<button type="submit" class="btn-primary">Save Changes</button>
|
||||||
|
|||||||
@@ -117,19 +117,6 @@
|
|||||||
>
|
>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div class="form-group">
|
|
||||||
<label for="healthcheck_command" class="label">Health Check Command</label>
|
|
||||||
<input
|
|
||||||
type="text"
|
|
||||||
id="healthcheck_command"
|
|
||||||
name="healthcheck_command"
|
|
||||||
value="{{.HealthcheckCommand}}"
|
|
||||||
class="input font-mono"
|
|
||||||
placeholder="curl -f http://localhost:8080/healthz || exit 1"
|
|
||||||
>
|
|
||||||
<p class="text-sm text-gray-500 mt-1">Custom shell command to check container health. Leave empty to use the image's default health check.</p>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div class="flex justify-end gap-3 pt-4">
|
<div class="flex justify-end gap-3 pt-4">
|
||||||
<a href="/" class="btn-secondary">Cancel</a>
|
<a href="/" class="btn-secondary">Cancel</a>
|
||||||
<button type="submit" class="btn-primary">Create App</button>
|
<button type="submit" class="btn-primary">Create App</button>
|
||||||
|
|||||||
Reference in New Issue
Block a user