7 Commits

Include renames

Author	SHA1	Message	Date
clawbot	7e8aa67afd	Tag built images with the commit's short hash (closes #239) ... Builds are tagged upaas-<app>:<short hash>, git's own short form of the commit checked out, instead of the deployment number. A redeploy of a commit gives the tag to the new image. The cleanup after a deploy now also finds the app's untagged images among those its deployments recorded, and removes them by ID once the app neither runs them nor would roll back to them. It keeps every image any app uses, since apps that build the same commit can share one. The clone reads the commits from git's output after removing Docker's log headers, which had hidden the COMMIT: line; commit_sha is now saved on update so manual deploys keep the commit they recorded. Model: opus-5-5	2026-09-29 11:13:03 +00:00
clawbotandsneak	7a34fc999c	Update golangci-lint to v2.12.2 with canonical config (#187) ... Bumps golangci-lint from v2.10.1 to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then fixes every finding the new linter surfaces so `make check` is green. ## Version pins - `Dockerfile` lint stage: `golangci/golangci-lint:v2.12.2` (Debian-based), tag plus digest pin - `script/bootstrap`: `GOLANGCI_LINT_VERSION=2.12.2` with updated `linux-amd64`/`linux-arm64` release-archive sha256 pins ## Config `.golangci.yml` replaced with the canonical config. Material change: the old file declared `version: "2"` but kept settings under the legacy top-level `linters-settings` key, which golangci-lint v2 ignores — so the intended thresholds (`lll` 88, `funlen` 80/50, `cyclop` 15, `dupl` 100) were not being applied. The canonical file moves them under `linters.settings` and drops `issues.exclude-use-default`. ## Lint fixes (216 findings) - `lll` (96): wrapped lines to the 88-column limit - `noctx` (46): `httptest.NewRequestWithContext` with `t.Context()` throughout the tests - `goconst` (24): shared constants for template/JSON keys in `internal/handlers` and repeated test literals - `gosec` (23): app-page redirects now go through a `redirectToApp` helper that path-escapes the app ID (G710 open redirect); `http.ServeFile` of the internally derived deployment log path annotated like the adjacent `os.Stat` (G703) - `dupl` (22): extracted a generic `findAllByAppID` in `internal/models`, a `deleteAppResource` helper in `internal/handlers`, a shared `parsePush` in `internal/service/webhook`, and table-driven/helper-based dedup in tests - `nolintlint` (5): removed `//nolint:funlen` directives made obsolete by the new limits (plus one more that became obsolete after refactoring) - `nilerr` (3, surfaced during fixing): resource-delete lookups now propagate the find error to the caller No behavior changes intended; all tests pass and `make check` is green. Note: golangci-lint v2.12 warns that `gomodguard` is deprecated in favor of `gomodguard_v2` — a future canonical-config update should address this centrally. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #187 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>	2026-08-07 22:21:42 +02:00
3 people	12446f9f79	fix: change module path to sneak.berlin/go/upaas (closes #143) (#149) ... Changes the Go module path from `git.eeqj.de/sneak/upaas` to `sneak.berlin/go/upaas`. All import paths in Go files updated accordingly. `go mod tidy` and `make check` pass cleanly. fixes #143 Co-authored-by: user <user@Mac.lan guest wan> Co-authored-by: Jeffrey Paul <sneak@noreply.example.org> Reviewed-on: #149 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>	2026-03-01 23:22:18 +01:00
clawbot	0fcf12d2cc	fix: resolve all lint issues on main branch ... - funcorder: reorder RemoveImage before unexported methods in docker/client.go - gosec G117: add json:"-" tags to SessionSecret and PrivateKey fields - gosec G117: replace login struct with map to avoid secret pattern match - gosec G705: add #nosec for text/plain XSS false positive - gosec G703: add #nosec for internal path traversal false positive - gosec G704: validate URLs and add #nosec for config-sourced SSRF false positives - gosec G306: use 0o600 permissions in test file - revive: rename unused parameters to _ - wsl_v5: add missing blank line before assignment	2026-02-20 02:39:18 -08:00
clawbot	728b29ef16	Revert "Merge pull request 'feat: add Gitea Actions CI for make check (closes #96)' (#98) from feat/ci-make-check into main" ... This reverts commit f61d4d0f91, reversing changes made to 06e8e66443.	2026-02-19 20:36:22 -08:00
clawbot	8ec04fdadb	feat: add Gitea Actions CI for make check (closes #96) ... - Add .gitea/workflows/check.yml running make check on PRs and pushes to main - Fix .golangci.yml for golangci-lint v2 config format (was using v1 keys) - Migrate linters-settings to linters.settings, remove deprecated exclude-use-default - Exclude gosec false positives (G117, G703, G704, G705) with documented rationale - Increase lll line-length from 88 to 120 (88 was too restrictive for idiomatic Go) - Increase dupl threshold from 100 to 150 (similar CRUD handlers are intentional) - Fix funcorder: move RemoveImage before unexported methods in docker/client.go - Fix wsl_v5: add required blank line in deploy.go - Fix revive unused-parameter in export_test.go - Fix gosec G306: tighten test file permissions to 0600 - Add html.EscapeString for log output, filepath.Clean for log path - Remove stale //nolint:funlen directives no longer needed with v2 config	2026-02-19 20:29:21 -08:00
clawbot	802518b917	fix: clean up orphan resources on deploy cancellation (closes #89)	2026-02-19 20:15:22 -08:00