Fix repository cloning when running inside a container

Use DataDir/builds instead of /tmp for clone directories so that bind
mounts work correctly when upaas itself runs in a Docker container.
The /tmp directory inside the upaas container isn't accessible to the
Docker daemon on the host, causing bind mount failures.

Also fix test setups to pass Config to deploy service and add delay
to webhook test to avoid temp directory cleanup race with async
deployment goroutine.

internal/handlers/handlers_test.go

@@ -7,6 +7,7 @@ import (
 	"net/url"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/go-chi/chi/v5"
 	"github.com/stretchr/testify/assert"
@@ -115,6 +116,7 @@ func createAppServices(
 
 	deploySvc, deployErr := deploy.New(fx.Lifecycle(nil), deploy.ServiceParams{
 		Logger:   logInstance,
+		Config:   cfg,
 		Database: dbInstance,
 		Docker:   dockerClient,
 		Notify:   notifySvc,
@@ -484,4 +486,9 @@ func TestHandleWebhookProcessesValidWebhook(t *testing.T) {
 	handler.ServeHTTP(recorder, request)
 
 	assert.Equal(t, http.StatusOK, recorder.Code)
+
+	// Allow async deployment goroutine to complete before test cleanup.
+	// The deployment will fail quickly (docker not connected) but we need
+	// to wait for it to finish to avoid temp directory cleanup race.
+	time.Sleep(100 * time.Millisecond)
 }