fix: move writeLogsToFile doc comment to correct position
All checks were successful
Check / check (pull_request) Successful in 3m16s
All checks were successful
Check / check (pull_request) Successful in 3m16s
The buildRegistryAuths function was inserted between the writeLogsToFile doc comment and the writeLogsToFile function body, causing Go to treat the writeLogsToFile comment as part of buildRegistryAuths godoc. Move the writeLogsToFile comment to sit directly above its function, and keep only the buildRegistryAuths comment above buildRegistryAuths.
This commit is contained in:
@@ -1235,8 +1235,6 @@ func (svc *Service) failDeployment(
|
||||
_ = app.Save(ctx)
|
||||
}
|
||||
|
||||
// writeLogsToFile writes the deployment logs to a file on disk.
|
||||
// Structure: DataDir/logs/<hostname>/<appname>/<appname>_<sha>_<timestamp>.log.txt
|
||||
// buildRegistryAuths fetches registry credentials for an app and converts them
|
||||
// to Docker RegistryAuth objects for use during image builds.
|
||||
func (svc *Service) buildRegistryAuths(
|
||||
@@ -1265,6 +1263,8 @@ func (svc *Service) buildRegistryAuths(
|
||||
return auths, nil
|
||||
}
|
||||
|
||||
// writeLogsToFile writes the deployment logs to a file on disk.
|
||||
// Structure: DataDir/logs/<hostname>/<appname>/<appname>_<sha>_<timestamp>.log.txt
|
||||
func (svc *Service) writeLogsToFile(app *models.App, deployment *models.Deployment) {
|
||||
if !deployment.Logs.Valid || deployment.Logs.String == "" {
|
||||
return
|
||||
|
||||
Reference in New Issue
Block a user