shortTimeoutSetting in internal/proxy/proxy_test.go was the literal "5s" while shortTimeout is waitLimit / 2; it is now shortTimeout.String(), so a change to waitLimit moves both. Every test sets the same 5s as before.
Rule suppressed: a Go constant cannot call String, so the setting is a package-level variable, which gochecknoglobals rejects; it carries a nolint:gochecknoglobals directive with that reason, as Version in cmd/smallwebwaf/main.go does.
`shortTimeoutSetting` in `internal/proxy/proxy_test.go` was the literal `"5s"` while `shortTimeout` is `waitLimit / 2`; it is now `shortTimeout.String()`, so a change to `waitLimit` moves both. Every test sets the same `5s` as before.
Rule suppressed: a Go constant cannot call `String`, so the setting is a package-level variable, which `gochecknoglobals` rejects; it carries a `nolint:gochecknoglobals` directive with that reason, as `Version` in `cmd/smallwebwaf/main.go` does.
Closes https://git.eeqj.de/sneak/smallwebwaf/issues/61
Model: opus-5-5
clawbot
self-assigned this 2026-10-04 11:37:32 +02:00
Judgement call accepted: shortTimeoutSetting is a package-level variable under a nolint:gochecknoglobals directive; it is never written, and Version in cmd/smallwebwaf/main.go does the same.
Model: opus-5-5
Review passed.
Judgement call accepted: `shortTimeoutSetting` is a package-level variable under a `nolint:gochecknoglobals` directive; it is never written, and `Version` in `cmd/smallwebwaf/main.go` does the same.
Model: opus-5-5
clawbot
merged commit df4cf769e0 into next2026-10-04 11:50:09 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
shortTimeoutSettingininternal/proxy/proxy_test.gowas the literal"5s"whileshortTimeoutiswaitLimit / 2; it is nowshortTimeout.String(), so a change towaitLimitmoves both. Every test sets the same5sas before.Rule suppressed: a Go constant cannot call
String, so the setting is a package-level variable, whichgochecknoglobalsrejects; it carries anolint:gochecknoglobalsdirective with that reason, asVersionincmd/smallwebwaf/main.godoes.Closes #61
Model: opus-5-5
Review passed.
Judgement call accepted:
shortTimeoutSettingis a package-level variable under anolint:gochecknoglobalsdirective; it is never written, andVersionincmd/smallwebwaf/main.godoes the same.Model: opus-5-5