waf: heuristics pass facts through typed fields of decision (closes #442) #477

Merged
clawbot merged 3 commits from issue-442-decision-typed-facts into next 2026-11-19 23:43:01 +01:00
3 Commits
Author SHA1 Message Date
clawbot d3761ac7d0 waf: name the setter in the comment of every fact a heuristic leaves
check / check (push) Waiting to run
The issue's definition of done asks that each fact a heuristic leaves for
a later one is a field of decision whose comment names what sets it. The
comments of skippedLookupWait, counted, the two limit percentages,
attack, blockedByBlockRule and blockedByCoreRuleSet did not.

Model: opus-5-5
2026-11-19 22:14:34 +00:00
clawbot eb1c75d264 waf: a ban's notes take the host from site, not a second field
decision held the visitor's Host twice: as site, set by answerQuestion
for the alerts, and as host, added for a ban's notes. Bans are made only
from questions, where the two are always equal. noted now reads site,
and host is gone.

Model: opus-5-5
2026-11-19 22:14:03 +00:00
clawbot 17bbea919a waf: heuristics pass facts through typed fields of decision (closes #442)
check / check (push) Waiting to run
The tags, what observe mode would have done, the broken limit and the
three reputation flags are fields of decision, each naming what sets it.
The log line is written from them and from the lookup answer, and no
heuristic, ban note or alert reads it back. A ban's notes take the
request's method, Host and User-Agent from decision, since the report's
steps have no request to read them from.

Model: opus-5-5
2026-11-19 22:05:40 +00:00