waf: each heuristic holds its own settings and parts (closes #441) #462
Open
clawbot
wants to merge 1 commits from
issue-441-heuristic-structs into next
pull from: issue-441-heuristic-structs
merge into: sneak:next
sneak:main
sneak:issue-447-config-above-the-parts
sneak:next
sneak:issue-448-config-setting-name-constants
sneak:issue-438-metrics-params
sneak:issue-426-chi-routes
sneak:issue-440-cobra-commands
sneak:issue-425-wafprotocol-package
sneak:issue-428-named-value-types
sneak:issue-439-stop-asks-at-stop
sneak:issue-429-dirwatch
sneak:issue-436-server-exports-no-parts
sneak:issue-434-core-rule-set-in-sww
sneak:issue-430-app-fixes-directory
sneak:issue-431-body-wrapper-fields
sneak:issue-433-report-goroutines
sneak:issue-427-typed-fixed-value-settings
sneak:issue-411-abuseipdb-blacklist
sneak:issue-414-fx-wiring
sneak:issue-420-tests-under-load
sneak:issue-381-compose-waf-settings
sneak:issue-412-anomaly-alert-only
sneak:issue-418-test-time-limits
sneak:issue-415-header-limit-test
sneak:issue-406-parallel-tests
sneak:issue-405-decide-beside-lookup
sneak:issue-404-geojs-package
sneak:issue-401-one-cookie-line
sneak:issue-400-coreruleset-timing-ref
sneak:issue-398-breaker-test-without-questions
sneak:issue-400-coreruleset-timing
sneak:issue-396-no-own-hosts
sneak:issue-394-decide-in-time
sneak:issue-392-rproxy-circuit-breaker
sneak:issue-388-any-tls-proxy
sneak:issue-386-readme-rproxy-alone
sneak:issue-387-readme-scraper-policy
sneak:issue-339-long-line-limits
sneak:issue-379-lookup-headers-by-default
sneak:issue-315-remove-crowdsec
sneak:issue-354-package-registry-searches
sneak:issue-353-api-searches
sneak:issue-234-rename-settings
sneak:issue-359-ghost-remaining-fields
sneak:issue-373-read-rest-after-connection-close
sneak:issue-374-ghost-canonical-url
sneak:issue-371-body-over-limit-test-reset
sneak:issue-358-ghost-scripts
sneak:issue-211-viper-config
sneak:issue-357-ghost
sneak:issue-346-names-in-bodies
sneak:issue-365-adopt-form-repository-names
sneak:issue-220-apps-by-hostname
sneak:issue-352-shared-searches
sneak:issue-215-golines
sneak:issue-227-settings-file-per-daemon
sneak:issue-350-forgejo-searches
sneak:issue-349-gitea-user-page-ls
sneak:issue-287-crs-test-cpu
sneak:issue-284-wordpress-recorded-both-ways
sneak:readme-rewrite-155
No Reviewers
Labels
Clear labels
critical
merge-ready
needs-checks
needs-decision
needs-decision
needs-decision
needs-rebase
needs-review
needs-rework
not-one-pr
post-1.0
red-next
Extremely important: data loss, a security hole, production down, or basic use impossible
Reviewed and ready for the owner to merge
Checks must be fixed before review
Waits on an owner decision
Waiting on a decision by the owner
Conflicts with next; rebase required
Review not yet done
Review found issues to fix
No labels
needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/smallwebwaf#462
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #441
Each heuristic is a struct that
newHandlerbuilds once with the settings and parts it reads. Nocheckreadsrq.h. The six lists are handler fields.headerLimitsstays empty: its limits are constants.Things the diff does not make obvious:
clientGroupandbanNetblocktake the prefix lengths instead of*config.WAF, so the steps that are not heuristics passh.configfields.blocklists,rateLimits,trapPaths,ruleFilesandcoreRuleSetare also handler fields.refusedWhateverTheAnswerandfindBesideLookupuse those same built values.NewreadsLists,DNSBL,AbuseIPDBandRouteWatchfrom its params. The handler no longer holds them, norrules,alertsor the Core Rule Set inspector.newHandlercarries//nolint:funlenas a list that grows with the heuristics, asconfigandmetricsalready do.New types:
banMaker: makes the bans of the heuristics that ban, and raises their alerts. Fields:ledger,limiter,metrics,alerts,observe,banResponse,banScopeV4Prefix,ipv6GroupPrefix.reputationHitNoter: notes the reputation sources that list a client. Fields:metrics,alerts,ipv6GroupPrefix.biasedThresholds: the settings and listslimitPercentageslowers limits by. Fields:lists,tagLimitPercent,asnBytesLimitPercent,countryBytesLimitPercent,unknownCountryLimitPercent,blocklistAction,blocklistLimitPercent,dnsblAbuseIPDBAction,dnsblAbuseIPDBLimitPercent.New heuristic fields. Each setting field is commented with its variable name:
denyNets.netblocks,tagLists.lists,routeWatchTags.routeWatch,countries.allowed,tagDeny.tags,trapPaths.pathsblocklists:lists,action,hitNoterdnsbl:dnsbl,action,hitNoterabuseIPDB:abuseIPDB,limiter,keySet,minScore,action,hitNoterrateLimits:limiter,exemptNets,exemptPaths,banResponse,biasedThresholdsrefusalLimit:limiter,perMinute,banResponsebyteLimits:limiter,bytesCountedruleFiles:rules,metricscoreRuleSet:inspector,metrics,alerts,mode,exemptPaths,scoreThreshold,observebanMakeronactiveBan,rateLimits,trapPaths,ruleFiles,refusalLimitandbyteLimits.ipv6GroupPrefixon every heuristic that computes a client group.Model: opus-5-5
Verdict: PASS
Head:
ce87531fecEvery heuristic now holds its own settings and parts, no
checkreads the handler, the six lists are built once innewHandler, and no existing test changed, which meets the definition of done of #441.//nolint:funlenonnewHandler, as onconfigandmetrics.Model: opus-5-5
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.