sww: the three commands as cobra commands (closes #440) #460
Open
clawbot
wants to merge 2 commits from
issue-440-cobra-commands into next
pull from: issue-440-cobra-commands
merge into: sneak:next
sneak:main
sneak:next
sneak:issue-426-chi-routes
sneak:issue-441-heuristic-structs
sneak:issue-425-wafprotocol-package
sneak:issue-428-named-value-types
sneak:issue-439-stop-asks-at-stop
sneak:issue-429-dirwatch
sneak:issue-438-metrics-params
sneak:issue-436-server-exports-no-parts
sneak:issue-434-core-rule-set-in-sww
sneak:issue-430-app-fixes-directory
sneak:issue-431-body-wrapper-fields
sneak:issue-433-report-goroutines
sneak:issue-427-typed-fixed-value-settings
sneak:issue-411-abuseipdb-blacklist
sneak:issue-414-fx-wiring
sneak:issue-420-tests-under-load
sneak:issue-381-compose-waf-settings
sneak:issue-412-anomaly-alert-only
sneak:issue-418-test-time-limits
sneak:issue-415-header-limit-test
sneak:issue-406-parallel-tests
sneak:issue-405-decide-beside-lookup
sneak:issue-404-geojs-package
sneak:issue-401-one-cookie-line
sneak:issue-400-coreruleset-timing-ref
sneak:issue-398-breaker-test-without-questions
sneak:issue-400-coreruleset-timing
sneak:issue-396-no-own-hosts
sneak:issue-394-decide-in-time
sneak:issue-392-rproxy-circuit-breaker
sneak:issue-388-any-tls-proxy
sneak:issue-386-readme-rproxy-alone
sneak:issue-387-readme-scraper-policy
sneak:issue-339-long-line-limits
sneak:issue-379-lookup-headers-by-default
sneak:issue-315-remove-crowdsec
sneak:issue-354-package-registry-searches
sneak:issue-353-api-searches
sneak:issue-234-rename-settings
sneak:issue-359-ghost-remaining-fields
sneak:issue-373-read-rest-after-connection-close
sneak:issue-374-ghost-canonical-url
sneak:issue-371-body-over-limit-test-reset
sneak:issue-358-ghost-scripts
sneak:issue-211-viper-config
sneak:issue-357-ghost
sneak:issue-346-names-in-bodies
sneak:issue-365-adopt-form-repository-names
sneak:issue-220-apps-by-hostname
sneak:issue-352-shared-searches
sneak:issue-215-golines
sneak:issue-227-settings-file-per-daemon
sneak:issue-350-forgejo-searches
sneak:issue-349-gitea-user-page-ls
sneak:issue-287-crs-test-cpu
sneak:issue-284-wordpress-recorded-both-ways
sneak:readme-rewrite-155
No Reviewers
Labels
Clear labels
critical
merge-ready
needs-checks
needs-decision
needs-decision
needs-decision
needs-rebase
needs-review
needs-rework
not-one-pr
post-1.0
red-next
Extremely important: data loss, a security hole, production down, or basic use impossible
Reviewed and ready for the owner to merge
Checks must be fixed before review
Waits on an owner decision
Waiting on a decision by the owner
Conflicts with next; rebase required
Review not yet done
Review found issues to fix
No labels
needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/smallwebwaf#460
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #440
sww.Mainnow builds acobraroot command withrproxy,wafandhealthcheckunder it. The switch onos.Argsand the hand-kept usage text are gone;cobraprints the commands from theirShortdescriptions.Runstores whatRunRProxy,RunWAForHealthCheckreturns, andMainreturns that. The commands useRun, notRunE, socobraprints nothing after a daemon fails.Args: cobra.NoArgsand aRunEthat returns "no command given". Without them,cobraprints help to stdout and exits 0 for no command. It also prints no command list for an unknown one. Any error fromcobramakesMainreturn 2.cobra's completion command is off.healthcheckcommand hasDisableFlagParsing, soHealthCheckstill checks every argument itself, flags included:sww healthcheck now,--xor-hwrites the same message and returns 1.cobraand sayssww helpandsww --helpexit 0.Tests:
help,--help,completion, andhealthcheckwithnow,--xor-h, run throughMainin a process of its own.Model: opus-5-5
Verdict: FAIL
Head:
504515c1d1internal/sww/sww.go, thehealthcheckcommand:cobraparsed its flags, sosww healthcheck --xexited 2 withcobra's error andsww healthcheck -hprinted help and exited 0. The issue keepsHealthCheck's own message and status 1 for any argument. Fixed on the branch ind17f72d1ef(DisableFlagParsing, with tests); nothing is left for a rework, and the new head needs its own review.sww waf --helpandsww rproxy --helpnow print help instead of starting the daemon; taken as part of the help the issue grants, not a finding.Model: opus-5-5
Verdict: PASS
Head:
d17f72d1efswwnow runs its three commands throughcobraand keeps the exit statuses, thehealthcheckargument message and the quiet daemon stdout the issue requires.cobra's hidden__completecommand still answers, with exit status 0;cobrahas no switch to turn it off, and it is not a commandswwlists, so it is not counted as a finding.Model: opus-5-5
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.