coreruleset: embed the apps fixes as one directory (closes #430) #452

Open
clawbot wants to merge 1 commits from issue-430-app-fixes-directory into next
pull from: issue-430-app-fixes-directory
Collaborator

Closes #430

The apps' fix files are one embedded directory, and comments name sww's changes to the Core Rule Set by what they do.

New directory and names:

  • internal/coreruleset/apps/: the nine .conf files, moved with history.
  • appFixes: the embed.FS of apps/*.conf. Its doc now carries what the removed app.directives field said about the files.

What changed:

  • An app's name is its file's name. AppNames() reads the directory and sorts the names, so it returns the same nine names.
  • The nine per-app variables and app.directives are gone. apps holds only forgejo and gitea, the two with cookies or forkOf. Adding any other app is adding its file.
  • New joins the files in name order, as before, so Coraza gets the same text.
  • The comments "The first change" to "The fifth", and "The rest of the second change", now say what each change does. The references in nextcloud.conf and SPEC.md now say PUT, PATCH and DELETE.
  • SPEC.md gives the new path of each app's file. It no longer says each app has an entry in apps, since most do not.

No test changed.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/smallwebwaf/issues/430 The apps' fix files are one embedded directory, and comments name sww's changes to the Core Rule Set by what they do. New directory and names: - `internal/coreruleset/apps/`: the nine `.conf` files, moved with history. - `appFixes`: the `embed.FS` of `apps/*.conf`. Its doc now carries what the removed `app.directives` field said about the files. What changed: - An app's name is its file's name. `AppNames()` reads the directory and sorts the names, so it returns the same nine names. - The nine per-app variables and `app.directives` are gone. `apps` holds only `forgejo` and `gitea`, the two with `cookies` or `forkOf`. Adding any other app is adding its file. - `New` joins the files in name order, as before, so Coraza gets the same text. - The comments "The first change" to "The fifth", and "The rest of the second change", now say what each change does. The references in `nextcloud.conf` and `SPEC.md` now say `PUT`, `PATCH` and `DELETE`. - `SPEC.md` gives the new path of each app's file. It no longer says each app has an entry in `apps`, since most do not. No test changed. Model: opus-5-5
clawbot self-assigned this 2026-11-19 17:35:43 +01:00
clawbot added 1 commit 2026-11-19 17:35:43 +01:00
The nine app files move to internal/coreruleset/apps/ and are embedded
once as appFixes. An app's name is its file's name; the per-app
variables go, and apps keeps only gitea's and Forgejo's cookies and
forkOf. Comments and SPEC name each of sww's changes to the Core Rule
Set by what it does instead of by number. The directives Coraza gets
are unchanged.

Model: opus-5-5
clawbot added the needs-review label 2026-11-19 17:35:56 +01:00
Some checks are pending
check / check (push) Waiting to run
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-430-app-fixes-directory:issue-430-app-fixes-directory
git checkout issue-430-app-fixes-directory
Sign in to join this conversation.