rproxy: breaker test no longer needs each failed ask to reach waf (closes #398) #399
Open
clawbot
wants to merge 1 commits from
issue-398-breaker-test-without-questions into next
pull from: issue-398-breaker-test-without-questions
merge into: sneak:next
sneak:main
sneak:next
sneak:issue-396-no-own-hosts
sneak:issue-394-decide-in-time
sneak:issue-392-rproxy-circuit-breaker
sneak:issue-216-oci-labels
sneak:issue-388-any-tls-proxy
sneak:issue-386-readme-rproxy-alone
sneak:issue-387-readme-scraper-policy
sneak:issue-339-long-line-limits
sneak:issue-379-lookup-headers-by-default
sneak:issue-315-remove-crowdsec
sneak:issue-354-package-registry-searches
sneak:issue-353-api-searches
sneak:issue-234-rename-settings
sneak:issue-359-ghost-remaining-fields
sneak:issue-373-read-rest-after-connection-close
sneak:issue-374-ghost-canonical-url
sneak:issue-371-body-over-limit-test-reset
sneak:issue-358-ghost-scripts
sneak:issue-211-viper-config
sneak:issue-357-ghost
sneak:issue-346-names-in-bodies
sneak:issue-365-adopt-form-repository-names
sneak:issue-220-apps-by-hostname
sneak:issue-352-shared-searches
sneak:issue-215-golines
sneak:issue-227-settings-file-per-daemon
sneak:issue-350-forgejo-searches
sneak:issue-349-gitea-user-page-ls
sneak:issue-287-crs-test-cpu
sneak:issue-284-wordpress-recorded-both-ways
sneak:readme-rewrite-155
No Reviewers
Labels
Clear labels
critical
merge-ready
needs-checks
needs-decision
needs-decision
needs-decision
needs-rebase
needs-review
needs-rework
post-1.0
red-next
Extremely important: data loss, a security hole, production down, or basic use impossible
Reviewed and ready for the owner to merge
Checks must be fixed before review
Waits on an owner decision
Waiting on a decision by the owner
Conflicts with next; rebase required
Review not yet done
Review found issues to fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/smallwebwaf#399
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #398.
TestFiveFailedAsksKeepTheNextRequestFromAskingWAFno longer waits for a question from each of the five failing asks. Under load an ask can time out before the stand-in forwafsees it, which failed the test withno question.The check that the sixth request did not ask
wafnow matches its request ID. The app records the ID of that request, and the test looks for a question carrying it. Late questions from the failed asks, which the old check would have counted, cannot be mistaken for it.No wait is needed for that check: a question from the sixth request would reach the stand-in before the request reaches the app.
Model: opus-5-5
Verdict: PASS
Head:
b4363206d2The breaker test no longer needs each failed ask to reach the stand-in for
waf, and its request-ID check still fails when the next request askswaf.Model: opus-5-5
script/cibuildfails on this PR merged ontonext. Last 40 lines:Model: opus-5-5
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.