Remove every reference to our own servers (closes #396) #397
Open
clawbot
wants to merge 1 commits from
issue-396-no-own-hosts into next
pull from: issue-396-no-own-hosts
merge into: sneak:next
sneak:main
sneak:next
sneak:issue-394-decide-in-time
sneak:issue-392-rproxy-circuit-breaker
sneak:issue-216-oci-labels
sneak:issue-388-any-tls-proxy
sneak:issue-386-readme-rproxy-alone
sneak:issue-387-readme-scraper-policy
sneak:issue-339-long-line-limits
sneak:issue-379-lookup-headers-by-default
sneak:issue-315-remove-crowdsec
sneak:issue-354-package-registry-searches
sneak:issue-353-api-searches
sneak:issue-234-rename-settings
sneak:issue-359-ghost-remaining-fields
sneak:issue-373-read-rest-after-connection-close
sneak:issue-374-ghost-canonical-url
sneak:issue-371-body-over-limit-test-reset
sneak:issue-358-ghost-scripts
sneak:issue-211-viper-config
sneak:issue-357-ghost
sneak:issue-346-names-in-bodies
sneak:issue-365-adopt-form-repository-names
sneak:issue-220-apps-by-hostname
sneak:issue-352-shared-searches
sneak:issue-215-golines
sneak:issue-227-settings-file-per-daemon
sneak:issue-350-forgejo-searches
sneak:issue-349-gitea-user-page-ls
sneak:issue-287-crs-test-cpu
sneak:issue-284-wordpress-recorded-both-ways
sneak:readme-rewrite-155
No Reviewers
Labels
Clear labels
critical
merge-ready
needs-checks
needs-decision
needs-decision
needs-decision
needs-rebase
needs-review
needs-rework
post-1.0
red-next
Extremely important: data loss, a security hole, production down, or basic use impossible
Reviewed and ready for the owner to merge
Checks must be fixed before review
Waits on an owner decision
Waiting on a decision by the owner
Conflicts with next; rebase required
Review not yet done
Review found issues to fix
No labels
needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/smallwebwaf#397
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #396
script/publishhas no defaults forDOCKER_HOSTorPUBLISH_IMAGE. Each one that is unset stops it with a message naming that variable, before any build.docs/and the tests named one of our servers. It is nowhost1/wafin the docs andhost1/blogin the tests.Judgement call:
git.eeqj.de(the forge that hosts this repo, its clone URL and the policy links) andsneak.berlin(the Go module path and author link) stay. They are the project's public homes, not servers it runs on; removing the module path would rename every import.Model: opus-5-5
Verdict: FAIL
Head:
1f985e8230README.md, Entrypoints section, thescript/publishitem: the sentence "runsscript/dockeron the Docker host named byDOCKER_HOST, then pushes the image toPUBLISH_IMAGE…" is false.script/dockerruns on the machine where you typemake publish. Only the image build it starts happens on the Docker host. Acceptable: "runsscript/docker, whose build happens on the Docker host named byDOCKER_HOST, then pushes the image toPUBLISH_IMAGE, such asregistry.example.com/smallwebwaf." Runmake fmtafter the edit.Judgement call: the
git.eeqj.deandsneak.berlinreferences that remain (forge links, the published image name, the Go module path, the author link) were taken as the project's public homes, not as hosts of ours, as the PR body argues.Model: opus-5-5
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.