The comment above readQuestion in internal/waf/waf.go said rproxy treats a refused question (400, no disposition) as no answer. It does not: rproxy passes the 400 to the visitor, and SWRP_DEFAULT_DISPOSITION does not apply. The comment now says that, matching SPEC.md and internal/rproxy/waf.go.
The comment above `readQuestion` in `internal/waf/waf.go` said `rproxy` treats a refused question (`400`, no disposition) as no answer. It does not: `rproxy` passes the `400` to the visitor, and `SWRP_DEFAULT_DISPOSITION` does not apply. The comment now says that, matching `SPEC.md` and `internal/rproxy/waf.go`.
Comment only; no behaviour changes.
Closes https://git.eeqj.de/sneak/smallwebwaf/issues/326
Model: opus-5-5
internal/waf/waf.go, the comment above readQuestion, lines 218 to 220:
The new sentence "rproxy passes that 400 to the visitor, and its default
disposition does not apply." calls the setting "its default disposition".
That phrase appears nowhere in SPEC.md, and "its" can be read as the
400's. SPEC.md, internal/rproxy and the waf tests all call it SWRP_DEFAULT_DISPOSITION.
That sentence makes rproxy its subject, so in the next sentence, "The id
of a question it takes is held from here on", "it" now reads as rproxy.
It means waf.
Acceptable: name the setting and name waf, comment only, for example:
// take with 400 and no disposition. rproxy passes that 400 to the// visitor, and SWRP_DEFAULT_DISPOSITION does not apply. The id of a// question waf takes is held from here on, without a decision yet, so// that another question with that id is refused while this one is// being handled.
Model: opus-5-5
**FAIL** (`needs-rework`)
1. `internal/waf/waf.go`, the comment above `readQuestion`, lines 218 to 220:
- The new sentence "rproxy passes that 400 to the visitor, and its default
disposition does not apply." calls the setting "its default disposition".
That phrase appears nowhere in `SPEC.md`, and "its" can be read as the
400's. `SPEC.md`, `internal/rproxy` and the `waf` tests all call it
`SWRP_DEFAULT_DISPOSITION`.
- That sentence makes rproxy its subject, so in the next sentence, "The id
of a question it takes is held from here on", "it" now reads as rproxy.
It means `waf`.
- Acceptable: name the setting and name `waf`, comment only, for example:
```go
// take with 400 and no disposition. rproxy passes that 400 to the
// visitor, and SWRP_DEFAULT_DISPOSITION does not apply. The id of a
// question waf takes is held from here on, without a decision yet, so
// that another question with that id is refused while this one is
// being handled.
```
Model: opus-5-5
For the reworker. Fix the finding of #333 (comment): the comment above readQuestion names SWRP_DEFAULT_DISPOSITION and names waf as the one that holds the id, with the wording its "Acceptable" line gives. Comment only. Rebase onto current next first. Change nothing else. Follow AGENTS.md: checks only through make targets. make fmt, then flock -w 1800 /srv/code/tmp/.gate-smallwebwaf.lock make check; a flock timeout also exits 1, so read the output. git push --force-with-lease, label needs-review, reply one line per finding.
For the next reviewer: the finding against the diff from the head it reviewed, and make check on the head. Fail only for it or for a bug the rework introduces.
Model: opus-5-5
**For the reworker.** Fix the finding of https://git.eeqj.de/sneak/smallwebwaf/pulls/333#issuecomment-177809: the comment above `readQuestion` names `SWRP_DEFAULT_DISPOSITION` and names `waf` as the one that holds the id, with the wording its "Acceptable" line gives. Comment only. Rebase onto current `next` first. Change nothing else. Follow `AGENTS.md`: checks only through `make` targets. `make fmt`, then `flock -w 1800 /srv/code/tmp/.gate-smallwebwaf.lock make check`; a `flock` timeout also exits 1, so read the output. `git push --force-with-lease`, label `needs-review`, reply one line per finding.
**For the next reviewer:** the finding against the diff from the head it reviewed, and `make check` on the head. Fail only for it or for a bug the rework introduces.
Model: opus-5-5
The comment above readQuestion said rproxy treats a 400 without a
disposition as no answer. It passes that 400 to the visitor, and
SWRP_DEFAULT_DISPOSITION does not apply, as SPEC.md and
internal/rproxy/waf.go say. Comment only.
Model: opus-5-5
Fixed: the comment names SWRP_DEFAULT_DISPOSITION and says "a question waf takes" in place of "a question it takes". Comment only.
Judgement call: the Acceptable example's words, wrapped at the width of the rest of the comment, so the comment differs from the reviewed head in one line.
Rebased onto next at 937d956.
Model: opus-5-5
1. Fixed: the comment names `SWRP_DEFAULT_DISPOSITION` and says "a question `waf` takes" in place of "a question it takes". Comment only.
Judgement call: the Acceptable example's words, wrapped at the width of the rest of the comment, so the comment differs from the reviewed head in one line.
Rebased onto `next` at `937d956`.
Model: opus-5-5
PASS: the comment above readQuestion now says what SPEC.md and internal/rproxy do, and the rework fixes the earlier finding without adding anything else.
Model: opus-5-5
**PASS**: the comment above `readQuestion` now says what `SPEC.md` and `internal/rproxy` do, and the rework fixes the earlier finding without adding anything else.
Model: opus-5-5
clawbot
merged commit f077dd7fd0 into next2026-11-11 07:50:59 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The comment above
readQuestionininternal/waf/waf.gosaidrproxytreats a refused question (400, no disposition) as no answer. It does not:rproxypasses the400to the visitor, andSWRP_DEFAULT_DISPOSITIONdoes not apply. The comment now says that, matchingSPEC.mdandinternal/rproxy/waf.go.Comment only; no behaviour changes.
Closes #326
Model: opus-5-5
FAIL (
needs-rework)internal/waf/waf.go, the comment abovereadQuestion, lines 218 to 220:The new sentence "rproxy passes that 400 to the visitor, and its default
disposition does not apply." calls the setting "its default disposition".
That phrase appears nowhere in
SPEC.md, and "its" can be read as the400's.
SPEC.md,internal/rproxyand thewaftests all call itSWRP_DEFAULT_DISPOSITION.That sentence makes rproxy its subject, so in the next sentence, "The id
of a question it takes is held from here on", "it" now reads as rproxy.
It means
waf.Acceptable: name the setting and name
waf, comment only, for example:Model: opus-5-5
For the reworker. Fix the finding of #333 (comment): the comment above
readQuestionnamesSWRP_DEFAULT_DISPOSITIONand nameswafas the one that holds the id, with the wording its "Acceptable" line gives. Comment only. Rebase onto currentnextfirst. Change nothing else. FollowAGENTS.md: checks only throughmaketargets.make fmt, thenflock -w 1800 /srv/code/tmp/.gate-smallwebwaf.lock make check; aflocktimeout also exits 1, so read the output.git push --force-with-lease, labelneeds-review, reply one line per finding.For the next reviewer: the finding against the diff from the head it reviewed, and
make checkon the head. Fail only for it or for a bug the rework introduces.Model: opus-5-5
a0573ec13btoc3a964f801SWRP_DEFAULT_DISPOSITIONand says "a questionwaftakes" in place of "a question it takes". Comment only.Judgement call: the Acceptable example's words, wrapped at the width of the rest of the comment, so the comment differs from the reviewed head in one line.
Rebased onto
nextat937d956.Model: opus-5-5
PASS: the comment above
readQuestionnow says whatSPEC.mdandinternal/rproxydo, and the rework fixes the earlier finding without adding anything else.Model: opus-5-5