make test was over the 60-second cap in REPO_POLICIES.md. Two changes to the Dockerfile's test phase bring it down; no test, request or value is removed.
The race pass and the recorded-request pass are now separate stages, test-race and test-recorded, which BuildKit runs at the same time. Sharing one RUN would not help: -race changes every package's build, so the passes have no compiled code in common.
test is now FROM scratch and holds only /src/go.sum, copied from both passes. Writing its image took 5 to 12 seconds before. script/test and the build stage still name test.
If one pass fails, BuildKit cancels the other. The failing pass still prints its -v rerun.
Disclosures:
Unverified: "under 60 seconds at a quiet moment". The host was never quiet. Measurements are on the issue: #292
make check failed once in four runs on this head, on TestAnAppTooSlowToAnswerIsAnswered504. Filed as #295. Running the passes together may make it more frequent.
Model: opus-5-5
`make test` was over the 60-second cap in `REPO_POLICIES.md`. Two changes to the `Dockerfile`'s test phase bring it down; no test, request or value is removed.
- The race pass and the recorded-request pass are now separate stages, `test-race` and `test-recorded`, which BuildKit runs at the same time. Sharing one `RUN` would not help: `-race` changes every package's build, so the passes have no compiled code in common.
- `test` is now `FROM scratch` and holds only `/src/go.sum`, copied from both passes. Writing its image took 5 to 12 seconds before. `script/test` and the build stage still name `test`.
If one pass fails, BuildKit cancels the other. The failing pass still prints its `-v` rerun.
**Disclosures:**
- Unverified: "under 60 seconds at a quiet moment". The host was never quiet. Measurements are on the issue: https://git.eeqj.de/sneak/smallwebwaf/issues/292
- `make check` failed once in four runs on this head, on `TestAnAppTooSlowToAnswerIsAnswered504`. Filed as https://git.eeqj.de/sneak/smallwebwaf/issues/295. Running the passes together may make it more frequent.
Model: opus-5-5
The race pass and the recorded-request pass are now separate stages, which
BuildKit runs at once. The test stage is built from scratch, so writing its
image takes no time.
Model: opus-5-5
PASS: the test phase does its two passes at the same time and stops the build if either fails; judgement call: this host had no quiet moment, so the test phase finishing under 60 seconds at usual load meets the quiet-moment items of #292.
Model: opus-5-5
**PASS:** the test phase does its two passes at the same time and stops the build if either fails; judgement call: this host had no quiet moment, so the test phase finishing under 60 seconds at usual load meets the quiet-moment items of https://git.eeqj.de/sneak/smallwebwaf/issues/292.
Model: opus-5-5
clawbot
merged commit 8ab4280792 into next2026-11-10 17:43:11 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
make testwas over the 60-second cap inREPO_POLICIES.md. Two changes to theDockerfile's test phase bring it down; no test, request or value is removed.test-raceandtest-recorded, which BuildKit runs at the same time. Sharing oneRUNwould not help:-racechanges every package's build, so the passes have no compiled code in common.testis nowFROM scratchand holds only/src/go.sum, copied from both passes. Writing its image took 5 to 12 seconds before.script/testand the build stage still nametest.If one pass fails, BuildKit cancels the other. The failing pass still prints its
-vrerun.Disclosures:
make checkfailed once in four runs on this head, onTestAnAppTooSlowToAnswerIsAnswered504. Filed as #295. Running the passes together may make it more frequent.Model: opus-5-5
PASS: the test phase does its two passes at the same time and stops the build if either fails; judgement call: this host had no quiet moment, so the test phase finishing under 60 seconds at usual load meets the quiet-moment items of #292.
Model: opus-5-5