Lower limits for listed AS numbers and countries, as #21 and its plan set out.
SWWAF_ASN_LIMIT_PERCENT and SWWAF_COUNTRY_LIMIT_PERCENT give the clients of the AS numbers and countries they list that percentage of every rate limit and byte limit, rounded down; 0 refuses and bans at the first request. SWWAF_ASN_BYTES_PERCENT and SWWAF_COUNTRY_BYTES_PERCENT take their place for the byte limits of what they list. SWWAF_UNKNOWN_LIMIT_PERCENT (default 100) covers clients without a country. The lowest percentage applies; of equal ones, the AS number's, then the country's.
While one of them lowers a limit, a request waits for its client's first answer from GeoJS, as for the country lists, and SWWAF_LOOKUP_SOURCE=off stops the start naming both. A malformed entry, a percentage over 100 or a code listed twice stops the start naming the setting.
The request log gives limit_percent and bytes_percent below 100, each with the setting that gave it. A ban for a lowered limit gives the lowered limit in its reason and notes, and the percentage and its setting in its notes, which its alert carries.
README.md documents the settings, and that no budget is shared by a whole AS number or country.
Not visible in the diff's shape: Limiter.Count and CountBytes now take the percentage, so their existing test callers pass 100.
Judgement call: a client counts as unknown when it has no country, whatever its AS number.
Judgement call: bytes_percent and bytes_percent_setting are log fields SPEC.md does not name; limit_percent_setting is its "which rule set it".
Rule suppressed: funlen on FromEnvironment, one line per setting.
Model: opus-5-5
Lower limits for listed AS numbers and countries, as https://git.eeqj.de/sneak/smallwebwaf/issues/21 and its plan set out.
- `SWWAF_ASN_LIMIT_PERCENT` and `SWWAF_COUNTRY_LIMIT_PERCENT` give the clients of the AS numbers and countries they list that percentage of every rate limit and byte limit, rounded down; `0` refuses and bans at the first request. `SWWAF_ASN_BYTES_PERCENT` and `SWWAF_COUNTRY_BYTES_PERCENT` take their place for the byte limits of what they list. `SWWAF_UNKNOWN_LIMIT_PERCENT` (default `100`) covers clients without a country. The lowest percentage applies; of equal ones, the AS number's, then the country's.
- While one of them lowers a limit, a request waits for its client's first answer from GeoJS, as for the country lists, and `SWWAF_LOOKUP_SOURCE=off` stops the start naming both. A malformed entry, a percentage over 100 or a code listed twice stops the start naming the setting.
- The request log gives `limit_percent` and `bytes_percent` below 100, each with the setting that gave it. A ban for a lowered limit gives the lowered limit in its reason and notes, and the percentage and its setting in its notes, which its alert carries.
- `README.md` documents the settings, and that no budget is shared by a whole AS number or country.
Not visible in the diff's shape: `Limiter.Count` and `CountBytes` now take the percentage, so their existing test callers pass 100.
Judgement call: a client counts as unknown when it has no country, whatever its AS number.
Judgement call: `bytes_percent` and `bytes_percent_setting` are log fields `SPEC.md` does not name; `limit_percent_setting` is its "which rule set it".
Rule suppressed: `funlen` on `FromEnvironment`, one line per setting.
Model: opus-5-5
internal/proxy/biased_test.go, TestLowestPercentageApplies: nothing tests a client without a country whose AS number is listed with a percentage below SWWAF_UNKNOWN_LIMIT_PERCENT. The only case for such a client has the unknown percentage lower, so code that gave it the unknown percentage alone, ignoring its AS number, would go unnoticed, and the "lowest percentage wins" item of the definition of done is unproven for that pair. Acceptable: a case where noCountry (AS64500, no country) is listed below SWWAF_UNKNOWN_LIMIT_PERCENT, for example AS64500:25 with the default 100, expecting 25 from SWWAF_ASN_LIMIT_PERCENT.
Judgement calls accepted: a client without a country counts as unknown whatever its AS number, and still gets its AS number's percentage when that is lower; bytes_percent and bytes_percent_setting as log fields; funlen suppressed on FromEnvironment.
Model: opus-5-5
Review failed.
- `internal/proxy/biased_test.go`, `TestLowestPercentageApplies`: nothing tests a client without a country whose AS number is listed with a percentage below `SWWAF_UNKNOWN_LIMIT_PERCENT`. The only case for such a client has the unknown percentage lower, so code that gave it the unknown percentage alone, ignoring its AS number, would go unnoticed, and the "lowest percentage wins" item of the definition of done is unproven for that pair. Acceptable: a case where `noCountry` (`AS64500`, no country) is listed below `SWWAF_UNKNOWN_LIMIT_PERCENT`, for example `AS64500:25` with the default `100`, expecting `25` from `SWWAF_ASN_LIMIT_PERCENT`.
Judgement calls accepted: a client without a country counts as unknown whatever its AS number, and still gets its AS number's percentage when that is lower; `bytes_percent` and `bytes_percent_setting` as log fields; `funlen` suppressed on `FromEnvironment`.
Model: opus-5-5
SWWAF_ASN_LIMIT_PERCENT and SWWAF_COUNTRY_LIMIT_PERCENT give the clients
of the AS numbers and countries they list that percentage of every rate
and byte limit, rounded down; SWWAF_ASN_BYTES_PERCENT and
SWWAF_COUNTRY_BYTES_PERCENT take its place for the byte limits of those
they list; SWWAF_UNKNOWN_LIMIT_PERCENT (100) covers clients without a
country. The lowest applies. While one lowers a limit, a request waits
for its client's lookup, and SWWAF_LOOKUP_SOURCE=off stops the start. Log
lines give limit_percent and bytes_percent with their settings; ban
notes, and so alerts, give the broken limit's.
Judgement call: a client without a country is unknown, whatever its AS number.
Judgement call: bytes_percent and its setting are log fields SPEC does not name.
Rule suppressed: funlen on FromEnvironment, one line per setting.
Model: opus-5-5
#103 (comment): TestLowestPercentageApplies has the case AS64500:25 for the client without a country, with SWWAF_UNKNOWN_LIMIT_PERCENT at its default 100, expecting 25 from SWWAF_ASN_LIMIT_PERCENT.
Model: opus-5-5
https://git.eeqj.de/sneak/smallwebwaf/pulls/103#issuecomment-132059: `TestLowestPercentageApplies` has the case `AS64500:25` for the client without a country, with `SWWAF_UNKNOWN_LIMIT_PERCENT` at its default `100`, expecting `25` from `SWWAF_ASN_LIMIT_PERCENT`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Lower limits for listed AS numbers and countries, as #21 and its plan set out.
SWWAF_ASN_LIMIT_PERCENTandSWWAF_COUNTRY_LIMIT_PERCENTgive the clients of the AS numbers and countries they list that percentage of every rate limit and byte limit, rounded down;0refuses and bans at the first request.SWWAF_ASN_BYTES_PERCENTandSWWAF_COUNTRY_BYTES_PERCENTtake their place for the byte limits of what they list.SWWAF_UNKNOWN_LIMIT_PERCENT(default100) covers clients without a country. The lowest percentage applies; of equal ones, the AS number's, then the country's.SWWAF_LOOKUP_SOURCE=offstops the start naming both. A malformed entry, a percentage over 100 or a code listed twice stops the start naming the setting.limit_percentandbytes_percentbelow 100, each with the setting that gave it. A ban for a lowered limit gives the lowered limit in its reason and notes, and the percentage and its setting in its notes, which its alert carries.README.mddocuments the settings, and that no budget is shared by a whole AS number or country.Not visible in the diff's shape:
Limiter.CountandCountBytesnow take the percentage, so their existing test callers pass 100.Judgement call: a client counts as unknown when it has no country, whatever its AS number.
Judgement call:
bytes_percentandbytes_percent_settingare log fieldsSPEC.mddoes not name;limit_percent_settingis its "which rule set it".Rule suppressed:
funlenonFromEnvironment, one line per setting.Model: opus-5-5
Review failed.
internal/proxy/biased_test.go,TestLowestPercentageApplies: nothing tests a client without a country whose AS number is listed with a percentage belowSWWAF_UNKNOWN_LIMIT_PERCENT. The only case for such a client has the unknown percentage lower, so code that gave it the unknown percentage alone, ignoring its AS number, would go unnoticed, and the "lowest percentage wins" item of the definition of done is unproven for that pair. Acceptable: a case wherenoCountry(AS64500, no country) is listed belowSWWAF_UNKNOWN_LIMIT_PERCENT, for exampleAS64500:25with the default100, expecting25fromSWWAF_ASN_LIMIT_PERCENT.Judgement calls accepted: a client without a country counts as unknown whatever its AS number, and still gets its AS number's percentage when that is lower;
bytes_percentandbytes_percent_settingas log fields;funlensuppressed onFromEnvironment.Model: opus-5-5
9cb4bc152ctoabf3b01ba9#103 (comment):
TestLowestPercentageApplieshas the caseAS64500:25for the client without a country, withSWWAF_UNKNOWN_LIMIT_PERCENTat its default100, expecting25fromSWWAF_ASN_LIMIT_PERCENT.Model: opus-5-5
Review passed.
Model: opus-5-5