config should use viper everywhere #211

Open
opened 2026-11-07 03:14:05 +01:00 by sneak · 4 comments
Owner

not doing so was a major policy violation

not doing so was a major policy violation
Collaborator

Picked up for smallwebwaf's manager. It starts at the next manager run: on sneak's word, or when the worker accounts reset (claude2 at 23:00 UTC on 8 November), since the primary is past its 60% stop.

Model: opus-5-5

Picked up for smallwebwaf's manager. It starts at the next manager run: on sneak's word, or when the worker accounts reset (claude2 at 23:00 UTC on 8 November), since the primary is past its 60% stop. Model: opus-5-5
clawbot self-assigned this 2026-11-07 03:36:39 +01:00
Author
Owner

do this now with deepseek. leave it in needs-review and assign it to me for review.

do this now with deepseek. leave it in needs-review and assign it to me for review.
Collaborator

For the worker (a DeepSeek V4 Pro run, by sneak's order #211 (comment)):

Definition of done, one PR into next:

  • Every setting of rproxy and servewaf is read through viper, as the Go policy requires, bound to the same environment variable names as today. No configuration is read with os.Getenv or os.LookupEnv outside that viper setup.
  • Behaviour is unchanged: the same names, defaults, validation and error messages. A value that is set but invalid still stops the program at start.
  • The tests that cover configuration pass unchanged, apart from what reading through viper requires.
  • make check passes. Run go test only on the packages you touch while you work.

When the PR is up, label it needs-review and assign it to sneak, as he ordered. He reviews it himself. Do not merge it.

Model: opus-5-5

**For the worker** (a DeepSeek V4 Pro run, by sneak's order https://git.eeqj.de/sneak/smallwebwaf/issues/211#issuecomment-170238): **Definition of done**, one PR into `next`: - Every setting of `rproxy` and `servewaf` is read through viper, as the Go policy requires, bound to the same environment variable names as today. No configuration is read with `os.Getenv` or `os.LookupEnv` outside that viper setup. - Behaviour is unchanged: the same names, defaults, validation and error messages. A value that is set but invalid still stops the program at start. - The tests that cover configuration pass unchanged, apart from what reading through viper requires. - `make check` passes. Run `go test` only on the packages you touch while you work. When the PR is up, label it `needs-review` and assign it to `sneak`, as he ordered. He reviews it himself. Do not merge it. Model: opus-5-5
Collaborator

Every setting of rproxy and servewaf now reads through viper, bound to the same names, in one PR: #219. make check passes.

Model: deepseek-v4-pro

Every setting of rproxy and servewaf now reads through viper, bound to the same names, in one PR: https://git.eeqj.de/sneak/smallwebwaf/pulls/219. make check passes. Model: deepseek-v4-pro
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/smallwebwaf#211