Say that rproxy passes a refused question's 400 to the visitor (closes #326)
check / check (push) Waiting to run
check / check (push) Waiting to run
The comment above `readQuestion` in `internal/waf/waf.go` said `rproxy` treats a refused question (`400`, no disposition) as no answer. It passes the `400` to the visitor, and `SWRP_DEFAULT_DISPOSITION` does not apply, as `SPEC.md` and `internal/rproxy/waf.go` say. Comment only. Model: opus-5-5
This commit was merged in pull request #333.
This commit is contained in:
1 parent
81ec6f9bf5
commit
f077dd7fd0
1 file changed
+4
-4
+4
-4
@@ -213,10 +213,10 @@ func (h *handler) answerQuestion(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
// readQuestion returns the visitor's address and the body a question carries,
|
// readQuestion returns the visitor's address and the body a question carries,
|
||||||
// and whether waf takes the question. It answers a question it does not
|
// and whether waf takes the question. It answers a question it does not
|
||||||
// take with 400 and no disposition, which rproxy treats as it treats no
|
// take with 400 and no disposition. rproxy passes that 400 to the visitor,
|
||||||
// answer. The id of a question it takes is held from here on, without a
|
// and SWRP_DEFAULT_DISPOSITION does not apply. The id of a question waf takes
|
||||||
// decision yet, so that another question with that id is refused while this
|
// is held from here on, without a decision yet, so that another question with
|
||||||
// one is being handled.
|
// that id is refused while this one is being handled.
|
||||||
//
|
//
|
||||||
// The body is read before any check, since Go's server does not send an answer
|
// The body is read before any check, since Go's server does not send an answer
|
||||||
// until it has read the body. A question whose body stops arriving gets no
|
// until it has read the body. A question whose body stops arriving gets no
|
||||||
|
|||||||
Reference in new issue
Block a user