Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/waf/lookup_test.go

@@ -5,6 +5,7 @@ import (
 	"net/netip"
 	"path/filepath"
 	"slices"
+	"strconv"
 	"sync"
 	"testing"
 	"testing/synctest"
@@ -34,8 +35,8 @@ func TestEveryClientIsLookedUpWithoutWaitingWhileNoSettingNeedsIt(
 	// waitLimit.
 	geojsURL, asked, release := startHeldGeoJS(t)
 	s, _, server := startWithClock(t, geojsURL, map[string]string{
-		lookupTimeout:      "1h",
-		rateLimitPerMinute: "1",
+		asnAndCountryLookupTimeout: "3600000",
+		rateLimitPerMinute:         "1",
 	})
 
 	// fromDE's second request breaks the limit and bans it, and fromKP
@@ -104,9 +105,9 @@ func TestRequestThatWaitedForItsLookupIsCountedWhenItGoesOn(t *testing.T) {
 	clk := &clock{now: time.Date(2026, 10, 6, 0, 0, 58, 0, time.UTC)}
 	addr, out, server := startProxyWithClock(t, app.URL, geojsURL, clk.Now,
 		map[string]string{
-			trustedProxies: trustLocalhost,
-			lookupTimeout:  "1h",
-			tagDeny:        denyKP,
+			trustedProxies:             trustLocalhost,
+			asnAndCountryLookupTimeout: "3600000",
+			tagDeny:                    denyKP,
 		})
 
 	requestFromDE := func() *http.Request {
@@ -364,9 +365,9 @@ func TestLookupHeadersArePassedToTheAppAndTheClientsOwnRemoved(
 		geojsURL,
 		time.Now,
 		map[string]string{
-			trustedProxies:   trustLocalhost,
-			lookupTimeout:    "1h",
-			addLookupHeaders: on,
+			trustedProxies:             trustLocalhost,
+			asnAndCountryLookupTimeout: "3600000",
+			addLookupHeaders:           on,
 		},
 	)
 	s := &sender{t: t, addr: addr, out: out}
@@ -437,7 +438,9 @@ func TestClientsOwnLookupHeadersAreRemovedWhileTheSettingIsOff(
 	}
 }
 
-func TestRequestWaitsAsLongAsTheLookupTimeoutSays(t *testing.T) {
+func TestRequestWaitsAsLongAsTheASNAndCountryLookupTimeoutSays(
+	t *testing.T,
+) {
 	t.Parallel()
 
 	// The test runs in a synctest bubble, where the time package runs on a
@@ -452,7 +455,8 @@ func TestRequestWaitsAsLongAsTheLookupTimeoutSays(t *testing.T) {
 
 		server, out, _ := newWAF(t, silentGeoJSURL, time.Now,
 			map[string]string{
-				lookupTimeout:    timeout.String(),
+				asnAndCountryLookupTimeout: strconv.FormatInt(
+					timeout.Milliseconds(), 10),
 				allowedCountries: "DE",
 			})