Naming audit: rename the settings, after the viper change lands #234

Open
opened 2026-11-09 06:00:45 +01:00 by clawbot · 0 comments
Collaborator

The settings part of the naming audit (#192), split out because #219 rewrites every setting name and sneak reviews and merges that PR himself. Building this first would force a full rebase of it under his review. Start from next once that PR has landed. If he chooses otherwise, this starts at once and that PR is rebased after it.

Definition of done, one PR into next:

  • Every setting rename in #192 (comment), under the prefixes #219 set: SWW_WAF_ for the discriminator, SWW_RPROXY_ for rproxy. Names that PR already changed are not renamed twice.
  • sneak's names on #202 (comment) override the list, as recorded at #202 (comment): the IP reputation cache time, and the DNS blocklist and AbuseIPDB time limit and the client location wait, each ending in _MS.
  • The rproxy log field default_disposition follows its setting, to waf_backend_no_answer.
  • config.Config and config.FromEnvironment name the discriminator, beside config.RProxy.
  • No aliases, no fallbacks. State files keep version 1. Code, tests, README.md, SPEC.md, docs/, Dockerfile, deploy/ and script/ all follow.
  • make check passes.

Model: opus-5-5

The settings part of the naming audit (https://git.eeqj.de/sneak/smallwebwaf/issues/192), split out because https://git.eeqj.de/sneak/smallwebwaf/pulls/219 rewrites every setting name and sneak reviews and merges that PR himself. Building this first would force a full rebase of it under his review. Start from `next` once that PR has landed. If he chooses otherwise, this starts at once and that PR is rebased after it. **Definition of done**, one PR into `next`: - Every setting rename in https://git.eeqj.de/sneak/smallwebwaf/issues/192#issuecomment-169850, under the prefixes https://git.eeqj.de/sneak/smallwebwaf/pulls/219 set: `SWW_WAF_` for the discriminator, `SWW_RPROXY_` for `rproxy`. Names that PR already changed are not renamed twice. - sneak's names on https://git.eeqj.de/sneak/smallwebwaf/issues/202#issuecomment-170241 override the list, as recorded at https://git.eeqj.de/sneak/smallwebwaf/issues/202#issuecomment-170254: the IP reputation cache time, and the DNS blocklist and AbuseIPDB time limit and the client location wait, each ending in `_MS`. - The `rproxy` log field `default_disposition` follows its setting, to `waf_backend_no_answer`. - `config.Config` and `config.FromEnvironment` name the discriminator, beside `config.RProxy`. - No aliases, no fallbacks. State files keep `version` 1. Code, tests, `README.md`, `SPEC.md`, `docs/`, `Dockerfile`, `deploy/` and `script/` all follow. - `make check` passes. Model: opus-5-5
clawbot self-assigned this 2026-11-09 06:00:45 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/smallwebwaf#234