Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/waf/countries_test.go

@@ -53,8 +53,8 @@ func TestCountryLists(t *testing.T) {
 			})
 			geojsURL, _ := startGeoJS(t)
 			env := map[string]string{
-				trustedProxies: trustLocalhost,
-				lookupTimeout:  "1h",
+				trustedProxies:             trustLocalhost,
+				asnAndCountryLookupTimeout: "3600000",
 			}
 			maps.Copy(env, tc.env)
 			addr, out := startProxyWithGeoJS(t, app.URL, geojsURL, env)
@@ -109,7 +109,7 @@ func TestCountryRefusalNamesItsHeuristicCountryAndSetting(t *testing.T) {
 
 	geojsURL, _ := startGeoJS(t)
 	s, _, _ := startWithClock(t, geojsURL, map[string]string{
-		lookupTimeout: "1h", allowedCountries: "de",
+		asnAndCountryLookupTimeout: "3600000", allowedCountries: "de",
 	})
 
 	line := s.get(
@@ -147,9 +147,9 @@ func TestCountryRefusalKeepsARequestFromTheApp(t *testing.T) {
 	})
 	geojsURL, _ := startGeoJS(t)
 	addr, out := startProxyWithGeoJS(t, app.URL, geojsURL, map[string]string{
-		trustedProxies:   trustLocalhost,
-		lookupTimeout:    "1h",
-		allowedCountries: "de",
+		trustedProxies:             trustLocalhost,
+		asnAndCountryLookupTimeout: "3600000",
+		allowedCountries:           "de",
 	})
 
 	req := newRequest(
@@ -198,10 +198,10 @@ func TestRequestRefusedByCountryIsNotCounted(t *testing.T) {
 
 	app := startApp(t, func(http.ResponseWriter, *http.Request) {})
 	addr, _ := startProxyWithGeoJS(t, app.URL, geojs.URL, map[string]string{
-		trustedProxies:     trustLocalhost,
-		lookupTimeout:      "1h",
-		allowedCountries:   "de",
-		rateLimitPerMinute: "1",
+		trustedProxies:             trustLocalhost,
+		asnAndCountryLookupTimeout: "3600000",
+		allowedCountries:           "de",
+		rateLimitPerMinute:         "1",
 	})
 
 	request := func() answer {
@@ -248,8 +248,8 @@ func TestPrivateAddressIsNeverLookedUp(t *testing.T) {
 			app := startApp(t, func(http.ResponseWriter, *http.Request) {})
 			geojsURL, asked := startGeoJS(t)
 			env := map[string]string{
-				trustedProxies: trustLocalhost,
-				lookupTimeout:  "1h",
+				trustedProxies:             trustLocalhost,
+				asnAndCountryLookupTimeout: "3600000",
 			}
 			maps.Copy(env, tc.env)
 			addr, out := startProxyWithGeoJS(t, app.URL, geojsURL, env)
@@ -352,10 +352,11 @@ func TestExclusiveListRefusesAPrivateAddressUnlessAllowed(t *testing.T) {
 // startGeoJS starts a stand-in for GeoJS, which places fromDE and fromKP,
 // each in an AS of its own, and no other address. It returns its URL, and
 // what returns the addresses it has been asked about. A test that needs
-// the stand-in to be asked or to answer sets SWW_WAF_LOOKUP_TIMEOUT to an
-// hour, whether or not a request waits for the answer: on the default, a
-// hold-up of the test process can abandon the request to the stand-in, and
-// leave the client unknown.
+// the stand-in to be asked or to answer sets
+// SWW_WAF_ASN_AND_COUNTRY_LOOKUP_TIMEOUT_MS to an hour, whether or not a
+// request waits for the answer: on the default, a hold-up of the test
+// process can abandon the request to the stand-in, and leave the client
+// unknown.
 func startGeoJS(t *testing.T) (string, func() []string) {
 	t.Helper()