Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/rproxy/waf.go

@@ -67,15 +67,16 @@ func (rq *request) handleNoUsableAnswer(ctx context.Context, err error) {
 		rq.answer(http.StatusBadGateway)
 	default:
 		// waf cannot be connected to, does not answer at all, or does not answer
-		// within SWW_RPROXY_TIMEOUT_MS. A request that keeps waf busy past
-		// SWW_RPROXY_TIMEOUT_MS, like any request while waf is overloaded, gets
-		// SWW_RPROXY_DEFAULT_DISPOSITION here. deny closes this, at the cost of answering 503
-		// whenever waf is slow. Making such requests hard to send is
+		// within SWW_RPROXY_WAF_BACKEND_TIMEOUT_MS. A request that keeps waf
+		// busy past SWW_RPROXY_WAF_BACKEND_TIMEOUT_MS, like any request while
+		// waf is overloaded, gets SWW_RPROXY_WAF_BACKEND_NO_ANSWER_DISPOSITION
+		// here. deny closes this, at the cost of answering 503 whenever waf is
+		// slow. Making such requests hard to send is
 		// https://git.eeqj.de/sneak/smallwebwaf/issues/182.
 		rq.h.processLog.Warn("waf gave no answer", "error", err.Error())
 
-		rq.disposition = rq.h.config.DefaultDisposition
-		rq.byDefault = true
+		rq.disposition = rq.h.config.WAFBackendNoAnswerDisposition
+		rq.wafNoAnswer = true
 
 		if rq.disposition == waf.DispositionAllow {
 			rq.passToApp(ctx)
@@ -86,10 +87,10 @@ func (rq *request) handleNoUsableAnswer(ctx context.Context, err error) {
 }
 
 // ask sends waf the question, and returns its answer, which must have come
-// whole within SWW_RPROXY_TIMEOUT_MS. It ends when ctx does, as when the visitor goes
-// away.
+// whole within SWW_RPROXY_WAF_BACKEND_TIMEOUT_MS. It ends when ctx does, as
+// when the visitor goes away.
 func (rq *request) ask(ctx context.Context) (*wafAnswer, error) {
-	ctx, cancel := context.WithTimeout(ctx, rq.h.config.Timeout)
+	ctx, cancel := context.WithTimeout(ctx, rq.h.config.WAFBackendTimeout)
 	defer cancel()
 
 	question, err := rq.newQuestion(ctx)
@@ -242,14 +243,14 @@ func (h *handler) sendReport(ctx context.Context, report *waf.Report) {
 }
 
 // postReport posts report to waf, and waits for its answer for up to
-// SWW_RPROXY_TIMEOUT_MS.
+// SWW_RPROXY_WAF_BACKEND_TIMEOUT_MS.
 func (h *handler) postReport(ctx context.Context, report *waf.Report) error {
 	body, err := json.Marshal(report)
 	if err != nil {
 		return fmt.Errorf("encode the report: %w", err)
 	}
 
-	ctx, cancel := context.WithTimeout(ctx, h.config.Timeout)
+	ctx, cancel := context.WithTimeout(ctx, h.config.WAFBackendTimeout)
 	defer cancel()
 
 	req, err := http.NewRequestWithContext( //nolint:gosec // a setting's URL