Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/requestlog/requestlog.go

@@ -44,13 +44,14 @@ const (
 	ActionBlockedByBlockRule = "blocked_by_block_rule"
 
 	// ActionBlockedByCoreRuleSet is a request refused because the Core Rule
-	// Set scored it at or over SWW_WAF_CORE_RULE_SET_ANOMALY_THRESHOLD.
+	// Set scored it at or over SWW_WAF_CORE_RULE_SET_SCORE_THRESHOLD.
 	ActionBlockedByCoreRuleSet = "blocked_by_core_rule_set"
 
 	// ActionClientDenied is a request refused because its client is in
 	// SWW_WAF_DENY_NETS, in a blocklist while SWW_WAF_BLOCKLIST_ACTION is deny,
 	// or listed by a DNSBL zone, or scored a hit by AbuseIPDB, while
-	// SWW_WAF_REPUTATION_ACTION is deny, or that carries a tag in SWW_WAF_TAG_DENY.
+	// SWW_WAF_DNSBL_ABUSEIPDB_ACTION is deny, or that carries a tag in
+	// SWW_WAF_TAG_DENY.
 	ActionClientDenied = "client_denied"
 
 	// ActionCountryDenied is a request refused because its client's country
@@ -62,12 +63,12 @@ const (
 )
 
 // OffenceLimit is the offence a request line names for a request that
-// broke a rate limit or the error burst, or whose bytes broke a byte
+// broke a rate limit or the refusal limit, or whose bytes broke a byte
 // limit.
 const OffenceLimit = "limit"
 
 // LimitHitMinuteRefusals is the limit_hit a request line names for a request
-// that broke the error burst.
+// that broke the refusal limit.
 const LimitHitMinuteRefusals = "minute_refusals"
 
 // The waf_line a request line names, which says which of
@@ -180,7 +181,7 @@ type Line struct {
 	// LimitHit is the window whose limit the request went over, named as
 	// Counts names its count: minute, hour or day for a rate limit, and
 	// minute_bytes, hour_bytes or day_bytes for a byte limit; or
-	// LimitHitMinuteRefusals for the error burst.
+	// LimitHitMinuteRefusals for the refusal limit.
 	LimitHit string `json:"limit_hit,omitempty"`
 	// Reputation are the URLs of the blocklists that list the client, then
 	// that of the CrowdSec decision list when it does, then the DNSBL zones
@@ -233,10 +234,11 @@ type RProxyLine struct {
 	DurationRequestMS  float64 `json:"duration_request_ms"`
 	DurationResponseMS float64 `json:"duration_response_ms"`
 	// Disposition is the valid disposition waf answered or, while
-	// DefaultDisposition is true, the value of SWW_RPROXY_DEFAULT_DISPOSITION. It is ""
-	// when neither gave one.
+	// WAFBackendNoAnswer is true, the value of
+	// SWW_RPROXY_WAF_BACKEND_NO_ANSWER_DISPOSITION. It is "" when neither
+	// gave one.
 	Disposition        string `json:"disposition,omitempty"`
-	DefaultDisposition bool   `json:"default_disposition,omitempty"`
+	WAFBackendNoAnswer bool   `json:"waf_backend_no_answer,omitempty"`
 }
 
 // Write writes line to w as one JSON line marked "type":"request".