Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/waf/rulefiles_test.go

@@ -25,8 +25,8 @@ func TestEachRuleAction(t *testing.T) {
 	t.Parallel()
 
 	s, clk, server := startWithClock(t, "", map[string]string{
-		rulesDir:    writeRules(t, "noted path log ^/\n"+testRules),
-		banResponse: "429",
+		ruleFilesDir: writeRules(t, "noted path log ^/\n"+testRules),
+		banResponse:  "429",
 	})
 	start := clk.Now()
 
@@ -112,7 +112,7 @@ func TestEachRuleActionAddsTheExploitSignatureTag(t *testing.T) {
 	t.Parallel()
 
 	s, _, _ := startWithClock(t, "", map[string]string{
-		rulesDir: writeRules(t, "noted path log ^/noted$\n"+testRules),
+		ruleFilesDir: writeRules(t, "noted path log ^/noted$\n"+testRules),
 	})
 
 	wantTags(
@@ -129,7 +129,7 @@ func TestRuleRefusalNamesItsHeuristicAndTheRule(t *testing.T) {
 	t.Parallel()
 
 	s, _, _ := startWithClock(t, "", map[string]string{
-		rulesDir: writeRules(t, "noted path log ^/\n"+testRules),
+		ruleFilesDir: writeRules(t, "noted path log ^/\n"+testRules),
 	})
 
 	line := s.request(client, "/blocked", http.StatusForbidden,
@@ -155,7 +155,7 @@ func TestNextClearSignOfAttackAfterABanBansPermanently(t *testing.T) {
 	t.Parallel()
 
 	s, clk, _ := startWithClock(t, "", map[string]string{
-		rulesDir:          writeRules(t, testRules),
+		ruleFilesDir:      writeRules(t, testRules),
 		attackBanDuration: "1h",
 	})
 
@@ -193,7 +193,7 @@ func TestRulesComeAfterTheOtherChecks(t *testing.T) {
 	)
 
 	s, _, server := startWithClock(t, "", map[string]string{
-		rulesDir:            writeRules(t, testRules),
+		ruleFilesDir:        writeRules(t, testRules),
 		allowNets:           allowed,
 		rateLimitExemptNets: exempt,
 		rateLimitPerMinute:  "1",
@@ -234,8 +234,8 @@ func TestObserveModeLogsWhatTheRulesWouldDo(t *testing.T) {
 	t.Parallel()
 
 	s, _, server := startWithClock(t, "", map[string]string{
-		rulesDir: writeRules(t, testRules),
-		mode:     observe,
+		ruleFilesDir: writeRules(t, testRules),
+		mode:         observe,
 	})
 
 	line := s.request(
@@ -273,7 +273,7 @@ func TestMetricsCountRuleMatchesAndBansForAnAttack(t *testing.T) {
 	t.Parallel()
 
 	s, _, _ := startWithClock(t, "", map[string]string{
-		rulesDir:     writeRules(t, testRules),
+		ruleFilesDir: writeRules(t, testRules),
 		metricsToken: token,
 	})