Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/waf/bans_test.go

@@ -90,10 +90,10 @@ func TestBanLengthsFollowTheSettings(t *testing.T) {
 	t.Parallel()
 
 	s, clk, _ := startWithClock(t, "", map[string]string{
-		rateLimitPerMinute:   "1",
-		limitBanDuration:     "10m",
-		limitBanRepeatWindow: "1h",
-		maxBanDuration:       "1h",
+		rateLimitPerMinute:     "1",
+		limitBanDuration:       "10m",
+		limitBanRepeatWindow:   "1h",
+		limitBanPermanentAbove: "1h",
 	})
 
 	// breakLimit has client go over the limit of one a minute, and
@@ -130,7 +130,7 @@ func TestBanLengthsFollowTheSettings(t *testing.T) {
 	clk.advance(10 * time.Minute)
 	wantExpires(breakLimit(), 30*time.Minute)
 
-	// 90 minutes would be longer than SWW_WAF_MAX_BAN_DURATION: the ban is
+	// 90 minutes would be longer than SWW_WAF_LIMIT_BAN_PERMANENT_ABOVE: the ban is
 	// permanent.
 	clk.advance(30 * time.Minute)
 
@@ -256,10 +256,10 @@ func TestBannedClientIsRefusedBeforeItsCountryIsLookedUp(t *testing.T) {
 
 	geojsURL, asked := startGeoJS(t)
 	s, _, _ := startWithClock(t, geojsURL, map[string]string{
-		lookupTimeout:      "1h",
-		rateLimitPerMinute: "1",
-		banScopeV4Prefix:   "24",
-		tagDeny:            denyKP,
+		asnAndCountryLookupTimeout: "3600000",
+		rateLimitPerMinute:         "1",
+		banScopeV4Prefix:           "24",
+		tagDeny:                    denyKP,
 	})
 
 	// fromDE's ban covers otherClient, which is refused unasked about.
@@ -319,10 +319,10 @@ func TestBanResponseAnswersEveryRefusalButTheSizeLimits(t *testing.T) {
 
 			geojsURL, _ := startGeoJS(t)
 			env := map[string]string{
-				lookupTimeout:      "1h",
-				rateLimitPerMinute: "1",
-				denyNets:           denied,
-				tagDeny:            denyKP,
+				asnAndCountryLookupTimeout: "3600000",
+				rateLimitPerMinute:         "1",
+				denyNets:                   denied,
+				tagDeny:                    denyKP,
 			}
 
 			if tc.setting != "" {
@@ -345,9 +345,9 @@ func TestBanNotes(t *testing.T) {
 
 	geojsURL, _ := startGeoJS(t)
 	s, clk, server := startWithClock(t, geojsURL, map[string]string{
-		lookupTimeout:      "1h",
-		rateLimitPerMinute: "1",
-		tagDeny:            denyKP,
+		asnAndCountryLookupTimeout: "3600000",
+		rateLimitPerMinute:         "1",
+		tagDeny:                    denyKP,
 	})
 	start := clk.Now()