Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/sww/sww.go

@@ -116,7 +116,7 @@ func RunWAF(ctx context.Context, params Params) int {
 	processLog := requestlog.NewProcessLogger(params.Stdout,
 		config.InstanceName(params.Viper), slog.LevelError)
 
-	cfg, err := config.FromEnvironment(params.Viper)
+	cfg, err := config.WAFFromEnvironment(params.Viper)
 	if err != nil {
 		return cannotStart(processLog, "invalid setting", err)
 	}
@@ -159,7 +159,7 @@ func RunWAF(ctx context.Context, params Params) int {
 func runWAFWithSettings(
 	ctx context.Context,
 	version string,
-	cfg *config.Config,
+	cfg *config.WAF,
 	stdout io.Writer,
 	remote *remotelog.Sender,
 	processLog *slog.Logger,
@@ -170,8 +170,8 @@ func runWAFWithSettings(
 	alertQueue := newAlertQueue(cfg, now, processLog)
 
 	ruleFiles, err := rules.Load(rules.Params{
-		Dir:        cfg.RulesDir,
-		Enabled:    cfg.RulesEnabled,
+		Dir:        cfg.RuleFilesDir,
+		Enabled:    cfg.RuleFilesEnabled,
 		ProcessLog: processLog,
 		Alerts:     alertQueue,
 	})
@@ -246,7 +246,7 @@ func cannotStart(processLog *slog.Logger, message string, err error) int {
 // after reading the lookup database while SWW_WAF_LOOKUP_SOURCE is file. A lookup
 // database that cannot be read is an error.
 func newServer(
-	cfg *config.Config, stdout io.Writer, processLog *slog.Logger,
+	cfg *config.WAF, stdout io.Writer, processLog *slog.Logger,
 	now func() time.Time, ruleFiles *rules.Files, alertQueue *alerts.Queue,
 	crs *coreruleset.CoreRuleSet,
 ) (*waf.Server, error) {
@@ -293,33 +293,33 @@ func newServer(
 // loadStateFiles reads the state and cache files into the parts of server and
 // into alertQueue, as state.Load does.
 func loadStateFiles(
-	cfg *config.Config, server *waf.Server, alertQueue *alerts.Queue,
+	cfg *config.WAF, server *waf.Server, alertQueue *alerts.Queue,
 	now func() time.Time, processLog *slog.Logger,
 ) (*state.Files, error) {
 	return state.Load(state.Params{
-		Dir:             cfg.StateDir,
-		CacheDir:        cfg.CacheDir,
-		WriteDelay:      cfg.StateWriteDelay,
-		CounterInterval: cfg.StateCounterInterval,
-		Ledger:          server.Ledger,
-		Limiter:         server.Limiter,
-		GeoJS:           server.GeoJS,
-		Lists:           server.Lists,
-		DNSBL:           server.DNSBL,
-		AbuseIPDB:       server.AbuseIPDB,
-		RouteWatch:      server.RouteWatch,
-		Alerts:          alertQueue,
-		Anomalies:       server.Anomalies,
-		Now:             now,
-		ProcessLog:      processLog,
-		Metrics:         server.Metrics,
+		Dir:            cfg.StateDir,
+		CacheDir:       cfg.CacheDir,
+		BansWriteDelay: cfg.BansWriteDelay,
+		WriteInterval:  cfg.StateWriteInterval,
+		Ledger:         server.Ledger,
+		Limiter:        server.Limiter,
+		GeoJS:          server.GeoJS,
+		Lists:          server.Lists,
+		DNSBL:          server.DNSBL,
+		AbuseIPDB:      server.AbuseIPDB,
+		RouteWatch:     server.RouteWatch,
+		Alerts:         alertQueue,
+		Anomalies:      server.Anomalies,
+		Now:            now,
+		ProcessLog:     processLog,
+		Metrics:        server.Metrics,
 	})
 }
 
 // newAlertQueue returns the queue of the alerts to the webhook, Slack and
 // ntfy, with the settings for them.
 func newAlertQueue(
-	cfg *config.Config, now func() time.Time, processLog *slog.Logger,
+	cfg *config.WAF, now func() time.Time, processLog *slog.Logger,
 ) *alerts.Queue {
 	return alerts.New(alerts.Params{
 		WebhookURL:     cfg.AlertWebhookURL,
@@ -338,13 +338,13 @@ func newAlertQueue(
 
 // newRemoteLogSender returns a sender of the log lines to
 // SWW_WAF_LOG_REMOTE_URL, with the settings for it.
-func newRemoteLogSender(cfg *config.Config) *remotelog.Sender {
+func newRemoteLogSender(cfg *config.WAF) *remotelog.Sender {
 	return remotelog.New(remotelog.Params{
-		URL:      cfg.LogRemoteURL,
-		RootCAs:  cfg.LogRemoteTLSCAs,
-		Buffer:   cfg.LogRemoteBuffer,
-		Facility: cfg.LogRemoteFacility,
-		AppName:  cfg.LogRemoteAppName,
+		URL:         cfg.LogRemoteURL,
+		RootCAs:     cfg.LogRemoteTLSCAs,
+		BufferLines: cfg.LogRemoteBufferLines,
+		Facility:    cfg.LogRemoteFacility,
+		AppName:     cfg.LogRemoteAppName,
 	})
 }