Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/sww/rproxy_test.go

@@ -31,8 +31,8 @@ const (
 	rproxyListenAddr = "SWW_RPROXY_LISTEN_ADDR"
 	// rproxyUpstreamURL is the setting that says where the app is.
 	rproxyUpstreamURL = "SWW_RPROXY_UPSTREAM_URL"
-	// rproxyTimeout is the setting that says how long rproxy waits for waf.
-	rproxyTimeout = "SWW_RPROXY_TIMEOUT_MS"
+	// wafBackendTimeout is the setting that says how long rproxy waits for waf.
+	wafBackendTimeout = "SWW_RPROXY_WAF_BACKEND_TIMEOUT_MS"
 	// bannedProbe is a path the default rule file bans a client for.
 	bannedProbe = "/.env"
 	// otherClient is a client the tests do not ban.
@@ -135,9 +135,9 @@ func wafSettings(t *testing.T) map[string]string {
 	t.Helper()
 
 	return map[string]string{
-		listenAddr: localhost + ":0",
-		stateDir:   t.TempDir(),
-		rulesDir:   filepath.Join("..", "..", "share", "rules.d"),
+		listenAddr:   localhost + ":0",
+		stateDir:     t.TempDir(),
+		ruleFilesDir: filepath.Join("..", "..", "share", "rules.d"),
 	}
 }
 
@@ -241,12 +241,13 @@ func TestTheSiteAnswersWhileWAFIsStoppedAndStartedAgain(t *testing.T) {
 	forwardTo("")
 	stop()
 
-	// With waf down, the site answers, and rproxy says the default did it.
+	// With waf down, the site answers, and rproxy says
+	// SWW_RPROXY_WAF_BACKEND_NO_ANSWER_DISPOSITION did it.
 	wantStatus(t, site+"/after-stop", placed, http.StatusOK)
 
 	line := out.line(t, "path", "/after-stop")
 	if line["disposition"] != waf.DispositionAllow ||
-		line["default_disposition"] != true {
+		line["waf_backend_no_answer"] != true {
 		t.Errorf("rproxy's line is %v", line)
 	}
 
@@ -475,7 +476,7 @@ func TestATargetThatCannotGoToWAFIsRefusedForABannedClient(t *testing.T) {
 	}
 
 	line := out.line(t, "path", "admin")
-	if line["disposition"] != nil || line["default_disposition"] != nil {
+	if line["disposition"] != nil || line["waf_backend_no_answer"] != nil {
 		t.Errorf("rproxy's line is %v, want no disposition", line)
 	}
 }
@@ -496,7 +497,7 @@ func TestAClientWithAZoneIsTheClientWithout(t *testing.T) {
 
 	line := out.line(t, "path", bannedProbe)
 	if line["client_ip"] != "2001:db8::1" ||
-		line["default_disposition"] != nil {
+		line["waf_backend_no_answer"] != nil {
 		t.Errorf("rproxy's line is %v", line)
 	}
 }
@@ -691,7 +692,7 @@ func TestRProxyStoppingWaitsForAReportBeingSent(t *testing.T) {
 	env := map[string]string{
 		rproxyListenAddr:          localhost + ":0",
 		"SWW_RPROXY_UPSTREAM_URL": startApp(t),
-		rproxyTimeout:             "60000",
+		wafBackendTimeout:         "60000",
 		wafBackend:                backend.URL,
 	}
 	out := &output{}
@@ -855,8 +856,8 @@ func TestRProxyInvalidSettingStopsTheStart(t *testing.T) {
 	}{
 		{"no backend", wafBackend, nil},
 		{
-			"another invalid", rproxyTimeout,
-			map[string]string{wafBackend: "http://waf:8080", rproxyTimeout: "soon"},
+			"another invalid", wafBackendTimeout,
+			map[string]string{wafBackend: "http://waf:8080", wafBackendTimeout: "soon"},
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {