Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/waf/bytelimits_test.go

@@ -22,10 +22,10 @@ const (
 	bytesLimitPerMinute = "SWW_WAF_BYTES_LIMIT_PER_MINUTE"
 	bytesLimitPerHour   = "SWW_WAF_BYTES_LIMIT_PER_HOUR"
 	bytesLimitPerDay    = "SWW_WAF_BYTES_LIMIT_PER_DAY"
-	bytesCount          = "SWW_WAF_BYTES_COUNT"
+	bytesCounted        = "SWW_WAF_BYTES_COUNTED"
 )
 
-// The values of SWW_WAF_BYTES_COUNT.
+// The values of SWW_WAF_BYTES_COUNTED.
 const (
 	countResponse = "response"
 	countRequest  = "request"
@@ -212,7 +212,7 @@ func TestWebSocketBytesAreCountedOnceItCloses(t *testing.T) {
 				t,
 				answerAfterUpgrade,
 				map[string]string{
-					bytesLimitPerMinute: "29", bytesCount: tc.setting,
+					bytesLimitPerMinute: "29", bytesCounted: tc.setting,
 				},
 			)
 
@@ -239,7 +239,7 @@ func TestWebSocketBytesAreCountedOnceItCloses(t *testing.T) {
 	}
 }
 
-func TestBytesCountSaysWhichBytesCount(t *testing.T) {
+func TestBytesCountedSaysWhichBytesAreCounted(t *testing.T) {
 	t.Parallel()
 
 	for _, tc := range []struct {
@@ -257,7 +257,7 @@ func TestBytesCountSaysWhichBytesCount(t *testing.T) {
 			t.Parallel()
 
 			s, _ := startWithAnswers(t, map[string]string{
-				bytesLimitPerMinute: byteLimit, bytesCount: tc.setting,
+				bytesLimitPerMinute: byteLimit, bytesCounted: tc.setting,
 			})
 
 			for i := 1; i <= tc.breaking; i++ {