Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/waf/biased.go

@@ -17,14 +17,15 @@ type percentage struct {
 }
 
 // biasedThresholdsSet reports whether a biased threshold can lower a
-// client's limits by its lookup: SWW_WAF_ASN_BYTES_PERCENT or
-// SWW_WAF_COUNTRY_BYTES_PERCENT is not empty, SWW_WAF_UNKNOWN_LIMIT_PERCENT is
-// below 100, or SWW_WAF_ASN_LIMIT_PERCENT_URL is set. The client's lookup is
+// client's limits by its lookup: SWW_WAF_ASN_BYTES_LIMIT_PERCENT or
+// SWW_WAF_COUNTRY_BYTES_LIMIT_PERCENT is not empty,
+// SWW_WAF_UNKNOWN_COUNTRY_LIMIT_PERCENT is below 100, or
+// SWW_WAF_ASN_LIMIT_PERCENT_URL is set. The client's lookup is
 // then needed before its request goes on.
-func biasedThresholdsSet(cfg *config.Config) bool {
-	return len(cfg.ASNBytesPercent) > 0 ||
-		len(cfg.CountryBytesPercent) > 0 ||
-		cfg.UnknownLimitPercent < whole ||
+func biasedThresholdsSet(cfg *config.WAF) bool {
+	return len(cfg.ASNBytesLimitPercent) > 0 ||
+		len(cfg.CountryBytesLimitPercent) > 0 ||
+		cfg.UnknownCountryLimitPercent < whole ||
 		cfg.ASNLimitPercentURL != ""
 }
 
@@ -37,13 +38,13 @@ func biasedThresholdsSet(cfg *config.Config) bool {
 // SWW_WAF_ASN_LIMIT_PERCENT_URL names gives its AS number, the one
 // SWW_WAF_TAG_LIMIT_PERCENT gives its country= tag, the lowest it gives its
 // other tags, for a client without a country, unless its request skipped
-// the wait for GeoJS, SWW_WAF_UNKNOWN_LIMIT_PERCENT, for a client a blocklist
+// the wait for GeoJS, SWW_WAF_UNKNOWN_COUNTRY_LIMIT_PERCENT, for a client a blocklist
 // lists, the percentage of SWW_WAF_BLOCKLIST_ACTION while it is limit, and
 // for a client a DNSBL zone's verdict lists, or whose AbuseIPDB score is
-// a hit, the percentage of SWW_WAF_REPUTATION_ACTION while it is limit. For
-// the byte limits, SWW_WAF_ASN_BYTES_PERCENT and SWW_WAF_COUNTRY_BYTES_PERCENT
-// take the place of the first three for an AS number or a country they
-// list.
+// a hit, the percentage of SWW_WAF_DNSBL_ABUSEIPDB_ACTION while it is limit. For
+// the byte limits, SWW_WAF_ASN_BYTES_LIMIT_PERCENT and
+// SWW_WAF_COUNTRY_BYTES_LIMIT_PERCENT take the place of the first three for
+// an AS number or a country they list.
 func (rq *request) limitPercentages() (percentage, percentage) {
 	cfg := rq.h.config
 	asn, country := rq.line.ASN, rq.line.Country
@@ -51,8 +52,8 @@ func (rq *request) limitPercentages() (percentage, percentage) {
 	unknown := percentage{percent: whole}
 	if country == "" && !rq.skippedLookupWait {
 		unknown = percentage{
-			cfg.UnknownLimitPercent,
-			"SWW_WAF_UNKNOWN_LIMIT_PERCENT",
+			cfg.UnknownCountryLimitPercent,
+			"SWW_WAF_UNKNOWN_COUNTRY_LIMIT_PERCENT",
 		}
 	}
 
@@ -71,10 +72,10 @@ func (rq *request) limitPercentages() (percentage, percentage) {
 
 	reputationListed := percentage{percent: whole}
 	if (rq.dnsblListed || rq.abuseIPDBHit) &&
-		cfg.ReputationAction == "limit" {
+		cfg.DNSBLAbuseIPDBAction == "limit" {
 		reputationListed = percentage{
-			cfg.ReputationLimitPercent,
-			"SWW_WAF_REPUTATION_ACTION",
+			cfg.DNSBLAbuseIPDBLimitPercent,
+			"SWW_WAF_DNSBL_ABUSEIPDB_ACTION",
 		}
 	}
 
@@ -102,19 +103,19 @@ func (rq *request) limitPercentages() (percentage, percentage) {
 	}
 
 	asnBytes, countryBytes := asnRequests, countryRequests
-	if _, listed := cfg.ASNBytesPercent[asn]; listed {
+	if _, listed := cfg.ASNBytesLimitPercent[asn]; listed {
 		asnBytes = given(
-			cfg.ASNBytesPercent,
+			cfg.ASNBytesLimitPercent,
 			asn,
-			"SWW_WAF_ASN_BYTES_PERCENT",
+			"SWW_WAF_ASN_BYTES_LIMIT_PERCENT",
 		)
 	}
 
-	if _, listed := cfg.CountryBytesPercent[country]; listed {
+	if _, listed := cfg.CountryBytesLimitPercent[country]; listed {
 		countryBytes = given(
-			cfg.CountryBytesPercent,
+			cfg.CountryBytesLimitPercent,
 			country,
-			"SWW_WAF_COUNTRY_BYTES_PERCENT",
+			"SWW_WAF_COUNTRY_BYTES_LIMIT_PERCENT",
 		)
 	}