Rename the settings whose names do not say what they control (closes #234)

Applies the setting renames of the naming audit under the SWW_WAF_ and
SWW_RPROXY_ prefixes, with sneak's names for the IP reputation cache
time and the two time limits, which now take milliseconds. The rproxy
log field default_disposition becomes waf_backend_no_answer, and
config.Config and config.FromEnvironment become config.WAF and
config.WAFFromEnvironment. Go fields, test names and prose follow. No
aliases; nothing reads the old names.

Model: opus-5-5

internal/rproxy/rproxy_test.go

@@ -44,13 +44,13 @@ const (
 
 // The settings the tests set.
 const (
-	timeoutSetting     = "SWW_RPROXY_TIMEOUT_MS"
-	defaultDisposition = "SWW_RPROXY_DEFAULT_DISPOSITION"
-	trustedProxies     = "SWW_RPROXY_TRUSTED_PROXIES"
-	maxRequestSize     = "SWW_RPROXY_MAX_REQUEST_SIZE"
-	maxResponseSize    = "SWW_RPROXY_MAX_RESPONSE_SIZE"
-	maxRequestTime     = "SWW_RPROXY_MAX_REQUEST_TIME_MS"
-	maxResponseTime    = "SWW_RPROXY_MAX_RESPONSE_TIME_MS"
+	timeoutSetting  = "SWW_RPROXY_WAF_BACKEND_TIMEOUT_MS"
+	noAnswerSetting = "SWW_RPROXY_WAF_BACKEND_NO_ANSWER_DISPOSITION"
+	trustedProxies  = "SWW_RPROXY_TRUSTED_PROXIES"
+	maxRequestSize  = "SWW_RPROXY_MAX_REQUEST_SIZE"
+	maxResponseSize = "SWW_RPROXY_MAX_RESPONSE_SIZE"
+	maxRequestTime  = "SWW_RPROXY_MAX_REQUEST_TIME_MS"
+	maxResponseTime = "SWW_RPROXY_MAX_RESPONSE_TIME_MS"
 )
 
 // The headers the tests set and look at.
@@ -774,7 +774,7 @@ func TestDenyGivesTheVisitorWAFsAnswer(t *testing.T) {
 
 	line := out.requestLine(t)
 	if line["disposition"] != dispositionDeny ||
-		line["default_disposition"] != nil {
+		line["waf_backend_no_answer"] != nil {
 		t.Errorf("line %v, want waf's deny", line)
 	}
 }
@@ -1031,7 +1031,7 @@ func TestAnAnswerOtherThanAllowGoesToTheVisitorAsWAFGaveIt(t *testing.T) {
 					standIn.URL,
 					app.URL,
 					map[string]string{
-						defaultDisposition: setting,
+						noAnswerSetting: setting,
 					},
 				)
 
@@ -1047,7 +1047,7 @@ func TestAnAnswerOtherThanAllowGoesToTheVisitorAsWAFGaveIt(t *testing.T) {
 
 				line := out.requestLine(t)
 				if line["status"] != float64(tc.status) ||
-					line["default_disposition"] != nil {
+					line["waf_backend_no_answer"] != nil {
 					t.Errorf(
 						"line %v, want status %d and no default",
 						line,
@@ -1213,8 +1213,8 @@ func TestAnAnswerThatCannotBePassedOnIsAnswered502(t *testing.T) {
 					backend(t),
 					app.URL,
 					map[string]string{
-						timeoutSetting:     "60000",
-						defaultDisposition: setting,
+						timeoutSetting:  "60000",
+						noAnswerSetting: setting,
 					},
 				)
 
@@ -1224,7 +1224,7 @@ func TestAnAnswerThatCannotBePassedOnIsAnswered502(t *testing.T) {
 
 				line := out.requestLine(t)
 				if line["status"] != float64(http.StatusBadGateway) ||
-					line["disposition"] != nil || line["default_disposition"] != nil {
+					line["disposition"] != nil || line["waf_backend_no_answer"] != nil {
 					t.Errorf(
 						"line %v, want status 502 and no disposition",
 						line,
@@ -1274,7 +1274,7 @@ func TestWithoutAnAnswerTheDefaultDispositionDecides(t *testing.T) {
 
 			line := out.requestLine(t)
 			if line["disposition"] != dispositionAllow ||
-				line["default_disposition"] != true {
+				line["waf_backend_no_answer"] != true {
 				t.Errorf("line %v, want allow by default", line)
 			}
 		})
@@ -1290,8 +1290,8 @@ func TestWithoutAnAnswerTheDefaultDispositionDecides(t *testing.T) {
 				backend(t),
 				app.URL,
 				map[string]string{
-					timeoutSetting:     "200",
-					defaultDisposition: dispositionDeny,
+					timeoutSetting:  "200",
+					noAnswerSetting: dispositionDeny,
 				},
 			)
 
@@ -1302,7 +1302,7 @@ func TestWithoutAnAnswerTheDefaultDispositionDecides(t *testing.T) {
 
 			line := out.requestLine(t)
 			if line["disposition"] != dispositionDeny ||
-				line["default_disposition"] != true {
+				line["waf_backend_no_answer"] != true {
 				t.Errorf("line %v, want deny by default", line)
 			}
 		})
@@ -1330,8 +1330,8 @@ func TestAVisitorThatGoesAwayWhileWAFIsAskedGetsNoDefault(t *testing.T) {
 				standIn.URL,
 				app.URL,
 				map[string]string{
-					timeoutSetting:     "60000",
-					defaultDisposition: disposition,
+					timeoutSetting:  "60000",
+					noAnswerSetting: disposition,
 				},
 			)
 
@@ -1343,7 +1343,7 @@ func TestAVisitorThatGoesAwayWhileWAFIsAskedGetsNoDefault(t *testing.T) {
 
 			line := out.requestLine(t)
 			if line["status"] != 0.0 || line["disposition"] != nil ||
-				line["default_disposition"] != nil {
+				line["waf_backend_no_answer"] != nil {
 				t.Errorf("line %v, want status 0 and no disposition", line)
 			}
 
@@ -1892,10 +1892,10 @@ func TestLogLineGivesTheRequestAsSent(t *testing.T) {
 		}
 	}
 
-	if line["default_disposition"] != nil {
+	if line["waf_backend_no_answer"] != nil {
 		t.Errorf(
-			"default_disposition is %v, want it left out",
-			line["default_disposition"],
+			"waf_backend_no_answer is %v, want it left out",
+			line["waf_backend_no_answer"],
 		)
 	}