fix: JSONHandler deadlock from recursive log.Println (closes #3) #4

clawbot · 2026-02-08T18:15:36+01:00

clawbot okomentoval

2026-02-08 18:15:36 +01:00

Spolupracovník

JSONHandler.Handle() called log.Println() to output JSON. Since Go 1.22+ bridges the standard log package through slog, and simplelog replaces the default slog handler in init(), this creates a recursive call that deadlocks on the log mutex.

Fix: replace log.Println with fmt.Fprintln(os.Stdout, ...) to write directly without going through the log/slog bridge.

Tested with the README example — runs cleanly now instead of deadlocking.

Closes #3

`JSONHandler.Handle()` called `log.Println()` to output JSON. Since Go 1.22+ bridges the standard `log` package through `slog`, and simplelog replaces the default slog handler in `init()`, this creates a recursive call that deadlocks on the log mutex. Fix: replace `log.Println` with `fmt.Fprintln(os.Stdout, ...)` to write directly without going through the log/slog bridge. Tested with the README example — runs cleanly now instead of deadlocking. Closes #3

clawbot přidal/a 1 commit 2026-02-08 18:15:36 +01:00

fix: replace log.Println with fmt.Fprintln in JSONHandler to prevent deadlock 869b7ca4c3

sneak okomentoval

2026-02-08 18:18:27 +01:00

Vlastník

please write a failing test for this on another PR

sneak okomentoval

2026-02-08 18:19:12 +01:00

Vlastník

@clawbot verify that the failing test is fixed by this patch

clawbot odkazoval/a na tento pull request

2026-02-08 18:21:21 +01:00

test: add deadlock regression test for JSONHandler (issue #3) #7

clawbot okomentoval

2026-02-08 18:21:33 +01:00

Autor

Spolupracovník

I wrote a regression test for this deadlock bug (see PR #7). The test reproduces the issue by calling slog.Info() with JSONHandler as the default handler and using a 5-second timeout to detect the deadlock.

Results:

❌ On main (without fix): test hangs/deadlocks as expected
✅ On fix/json-handler-deadlock (with fix): test passes immediately

=== RUN   TestJSONHandlerDeadlock
--- PASS: TestJSONHandlerDeadlock (0.00s)
PASS

Confirmed: this PR correctly fixes the deadlock.

I wrote a regression test for this deadlock bug (see PR #7). The test reproduces the issue by calling `slog.Info()` with `JSONHandler` as the default handler and using a 5-second timeout to detect the deadlock. **Results:** - ❌ On `main` (without fix): test hangs/deadlocks as expected - ✅ On `fix/json-handler-deadlock` (with fix): test passes immediately ``` === RUN TestJSONHandlerDeadlock --- PASS: TestJSONHandlerDeadlock (0.00s) PASS ``` Confirmed: this PR correctly fixes the deadlock.

sneak odkázal na tento úkol z commitu

2026-02-08 18:27:15 +01:00

test: add deadlock regression test for JSONHandler

sneak okomentoval

2026-02-08 18:29:04 +01:00

Vlastník

@clawbot remember to always make your PR source branches in the repo in question, not as a fork in your own user account.

sneak přidal/a 1 commit 2026-02-08 18:29:14 +01:00

Merge branch 'main' into fix/json-handler-deadlock 74ce052b77

sneak sloučený commit 9121da9aae do main

2026-02-08 18:29:55 +01:00

sneak odstranil/a větev fix/json-handler-deadlock