Correct four inaccurate comments in cancel_test.go and rename a constant (closes #33) #59

Open
clawbot wants to merge 1 commits from issue-33-cancel-test-comments into next
1 Commits
Author SHA1 Message Date
sneak 55f824468c Correct four inaccurate comments in cancel_test.go and rename a constant (closes #33)
check / check (push) Failing after 0s
Cleanup of the non-blocking findings from the re-review of #6. The tests
were never wrong; only comments that misdescribed the mechanism they
document, and one constant whose name claimed the wrong quantity.

- State the property the walkClock tests rely on (the index load's
  Done cost is bounded and independent of record count) instead of the
  wrong "three consultations" figure.
- Stop the poolUnwind framing from implying every test is bounded at
  two seconds; the three tests that catch their regression only as the
  test binary's timeout now say so.
- Record that hashWorker's results-send abandon branch is reachable
  from the scan path and is covered by TestScanHashWriteFailureUnwindsPool,
  so every cancellation branch has a test.
- Rename walkCancelInFlightDirs to walkCancelInFlightFiles: it is a
  file count (same value).
- Note the deliberate departure from the one-test-file-per-source-file
  convention at the top of the file.

Model: opus-4-8
2026-09-21 07:44:17 +00:00