4 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
clawbot	076d82231b	Merge branch 'hash-pool-cleanup': unwind the hash worker pool on error (closes #6) ... hashPhase returned early on a recordRun error, abandoning the feeder goroutine and the hash workers, which parked forever on channel sends. The pool is now owned: every blocking send selects on ctx.Done(), and hashPhase defers a stop() that cancels and then drains results. ctx is threaded from cmd.Context() through runScan, syncScan, both pools and the database layer, as contextcheck requires. The walk pool gets the same treatment. It does not leak today, because walkPhase has no early return, but #5 introduces one. That change also required a ctx.Err() guard after the walk: a cancelled walk yields a partial size census, and without the guard the update phase reads every unreached file as vanished and deletes its record. First review failed this: the test covering that guard was vacuous, cancelling before the walk began. Replaced with a deterministic mid-walk cancellation. Re-reviewed independently by a fresh reviewer, who reproduced both falsification checks, measured the census across four parallelism settings, mutation-verified all nine cancellation branches, ran 120 randomised mid-flight cancellations over 18,000 files with zero records lost, and forced a cold Docker build after finding the cached one proved nothing. Coverage 88.5%.	2026-08-09 07:46:43 +02:00
clawbot	2a055c0104	Merge branch 'db-close-on-fatal': close the database on every exit path (closes #4) ... fatalf called os.Exit(1), which skips deferred functions, so every defer db.Close() was dead on the fatal path and the SQLite WAL was never checkpointed. fatalf is gone; runScan, runReport and runTrees return errors, and a single run(args, stderr) int in main.go is the only exit point, which also makes these paths testable in-process. Exit-code behaviour is unchanged: 0 success, 1 fatal, 2 usage. A runE adapter keeps cobra from reclassifying runtime failures as usage errors or printing usage text alongside them. Independently reviewed. The reviewer verified all 15 documented exit paths against binaries built from both base and head, confirmed the sidecar WAL files no longer survive a fatal exit, and mutation-tested the new assertions by reintroducing the defect to confirm they fail. Coverage 64% to 86.9%. make check and make docker both green.	2026-08-09 04:39:28 +02:00
clawbot	ce6d29dffb	Merge branch 'todo-next-step-stale': point TODO.md at the tracker (closes #27) ... TODO.md's Next Step still named the scripts-to-rule-them-all conversion, which landed in 3abeacf on 2026-07-26 without recording itself in Completed Steps, so the file pointed the next contributor at finished work. Next Step now names the 1.0.0 milestone on the tracker, the scaffold gains its missing Completed Steps entry, and Workflow matches the issue-branch-review-merge process actually in use. Docs-only change (TODO.md only), so the adversarial review was skipped per the standing exception. make check green.	2026-08-09 04:05:04 +02:00
clawbot	38a01bd27c	Merge branch 'golangci-v2.12.2': golangci-lint v2.12.2 and canonical config (closes #3) ... Bumps the pinned golangci-lint from v2.12.1 to v2.12.2 in the Dockerfile lint stage and script/bootstrap, and replaces .golangci.yml with the canonical org-standard file (sha256 021cc83f4e6fc7c31b95b34b846723dfcf20b66b7baeea1dc40406e643346bcb). The material change is that the lll, funlen, cyclop and dupl thresholds move from the v1-style top-level linters-settings key, which golangci-lint v2 silently ignores, to linters.settings, where they are actually enforced. Independent review proved the migration claim with a controlled experiment and confirmed the code passes the now-live thresholds with zero findings. Reviewed independently; make check and make docker both green.	2026-08-09 03:57:09 +02:00