sneak
9ee216f629
All checks were successful
check / check (push) Successful in 1m8s
- Replace .golangci.yml with the canonical strict config (all linters enabled except the standard disable list; lll 88, funlen 80/50, cyclop 15, dupl 100; test files now linted) - Pin the Dockerfile lint stage to golangci/golangci-lint:v2.12.2 by tag and digest (Debian-based) - Fix all ~1550 findings surfaced by the new config: line wrapping, wsl_v5/nlreturn blank lines, noinlineerr splits, err113 sentinel errors, perfsprint/modernize rewrites, goconst constants, thelper, testifylint, noctx CommandContext, testpackage conversions, t.Parallel() where safe, and complexity/dupl helper extraction - Record the change and follow-up items in TODO.md
81 lines
2.3 KiB
Go
81 lines
2.3 KiB
Go
package cli_test
|
|
|
|
import (
|
|
"bytes"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"git.eeqj.de/sneak/secret/internal/secret"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestGetCommandOutputsToStdout tests that 'secret get' outputs the secret
|
|
// value to stdout, not stderr
|
|
func TestGetCommandOutputsToStdout(t *testing.T) {
|
|
// Create a temporary directory for our vault
|
|
tempDir := t.TempDir()
|
|
|
|
// Set environment variables for the test
|
|
t.Setenv(secret.EnvStateDir, tempDir)
|
|
|
|
// Find the secret binary path
|
|
wd, err := filepath.Abs("../..")
|
|
require.NoError(t, err, "should get working directory")
|
|
|
|
secretPath := filepath.Join(wd, "secret")
|
|
testPassphrase := "test-passphrase"
|
|
|
|
// Initialize vault
|
|
//nolint:gosec // G204: test executes the freshly built secret binary
|
|
cmd := exec.CommandContext(t.Context(), secretPath, "init")
|
|
cmd.Env = []string{
|
|
secret.EnvStateDir + "=" + tempDir,
|
|
secret.EnvMnemonic + "=" + testMnemonic,
|
|
secret.EnvUnlockPassphrase + "=" + testPassphrase,
|
|
"PATH=" + "/usr/bin:/bin",
|
|
}
|
|
|
|
output, err := cmd.CombinedOutput()
|
|
require.NoError(t, err, "init should succeed: %s", string(output))
|
|
|
|
// Add a secret
|
|
//nolint:gosec // G204: test executes the freshly built secret binary
|
|
cmd = exec.CommandContext(t.Context(), secretPath, "add", "test/secret")
|
|
cmd.Env = []string{
|
|
secret.EnvStateDir + "=" + tempDir,
|
|
secret.EnvMnemonic + "=" + testMnemonic,
|
|
"PATH=" + "/usr/bin:/bin",
|
|
}
|
|
cmd.Stdin = strings.NewReader("test-secret-value")
|
|
|
|
output, err = cmd.CombinedOutput()
|
|
require.NoError(t, err, "add should succeed: %s", string(output))
|
|
|
|
// Test that 'secret get' outputs to stdout, not stderr
|
|
//nolint:gosec // G204: test executes the freshly built secret binary
|
|
cmd = exec.CommandContext(t.Context(), secretPath, "get", "test/secret")
|
|
cmd.Env = []string{
|
|
secret.EnvStateDir + "=" + tempDir,
|
|
secret.EnvMnemonic + "=" + testMnemonic,
|
|
"PATH=" + "/usr/bin:/bin",
|
|
}
|
|
|
|
var stdout, stderr bytes.Buffer
|
|
|
|
cmd.Stdout = &stdout
|
|
cmd.Stderr = &stderr
|
|
|
|
err = cmd.Run()
|
|
require.NoError(t, err, "get should succeed")
|
|
|
|
// The secret value should be in stdout
|
|
assert.Equal(t, "test-secret-value", strings.TrimSpace(stdout.String()),
|
|
"secret value should be in stdout")
|
|
|
|
// Nothing should be in stderr
|
|
assert.Empty(t, stderr.String(), "stderr should be empty")
|
|
}
|