Stop the terminal tests reading a pty nobody opened (closes #126) #127

Merged
clawbot merged 1 commits from issue-126-terminal-hang into next 2026-10-07 00:02:42 +02:00
1 Commits
Author SHA1 Message Date
sneak 48894c82f6 Stop the terminal tests reading a pty nobody opened (closes #126)
check / check (push) Waiting to run
On Linux, pty.Open of github.com/creack/pty v1.1.24 passes the address
of a local variable to ioctl as a plain number, through a function
call. When Go moved the goroutine's stack in between, the kernel wrote
the pty's number to the old place, and pty.Open opened /dev/pts/0,
another terminal. secret rm wrote there, and the test read a terminal
no program had open, which never ends. Require the commit on the
library's main branch that passes a pointer; no release has it yet.

Both terminal tests now stop reading when their one-minute context
ends, and fail saying what was still waiting.

Model: opus-5-5
2026-10-06 21:03:14 +00:00