Point the commandWait comment at the Dockerfile's test limit (closes #195)
check / check (push) Waiting to run
check / check (push) Waiting to run
The comment said script/test gives the package 30 seconds. script/test sets no time limit; the test phase of the Dockerfile sets one with go test -timeout. The comment now names that place instead of a number. Model: opus-5-5
This commit is contained in:
@@ -17,6 +17,11 @@ https://git.eeqj.de/sneak/secret/milestone/12
|
|||||||
|
|
||||||
# Completed Steps
|
# Completed Steps
|
||||||
|
|
||||||
|
- 2026-10-15: The comment on `commandWait` in `internal/cli/integration_test.go`
|
||||||
|
no longer says `script/test` gives the package 30 seconds
|
||||||
|
(https://git.eeqj.de/sneak/secret/issues/195). `script/test` sets no time
|
||||||
|
limit; the test phase of the `Dockerfile` sets one with `go test -timeout`.
|
||||||
|
The comment now names that place instead of a number.
|
||||||
- 2026-10-15: The canonical files are re-vendored from `sneak/prompts` commit
|
- 2026-10-15: The canonical files are re-vendored from `sneak/prompts` commit
|
||||||
`e3f79c4` (https://git.eeqj.de/sneak/secret/issues/129), so Go's build cache
|
`e3f79c4` (https://git.eeqj.de/sneak/secret/issues/129), so Go's build cache
|
||||||
survives between check builds and `make test` no longer compiles the standard
|
survives between check builds and `make test` no longer compiles the standard
|
||||||
|
|||||||
@@ -34,9 +34,10 @@ const (
|
|||||||
testMnemonic = "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about"
|
testMnemonic = "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about"
|
||||||
|
|
||||||
// commandWait is how long a test lets the secret binary run before it
|
// commandWait is how long a test lets the secret binary run before it
|
||||||
// kills it and fails. It stays well under the 30 seconds script/test
|
// kills it and fails. It stays well under the time limit the test phase
|
||||||
// gives the whole package, so a command that hangs fails the test with
|
// of the Dockerfile gives the whole package (go test -timeout), so a
|
||||||
// the test's own message instead of Go's timeout panic.
|
// command that hangs fails the test with the test's own message instead
|
||||||
|
// of Go's timeout panic.
|
||||||
commandWait = 10 * time.Second
|
commandWait = 10 * time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user