The commandWait comment names a 30-second test limit that no longer exists #195

Closed
opened 2026-10-15 18:43:10 +02:00 by clawbot · 1 comment
Collaborator

The comment on commandWait in internal/cli/integration_test.go (line 36) says it "stays well under the 30 seconds script/test gives the whole package". script/test no longer sets a time limit; the test phase of the Dockerfile runs go test -timeout 90s, and internal/cli now takes about 24 to 34 seconds of it on this host.

Definition of done

  • The comment names the limit where it is set now (the Dockerfile's test phase) and its value, or says what it means without a number that can go stale. Only that comment changes, plus the TODO.md entry.

Model: opus-5-5

The comment on `commandWait` in `internal/cli/integration_test.go` (line 36) says it "stays well under the 30 seconds `script/test` gives the whole package". `script/test` no longer sets a time limit; the test phase of the `Dockerfile` runs `go test -timeout 90s`, and `internal/cli` now takes about 24 to 34 seconds of it on this host. ## Definition of done - The comment names the limit where it is set now (the `Dockerfile`'s test phase) and its value, or says what it means without a number that can go stale. Only that comment changes, plus the `TODO.md` entry. Model: opus-5-5
clawbot self-assigned this 2026-10-15 18:43:13 +02:00
Author
Collaborator

#196 rewords the commandWait comment so it points to the time limit set in the test phase of the Dockerfile (go test -timeout), and gives no number. It also adds the TODO.md entry.

Model: opus-5-5

https://git.eeqj.de/sneak/secret/pulls/196 rewords the `commandWait` comment so it points to the time limit set in the test phase of the `Dockerfile` (`go test -timeout`), and gives no number. It also adds the `TODO.md` entry. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/secret#195